From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:43714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5olT-0002I6-8J for guix-patches@gnu.org; Mon, 18 Mar 2019 05:41:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5olS-0005e3-66 for guix-patches@gnu.org; Mon, 18 Mar 2019 05:41:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34553) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h5olR-0005dr-Px for guix-patches@gnu.org; Mon, 18 Mar 2019 05:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h5olR-0005mk-N0 for guix-patches@gnu.org; Mon, 18 Mar 2019 05:41:01 -0400 Subject: [bug#34729] [PATCH v2] gnu: libgit2: Avoid Python. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20190304110442.5876-1-dannym@scratchpost.org> <20190304114120.6987-1-dannym@scratchpost.org> <875zspt7ls.fsf@gnu.org> <20190311230424.4eea1499@scratchpost.org> Date: Mon, 18 Mar 2019 10:40:30 +0100 In-Reply-To: <20190311230424.4eea1499@scratchpost.org> (Danny Milosavljevic's message of "Mon, 11 Mar 2019 23:17:02 +0100") Message-ID: <87y35cplkh.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 34729@debbugs.gnu.org Hello Danny, Danny Milosavljevic skribis: > On Mon, 11 Mar 2019 22:38:07 +0100 > Ludovic Court=C3=A8s wrote: > >> Danny Milosavljevic skribis: >>=20 >> > * gnu/packages/patches/libgit2-avoid-python.patch: New file. >> > * gnu/local.mk (dist_patch_DATA): Add it. >> > * gnu/packages/version-control.scm (libgit2)[source]: Use it. >> > [inputs]: Remove python. >> > [native-inputs]: Add guile-2.2.=20=20 >>=20 >> So the goal is to remove Python from libgit2=E2=80=99s *build-time* >> dependencies, right? (Python is not a run-time dependency for libgit2 >> according to =E2=80=98guix size libgit2=E2=80=99.) Can you explain a bi= t more? :-) > > It's listed as regular input, though (for no reason). > > We use git for quite basic things in Guix (especially since we usually > use git to fetch packages from github) and we had some problems > with Python 2 (since fixed). So Andreas, Ricardo and me looked at what > on Earth libgit2 needs Python for and found that it's just one smallish > file used at build time. > > Hence the replacement :) I see, that makes sense! >> This is really cool, but at the same time I feel like we=E2=80=99d rathe= r have a >> compelling reason to start maintaining a parallel implementation of >> their test suite machinery. > > Sure, it makes sense to think about who's going to maintain it. > > In this case it's just a test case collector which basically does > > $ grep -r "void.*test_" . > > so I think the risk of it diverging is low. If it after all does diverge > (and we notice it), we can always replace it by the Python version again. > > It's pretty much a 1:1 port of the original (it's so long because > I made both the structure and the output the same), so it should be > easy to track future changes. > > libgit2 bundled it from an upstream project, "clar". That also usually > means that the bundled copy gets updated less often. OK, well let=E2=80=99s do that, then. Please make sure to add comments in = the patch that explain the rationale, things we must pay attention to when updating (if any), etc. > We could also try upstreaming it. Well, you could try, but I have a feeling that this wouldn=E2=80=99t be fruitful. :-) Thank you! Ludo=E2=80=99.