From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:34381) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9mni-0006iv-Tf for guix-patches@gnu.org; Mon, 16 Sep 2019 04:56:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i9mnh-0004ui-Rb for guix-patches@gnu.org; Mon, 16 Sep 2019 04:56:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40354) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i9mnh-0004uc-Ov for guix-patches@gnu.org; Mon, 16 Sep 2019 04:56:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i9mnh-0007F8-MK for guix-patches@gnu.org; Mon, 16 Sep 2019 04:56:01 -0400 Subject: [bug#36467] [PATCH v2] gnu: Add some Common Lisp libraries Resent-Message-ID: From: Pierre Neidhardt In-Reply-To: <87blw018x7.fsf@gnu.org> References: <20190701222716.12254-1-glv@posteo.net> <87imr7rak9.fsf@yamatai> <87blw018x7.fsf@gnu.org> Date: Mon, 16 Sep 2019 10:55:48 +0200 Message-ID: <87y2yopqln.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Guillaume Le Vaillant Cc: Katherine Cox-Buday , 36467@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Guillaume, thanks for the big patchset, looking very good overall! A few general nits: =2D You didn't define any "ecl-" package. Could you define them for all the packages (unless they are known to be broken with ECL)? I know some packages lack the ecl- definition, this should be fixed :p =2D 6 commit messages lack a period on the first line. If you use Emacs, you might find this yasnippet useful: guix/etc/snippets/text-mode/guix-commit-message-add-package fprog: - Description should start with a capital, or here maybe with @code{fprog= }. cambl: - is spelled in all-caps ("CAMBL") according to the README. cl-containers: - synopsis: "Container library ..." - I'm realizing the sbcl-lift does not have the right version number, whi= ch should be (git-version "1.7.1" ...). Can you update this? bst: - 1.1 is out ;) cl-octet-streams: - Description should start with a capital, or here maybe with @code{cl-oc= tet-streams}. cl-lzlib - License seems to be GPL-3, not GPL-3+, but since this is your library, = the decision is all yours ;) Thanks a lot for this great contribution to "Common Lisp on Guix" :) =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl1/ThQACgkQm9z0l6S7 zH+AKwf+Lu515BzNR9gfDQTjWEC51isK8Fo5xZDNljMyfZqI72Wv0rUG9B4AsBQH wXE3/w05YpZb5navtpoxRg832WS+7w3z0UdK0Ww9WwQISQ+xOp1Yvoc3oBL7jzsh bVdycJ5I7GBj+nRXo4DME3lMfZZzawZn+Cj+pYKMKtk+8mcsW7Cm3lHmy/QyYBT9 cNIYxA9OjwyvSZs50Zb/WQTAk9/V0UdS6DLF07OoklT/TpjmdvLKwtl4wUr1bboP Dcm1xG3DY3PLAcXGmrDYTxFkgwe5m3rSaHSR05eJX+/hiPG0dYw6GDc3Cm3CH9K4 cv2+y4cvGQm1/cpLorL6D4CubkQ7xA== =Buvx -----END PGP SIGNATURE----- --=-=-=--