bug#37421: node fails to build during update

bug#37421: node fails to build during update

[sirmacik]

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

Hi,

I'm trying to update ungoogled-chromium package but it fails on node
build and this happens repeatedly:

(guix pull done before)
$ guix package -u
substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
building /gnu/store/vk49dlkkixsik0fw9gsmnqn4jmgfw099-node-10.15.3.drv...
| 'check' phasebuilder for `/gnu/store/vk49dlkkixsik0fw9gsmnqn4jmgfw099-node-10.15.3.drv' failed with exit code 1
build of /gnu/store/vk49dlkkixsik0fw9gsmnqn4jmgfw099-node-10.15.3.drv failed
View build log at '/var/log/guix/drvs/vk/49dlkkixsik0fw9gsmnqn4jmgfw099-node-10.15.3.drv.bz2'.
cannot build derivation `/gnu/store/n6h5fv4isjjnqchpjfb5m7cv765s3vi0-ungoogled-chromium-76.0.3809.132-0.8eba5c0.drv': 1 dependencies couldn't be built
guix package: error: build of `/gnu/store/n6h5fv4isjjnqchpjfb5m7cv765s3vi0-ungoogled-chromium-76.0.3809.132-0.8eba5c0.drv' failed

I'm attaching log file from the build. 


[-- Attachment #2: Log file from failed node build --]
[-- Type: application/octet-stream, Size: 115686 bytes --]

[-- Attachment #3: Type: text/plain, Size: 62 bytes --]


--
Thank you for your time!
sirmacik
PGP: 0xE0DC81D523891771

bug#37421: [PATCH] gnu: node: Disable tests that fail with openssl@1.1.1d.

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

Work around <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37386>.

* gnu/packages/node.scm (node)[arguments]: Disable failing tests.
---

Jelle, Guix,

So here's the obvious non-solution, ignoring test failures being the lesser evil compared to 4 potential CVEs anywhere in a Web browser's closure.

It seems to ‘work’ in a short VM Chromium test.  As in, nothing broke.  Don't know how to test Node.  Thoughts?

Kind regards,

T G-R

 gnu/packages/node.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index fc43fcb04c..f467be7665 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -91,6 +91,11 @@
          (add-before 'configure 'patch-files
            (lambda* (#:key inputs #:allow-other-keys)
 
+             ;; FIXME: These tests fail with openssl@1.1.1d.
+             (for-each delete-file
+                       '("test/parallel/test-crypto-binary-default.js"
+                         "test/parallel/test-crypto-dh.js"))
+
              ;; Fix hardcoded /bin/sh references.
              (substitute* '("lib/child_process.js"
                             "lib/internal/v8_prof_polyfill.js"
-- 
2.23.0

bug#37421: [PATCH] gnu: node: Disable tests that fail with openssl@1.1.1d.

[Ludovic Courtès]

Hello,

Tobias Geerinckx-Rice via Bug reports for GNU Guix <bug-guix@gnu.org>
skribis:

> Work around <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37386>.
>
> * gnu/packages/node.scm (node)[arguments]: Disable failing tests.

[...]

> +             ;; FIXME: These tests fail with openssl@1.1.1d.
> +             (for-each delete-file
> +                       '("test/parallel/test-crypto-binary-default.js"
> +                         "test/parallel/test-crypto-dh.js"))

It may be the best short-term solution.

Could we take a look at what these failures are about to see how bad
that might be?

Thanks,
Ludo’.

bug#37421: [PATCH] gnu: node: Disable tests that fail with openssl@1.1.1d.

[Jelle Licht]

Ludovic Courtès <ludo@gnu.org> writes:

> Hello,
>
> Tobias Geerinckx-Rice via Bug reports for GNU Guix <bug-guix@gnu.org>
> skribis:
>
>> Work around <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37386>.
>>
>> * gnu/packages/node.scm (node)[arguments]: Disable failing tests.
>
> [...]
>
>> +             ;; FIXME: These tests fail with openssl@1.1.1d.
>> +             (for-each delete-file
>> +                       '("test/parallel/test-crypto-binary-default.js"
>> +                         "test/parallel/test-crypto-dh.js"))
>
> It may be the best short-term solution.
Agreed, if ungoogled-chromium works with this that would probably be the
best option.
>
> Could we take a look at what these failures are about to see how bad
> that might be?

Interestingly enough, https://github.com/nodejs/node/issues/3881 notes
issues with exactly these two tests. Perhaps there is a regressions in
our case?

bug#37421: [PATCH] gnu: node: Disable tests that fail with openssl@1.1.1d.

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]

Ludovic Courtès 写道：
> Could we take a look at what these failures are about to see how 
> bad
> that might be?

Jelle Licht 写道：
> Interestingly enough, https://github.com/nodejs/node/issues/3881 
> notes
> issues with exactly these two tests. Perhaps there is a 
> regressions in
> our case?

Thanks, and indeed!  That is _quite_ the coincidence…

Unfortunately, I don't see any mention of a time-out in my logs & 
the truncation of the backtrace

  at Object.<anonymous> (…/test/parallel/test-crypto-dh.js:124:8)
  at Module._compile (internal/modules/cjs/loader.js:701:30)
  at Object.Module._extensions..js 
  (internal/modules/cjs/loader.js:712:10)
  at Module.load (internal/modules/cjs/loader.js:600:32)
  at tryModuleLoad (internal/modules/cjs/loader.js:539:12)
  at Function.Module._load (internal/modules/cjs/loader.js:531:3)
  at Function.Module.runMain 
  (internal/modules/cjs/loader.js:754:12)
  at startup (internal/bootstrap/node.js:283:19)
  at bootstrapNodeJSCore (internal/bootstrap/node.js:622:3)
  ...

happens at run time: grepping the output of ‘--keep’ doesn't 
reveal a more complete one :-(

I don't know how to hack the tests to spit out more.  Someone who 
knows node/js more than I do needs to step in and save us.  Is 
that you, Jelle? :-)

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

bug#37421: [PATCH] gnu: node: Disable tests that fail with openssl@1.1.1d.

[Jelle Licht]

Tobias Geerinckx-Rice <me@tobias.gr> writes:

> Ludovic Courtès 写道：
>> Could we take a look at what these failures are about to see how 
>> bad
>> that might be?
>
> Jelle Licht 写道：
>> Interestingly enough, https://github.com/nodejs/node/issues/3881 
>> notes
>> issues with exactly these two tests. Perhaps there is a 
>> regressions in
>> our case?
>
> Thanks, and indeed!  That is _quite_ the coincidence…
>
> Unfortunately, I don't see any mention of a time-out in my logs & 
> the truncation of the backtrace
>
>   at Object.<anonymous> (…/test/parallel/test-crypto-dh.js:124:8)
>   at Module._compile (internal/modules/cjs/loader.js:701:30)
>   at Object.Module._extensions..js 
>   (internal/modules/cjs/loader.js:712:10)
>   at Module.load (internal/modules/cjs/loader.js:600:32)
>   at tryModuleLoad (internal/modules/cjs/loader.js:539:12)
>   at Function.Module._load (internal/modules/cjs/loader.js:531:3)
>   at Function.Module.runMain 
>   (internal/modules/cjs/loader.js:754:12)
>   at startup (internal/bootstrap/node.js:283:19)
>   at bootstrapNodeJSCore (internal/bootstrap/node.js:622:3)
>   ...
>
> happens at run time: grepping the output of ‘--keep’ doesn't 
> reveal a more complete one :-(
>
> I don't know how to hack the tests to spit out more.  Someone who 
> knows node/js more than I do needs to step in and save us.  Is 
> that you, Jelle? :-)

I believe in learning by doing, so I'll have a go at it somewhere early
next week :-).

For now, I think it makes sense to push this patch so we can have a
(hopefully) working and secure ungoogled-chromium.

>
> Kind regards,
>
> T G-R

bug#37421: Apply nodejs test workaround?

[Jack Hill]

Hi Guix,

I wanted to ping this issue. From the discussion in #37421, it seems like 
we are OK with disabling the problematic tests as a work-around for now.

Should we go ahead and apply the patch?

Best,
Jack

bug#37421: Apply nodejs test workaround?

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

Jack,

Jack Hill 写道：
> I wanted to ping this issue. From the discussion in #37421, it 
> seems
> like we are OK with disabling the problematic tests as a 
> work-around
> for now.

We are.  Done as aae65db560bd146ba47774cca46056d72be2a5d4 and 
closing.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]