[bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10.

[bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10.

[Guillaume Le Vaillant]

Some icons are not showing properly in the application because it wants
PyQt 5.12.* and Guix only has PyQt 5.11.3 so far. The current packaged version
of electron-cash (4.0.7) also has this problem, but it doesn't tell the user
why. Anyway, it doesn't prevent the application from working (sending and
receiving transactions, etc).

[bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10.

[Guillaume Le Vaillant]

* gnu/packages/finance.scm (electron-cash): Update to 4.0.10.
  [inputs]: Add python-dateutil.
  [documentation]: Keep line width below 80.
---
 gnu/packages/finance.scm | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 960e3adeb3..1f2d9ada04 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -76,6 +76,7 @@
   #:use-module (gnu packages sphinx)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages textutils)
+  #:use-module (gnu packages time)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages upnp)
   #:use-module (gnu packages version-control)
@@ -413,7 +414,7 @@ other machines/servers.  Electrum does not download the Bitcoin blockchain.")
   (package
     (inherit electrum)
     (name "electron-cash")
-    (version "4.0.7")
+    (version "4.0.10")
     (source
      (origin
        (method url-fetch)
@@ -424,20 +425,24 @@ other machines/servers.  Electrum does not download the Bitcoin blockchain.")
                            ".tar.gz"))
        (sha256
         (base32
-         "0xswmr68cm1c77lzisi3z812jzqczm9dfrshfhdq42zz5kaz4gnn"))
+         "1rcywlma6hk52ymisx536jvkdwa73rhn1jxhsbs4wbvajl90w9s8"))
        (modules '((guix build utils)))
        (snippet
         '(begin
            ;; Delete the bundled dependencies.
            (delete-file-recursively "packages")
            #t))))
+    (inputs
+     `(("python-dateutil" ,python-dateutil)
+       ,@(package-inputs electrum)))
     (home-page "https://electroncash.org/")
     (synopsis "Bitcoin Cash wallet")
     (description
-     "Electroncash is a lightweight Bitcoin Cash client, based on a client-server
-protocol.  It supports Simple Payment Verification (SPV) and deterministic key
-generation from a seed.  Your secret keys are encrypted and are never sent to
-other machines/servers.  Electroncash does not download the Bitcoin Cash blockchain.")
+     "Electroncash is a lightweight Bitcoin Cash client, based on
+a client-server protocol.  It supports Simple Payment Verification (SPV) and
+deterministic key generation from a seed.  Your secret keys are encrypted and
+are never sent to other machines/servers.  Electroncash does not download the
+Bitcoin Cash blockchain.")
     (license license:expat)))
 
 (define-public monero
-- 
2.23.0

[bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]

On Fri, Oct 25, 2019 at 11:35:55AM +0200, Guillaume Le Vaillant wrote:
> Some icons are not showing properly in the application because it wants
> PyQt 5.12.* and Guix only has PyQt 5.11.3 so far.

qt-5.12 and pyqt-5.12 are coming soon™ with the staging branch.

>                                                   The current packaged version
> of electron-cash (4.0.7) also has this problem, but it doesn't tell the user
> why. Anyway, it doesn't prevent the application from working (sending and
> receiving transactions, etc).
> 

If it already has the problem then I don't see it being a blocker. Are
you sure the new version doesn't want qt-5.13+? We haven't started with
that yet.


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10.

[Guillaume Le Vaillant]

Efraim Flashner skribis:

> If it already has the problem then I don't see it being a blocker. Are
> you sure the new version doesn't want qt-5.13+? We haven't started with
> that yet.

Yes, when the program starts it shows the following warning:

--8<---------------cut here---------------start------------->8---
Electron Cash on Linux requires PyQt5 5.12+.

You have version 5.11.3 installed.

Please upgrade otherwise you may experience font rendering issues
with emojis and other unicode characters used by Electron Cash.
--8<---------------cut here---------------end--------------->8---

[bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10.

[Ludovic Courtès]

Hello!

What’s the conclusion regarding this upgrade?  Should we apply it or
not?  :-)

  https://issues.guix.gnu.org/issue/37919

TIA,
Ludo’.

[bug#37919] [PATCH] gnu: electron-cash: Update to 4.0.10.

[Guillaume Le Vaillant]

Ludovic Courtès skribis:

> Hello!
>
> What’s the conclusion regarding this upgrade?  Should we apply it or
> not?  :-)
>
>   https://issues.guix.gnu.org/issue/37919
>
> TIA,
> Ludo’.

As there's been another release of electron-cash since, I think we could
close this issue, wait for the staging branch which has Qt 5.12 to be
merged, and make a new upgrade patch for electron-cash then.

bug#37919: [PATCH] gnu: electron-cash: Update to 4.0.10.

[Ludovic Courtès]

Hi Guillaume,

Guillaume Le Vaillant <glv@posteo.net> skribis:

> Ludovic Courtès skribis:
>
>> Hello!
>>
>> What’s the conclusion regarding this upgrade?  Should we apply it or
>> not?  :-)
>>
>>   https://issues.guix.gnu.org/issue/37919
>>
>> TIA,
>> Ludo’.
>
> As there's been another release of electron-cash since, I think we could
> close this issue, wait for the staging branch which has Qt 5.12 to be
> merged, and make a new upgrade patch for electron-cash then.

Sounds good, closing it!

I think we’ll all have to take care of ‘staging’, it needs more
attention.  :-)

Thanks,
Ludo’.