[bug#38326] [PATCH 2/2] gnu: Add emacs-telega.

[bug#38326] [PATCH 2/2] gnu: Add emacs-telega.

[Brett Gilio]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: [PATCH 2/2] gnu: Add emacs-telega. --]
[-- Type: text/x-patch, Size: 3524 bytes --]

From c632d01dd48f89dab2822d5a81d091ca68b43c62 Mon Sep 17 00:00:00 2001
From: Brett Gilio <brettg@posteo.net>
Date: Fri, 22 Nov 2019 12:54:44 -0600
Subject: [PATCH 2/2] gnu: Add emacs-telega.

* gnu/packages/emacs-xyz.scm (emacs-telega): New variable.
---
 gnu/packages/emacs-xyz.scm | 58 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 0caf12a423..7ff53ecf1e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -114,6 +114,7 @@
   #:use-module (gnu packages image)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages libevent)
+  #:use-module (gnu packages messaging)
   #:use-module (gnu packages music)
   #:use-module (gnu packages version-control)
   #:use-module (gnu packages imagemagick)
@@ -19943,3 +19944,60 @@ Google guidelines.")
       (description "Helm Fish Completion is a Helm interface for Emacs
 fish-completion.  It can be used in both Eshell and M-x shell.")
       (license license:gpl3+))))
+
+(define-public emacs-telega
+  (let ((commit "019e923f933370d75dbe0a8473a18eb66fe94c0e")
+	(revision "1")
+	(version "0.4.4"))
+    (package
+      (name "emacs-telega")
+      (version (git-version version revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/zevlg/telega.el.git")
+               (commit commit)))
+         (sha256
+          (base32
+           "058814agkq8mp9ajpj8sz51rm9nigs2xpsdij05wjkxhfq30kqva"))
+         (file-name (git-file-name name version))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:tests? #f
+         #:modules ((guix build gnu-build-system)
+                    ((guix build emacs-build-system) #:prefix emacs:)
+                    (guix build utils)
+                    (guix build emacs-utils))
+         #:imported-modules (,@%gnu-build-system-modules
+                             (guix build emacs-build-system)
+                             (guix build emacs-utils))
+         #:phases
+         (modify-phases %standard-phases
+           (add-after 'unpack 'unpack-patch
+             (lambda _
+               (substitute* "server/Makefile"
+                 (("CC=cc")
+                  "CC=gcc")
+                 (("INSTALL_PREFIX=\\$\\(HOME\\)/.telega")
+                  (string-append "INSTALL_PREFIX=" (assoc-ref %outputs "out") "/bin")))))
+           (delete 'configure)
+           
+           ;; Build emacs-side using `emacs-build-system'
+           (add-after 'compress-documentation 'emacs-add-source-to-load-path
+             (assoc-ref emacs:%standard-phases 'add-source-to-load-path))
+           (add-after 'emacs-set-emacs-load-path 'emacs-install
+             (assoc-ref emacs:%standard-phases 'install))
+           (add-after 'emacs-install 'emacs-build
+             (assoc-ref emacs:%standard-phases 'build))
+           (add-after 'emacs-install 'emacs-make-autoloads
+             (assoc-ref emacs:%standard-phases 'make-autoloads)))))
+      (propagated-inputs
+       `(("emacs-visual-fill-column" ,emacs-visual-fill-column)))
+      (native-inputs
+       `(("tdlib" ,tdlib)
+         ("emacs" ,emacs-minimal)))
+      (synopsis "GNU Emacs telegram client")
+      (description "Telega is full-featured, unofficial client for Telegram platform for GNU Emacs.")
+      (home-page "https://github.com/zevlg/telega.el")
+      (license license:gpl3+))))
-- 
2.24.0

[bug#38326] [PATCH 2/2] gnu: Add emacs-telega.

[Ludovic Courtès]

Hi Brett,

Brett Gilio <brettg@posteo.net> skribis:

>>From c632d01dd48f89dab2822d5a81d091ca68b43c62 Mon Sep 17 00:00:00 2001
> From: Brett Gilio <brettg@posteo.net>
> Date: Fri, 22 Nov 2019 12:54:44 -0600
> Subject: [PATCH 2/2] gnu: Add emacs-telega.
>
> * gnu/packages/emacs-xyz.scm (emacs-telega): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 58 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 58 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 0caf12a423..7ff53ecf1e 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -114,6 +114,7 @@
>    #:use-module (gnu packages image)
>    #:use-module (gnu packages linux)
>    #:use-module (gnu packages libevent)
> +  #:use-module (gnu packages messaging)
>    #:use-module (gnu packages music)

We have a problem (not your fault!): applying this hunk on top of
current master breaks it all, due to circular top-level references in
the modules.

I haven’t been able to spend much time investigating, but we first need
to find out where that comes from.

Ludo’.

[bug#38326] [PATCH 2/2] gnu: Add emacs-telega.

[Brett Gilio]

Ludovic Courtès <ludo@gnu.org> writes:

> Hi Brett,
>
> Brett Gilio <brettg@posteo.net> skribis:
>
>>>From c632d01dd48f89dab2822d5a81d091ca68b43c62 Mon Sep 17 00:00:00 2001
>> From: Brett Gilio <brettg@posteo.net>
>> Date: Fri, 22 Nov 2019 12:54:44 -0600
>> Subject: [PATCH 2/2] gnu: Add emacs-telega.
>>
>> * gnu/packages/emacs-xyz.scm (emacs-telega): New variable.
>> ---
>>  gnu/packages/emacs-xyz.scm | 58 ++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 58 insertions(+)
>>
>> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
>> index 0caf12a423..7ff53ecf1e 100644
>> --- a/gnu/packages/emacs-xyz.scm
>> +++ b/gnu/packages/emacs-xyz.scm
>> @@ -114,6 +114,7 @@
>>    #:use-module (gnu packages image)
>>    #:use-module (gnu packages linux)
>>    #:use-module (gnu packages libevent)
>> +  #:use-module (gnu packages messaging)
>>    #:use-module (gnu packages music)
>
> We have a problem (not your fault!): applying this hunk on top of
> current master breaks it all, due to circular top-level references in
> the modules.
>
> I haven’t been able to spend much time investigating, but we first need
> to find out where that comes from.
>
> Ludo’.

Ludo,

That is perfectly okay. I have some revisions I will be sharing to this
patch soon anyways.

Regarding the circular top-level references. That is interesting. I was
not familiar with this issue. Is there an open bug report for this? I'd
be willing to investigate it a bit.

It is particularly interesting, because emacs-xyz is not used in the
messaging module, so the circular reference logic is indeed obscured
somewhere.

Best!

-- 
Brett M. Gilio
https://git.sr.ht/~brettgilio/

bug#38326: [PATCH 2/2] gnu: Add emacs-telega.

[Ludovic Courtès]

Hi Brett,

I fixed the circularity issue in commit
abad22dd4a3083498263cc5d6817dd7c01df4da1, and finally pushed
‘emacs-telega’.

Thanks!

Ludo’.