From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:35826) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jP85T-0001vK-Ux for guix-patches@gnu.org; Thu, 16 Apr 2020 13:14:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jP85S-0000w9-OA for guix-patches@gnu.org; Thu, 16 Apr 2020 13:14:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55981) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jP85S-0000vu-Kd for guix-patches@gnu.org; Thu, 16 Apr 2020 13:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jP85S-0007fp-Fe for guix-patches@gnu.org; Thu, 16 Apr 2020 13:14:02 -0400 Subject: [bug#40556] [PATCH] gnu: dovecot: Add libunwind input. Resent-Message-ID: References: <87ftdahvut.fsf@gmx.com> <875ze6ngmg.fsf@nckx> <87eesuhsl2.fsf@gmx.com> <877dyfgzzb.fsf@gnu.org> From: Pierre Langlois Message-ID: <87y2qvs6ar.fsf@gmx.com> In-reply-to: <877dyfgzzb.fsf@gnu.org> Date: Thu, 16 Apr 2020 19:13:21 +0200 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Pierre Langlois , Tobias Geerinckx-Rice , 40556@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo! Ludovic Court=C3=A8s writes: > Hi, > > Pierre Langlois skribis: > >> + ;; FIXME: The 'test-backtrace' tests fail on arm when using glib= c's >> + ;; backtrace_symbol() function so fallback to using libunwind. >> + ,@(match (or (%current-target-system) (%current-system)) >> + ((or "aarch64-linux" "armhf-linux") >> + `(("libunwind" ,libunwind))) >> + (_ '())) > > This isn=E2=80=99t quite correct because =E2=80=98%current-target-system= =E2=80=99 returns a > triplet, like =E2=80=9Carm-linux-gnueabihf=E2=80=9D. Oups, I didn't realize the cross-compilation target was different. > > Use =E2=80=98target-arm?=E2=80=99 instead. Yep, that works really nicely, it's much clearer. I've tested on x86_64, arm and aarch64 natively. I'll try cross-compiling with --target=3Darm-linux-gnueabihf and --target=3Daarch64-linux-gnu as well but that'll take a little longer. Thanks! Pierre --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-dovecot-Add-libunwind-input-for-arm.patch Content-Transfer-Encoding: quoted-printable >From d56005a2d839e36cd9f718041d8634f34cf2177a Mon Sep 17 00:00:00 2001 From: Pierre Langlois Date: Sat, 11 Apr 2020 16:34:01 +0100 Subject: [PATCH] gnu: dovecot: Add libunwind input for arm. * gnu/packages/mail.scm (dovecot)[inputs]: Add libunwind when targetting ar= m. --- gnu/packages/mail.scm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm index 0a88c20a6e..8d55d157e5 100644 --- a/gnu/packages/mail.scm +++ b/gnu/packages/mail.scm @@ -24,7 +24,7 @@ ;;; Copyright =C2=A9 2017 Kyle Meyer ;;; Copyright =C2=A9 2017, 2018, 2019, 2020 Tobias Geerinckx-Rice ;;; Copyright =C2=A9 2017, 2018 Rene Saavedra -;;; Copyright =C2=A9 2018, 2019 Pierre Langlois +;;; Copyright =C2=A9 2018, 2019, 2020 Pierre Langlois ;;; Copyright =C2=A9 2018 Alex Vong ;;; Copyright =C2=A9 2018 G=C3=A1bor Boskovits ;;; Copyright =C2=A9 2018, 2019, 2020 Ricardo Wurmus @@ -89,6 +89,7 @@ #:use-module (gnu packages libevent) #:use-module (gnu packages libidn) #:use-module (gnu packages libunistring) + #:use-module (gnu packages libunwind) #:use-module (gnu packages linux) #:use-module (gnu packages lsof) #:use-module (gnu packages lua) @@ -1435,6 +1436,11 @@ facilities for checking incoming mail.") (inputs `(("bzip2" ,bzip2) ("libsodium" ,libsodium) ; extra password algorithms + ;; FIXME: The 'test-backtrace' tests fail on arm when using glibc's + ;; backtrace_symbol() function so fallback to using libunwind. + ,@(if (target-arm?) + `(("libunwind" ,libunwind)) + '()) ("linux-pam" ,linux-pam) ("lz4" ,lz4) ("openssl" ,openssl) --=20 2.26.1 --=-=-=--