all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Brett Gilio <brettg@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 43096@debbugs.gnu.org, Michael Rohleder <mike@rohleder.de>
Subject: [bug#43096] [PATCH] gnu: emacs-erc-status-sidebar: Update to 0.1-2.b589b742.
Date: Fri, 28 Aug 2020 20:58:08 -0500	[thread overview]
Message-ID: <87y2ly5i33.fsf@gnu.org> (raw)
In-Reply-To: <87ft86kynv.fsf@nckx> (Tobias Geerinckx-Rice's message of "Sat, 29 Aug 2020 03:51:00 +0200")

Tobias Geerinckx-Rice <me@tobias.gr> writes:

> Brett Gilio 写道:
>>> -      (license license:expat))))
>>> +      (license license:gpl3+))))
>>>   (define-public emacs-shut-up
>>>    (package
>>
>> I might be mistaken, but I think the license change belongs in a
>> separate patch.
>
> Not if the licence actually changed between versions.
>
> If it's correcting a previously incorrect licence in Guix, then indeed
> it does.
>
> Kind regards,
>
> T G-R

It's kind of a weird case where it is both? The LICENSE file has always
been GPL3, but the code header erroneously stated it as expat-style.

https://github.com/drewbarbs/erc-status-sidebar/commit/b589b74245591257c9e666bd5cd25812e04b7a34

I kind of lean on the side of a separate patch since the license never
really changed, but was an error both upstream and on our end as well.

Brett Gilio




  reply	other threads:[~2020-08-29  1:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-29  1:11 [bug#43096] [PATCH] gnu: emacs-erc-status-sidebar: Update to 0.1-2.b589b742 Michael Rohleder
2020-08-29  1:45 ` Brett Gilio
2020-08-29  1:51   ` Tobias Geerinckx-Rice via Guix-patches via
2020-08-29  1:58     ` Brett Gilio [this message]
2020-08-29  1:59       ` Brett Gilio
2020-08-30  1:29         ` Michael Rohleder
2020-12-18 13:18           ` bug#43096: " Ludovic Courtès
2020-08-30  9:22 ` [bug#43096] " Nicolas Goaziou
2020-09-01  3:48   ` Michael Rohleder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2ly5i33.fsf@gnu.org \
    --to=brettg@gnu.org \
    --cc=43096@debbugs.gnu.org \
    --cc=me@tobias.gr \
    --cc=mike@rohleder.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.