From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cMBpEC8STF9bIAAA0tVLHw (envelope-from ) for ; Sun, 30 Aug 2020 20:55:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uKVFDC8STF/hZAAAB5/wlQ (envelope-from ) for ; Sun, 30 Aug 2020 20:55:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9C145940309 for ; Sun, 30 Aug 2020 20:55:10 +0000 (UTC) Received: from localhost ([::1]:49484 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCUM1-0002dk-6z for larch@yhetil.org; Sun, 30 Aug 2020 16:55:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCULv-0002dc-3V for guix-patches@gnu.org; Sun, 30 Aug 2020 16:55:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39294) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kCULu-0005fn-FT for guix-patches@gnu.org; Sun, 30 Aug 2020 16:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kCULu-00078L-Dd for guix-patches@gnu.org; Sun, 30 Aug 2020 16:55:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42958] [PATCH core-updates 02/29] gnu: yelp-tools: Update package definition. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 30 Aug 2020 20:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42958 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic Cc: Raghav Gururajan , 42958@debbugs.gnu.org Received: via spool by 42958-submit@debbugs.gnu.org id=B42958.159882087327356 (code B ref 42958); Sun, 30 Aug 2020 20:55:02 +0000 Received: (at 42958) by debbugs.gnu.org; 30 Aug 2020 20:54:33 +0000 Received: from localhost ([127.0.0.1]:50840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCULR-00077A-CN for submit@debbugs.gnu.org; Sun, 30 Aug 2020 16:54:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCULQ-00076q-AZ for 42958@debbugs.gnu.org; Sun, 30 Aug 2020 16:54:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44999) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCULK-0005eW-FA; Sun, 30 Aug 2020 16:54:26 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=43790 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kCULJ-0008Vt-3e; Sun, 30 Aug 2020 16:54:26 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200820150914.9443-1-dannym@scratchpost.org> <20200820151050.9529-1-dannym@scratchpost.org> <20200820151050.9529-2-dannym@scratchpost.org> Date: Sun, 30 Aug 2020 22:54:22 +0200 In-Reply-To: <20200820151050.9529-2-dannym@scratchpost.org> (Danny Milosavljevic's message of "Thu, 20 Aug 2020 17:10:23 +0200") Message-ID: <87y2lvg8ht.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: hPwkNattFzvF Hi! Danny Milosavljevic skribis: > From: Raghav Gururajan > > * gnu/packages/gnome.scm (yelp-tools): Update package definition. > [propagated-inputs]: Move itstool, libxml2 and libxslt to ... > [native-inputs]: ... here. > [synopsis]: Modify. > [description]: Modify. > > Signed-off-by: Danny Milosavljevic I think =E2=80=9CUpdate package definition=E2=80=9D is not descriptive: it = should be either =E2=80=9CUpdate to 3.36=E2=80=9D (for a version update), or =E2=80= =9CMove build-time tool to 'native-inputs'=E2=80=9D, or =E2=80=9CTweak synopsis and description=E2= =80=9D. But then, these are different kinds of changes (I know, you=E2=80=99ll hate me for suggesting another rebase=E2=80=A6). I find it important to clearly commun= icate among us what a change does. WDYT? Also, while it=E2=80=99s maybe more convenient for Outreachy, I think many = of these changes could have gone one by one on =E2=80=98master=E2=80=99 over t= ime, like Raghav used to do. That avoids the pressure associated with a 29-patch review. > + (synopsis "Tools for Yelp") > + (description "Yelp-Tools contains small programs that help you creat= e, edit, > +manage, and publish your Mallard or DocBook documentation.") > (home-page "https://wiki.gnome.org/Apps/Yelp/Tools") > - (synopsis "Yelp documentation tools") > - (description > - "Yelp-tools is a collection of scripts and build utilities to help = create, > -manage, and publish documentation for Yelp and the web. Most of the hea= vy > -lifting is done by packages like yelp-xsl and itstool. This package just > -wraps things up in a developer-friendly way.") This particular change is questionable IMO. Anyhow, thanks to the two of you for all the work! Ludo=E2=80=99.