From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OADoDJSCaF/fQAAA0tVLHw (envelope-from ) for ; Mon, 21 Sep 2020 10:38:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id AIueCJSCaF9fWgAAB5/wlQ (envelope-from ) for ; Mon, 21 Sep 2020 10:38:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1FFDF94013C for ; Mon, 21 Sep 2020 10:38:11 +0000 (UTC) Received: from localhost ([::1]:39778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKJCz-0007XT-Mr for larch@yhetil.org; Mon, 21 Sep 2020 06:38:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKJCs-0007XI-5z for guix-patches@gnu.org; Mon, 21 Sep 2020 06:38:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41970) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kKJCr-0002gw-Sn for guix-patches@gnu.org; Mon, 21 Sep 2020 06:38:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kKJCr-0004gT-Pm for guix-patches@gnu.org; Mon, 21 Sep 2020 06:38:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42885] [PATCH 2/4] gnu: Add mathjax-bin (MathJax 3). Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 21 Sep 2020 10:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42885 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ricardo Wurmus Cc: 42885@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= , Brendan Tildesley , Leo Famulari Received: via spool by 42885-submit@debbugs.gnu.org id=B42885.160068464117955 (code B ref 42885); Mon, 21 Sep 2020 10:38:01 +0000 Received: (at 42885) by debbugs.gnu.org; 21 Sep 2020 10:37:21 +0000 Received: from localhost ([127.0.0.1]:53516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKJCD-0004fX-Jv for submit@debbugs.gnu.org; Mon, 21 Sep 2020 06:37:21 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:46432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKJCA-0004fM-1I for 42885@debbugs.gnu.org; Mon, 21 Sep 2020 06:37:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=kniI8trt9Y759ArhhvwYrLMKaJrjKE7fagWV701cvMU=; b=CRddGx6r+iyZtXKWgS05yQJPS svNG8fGivc0I7iTZT9Af45+KLcN1iM3k72d/tD1MkxThgPXXQJSYQDh7YFmHOOMnbf+mVOoZNYZYJ yfRK0h9MSwj7UoGEPop6wPlLqC741nm0B6fyKsnZxYDNneFyKTygeeF0OQ9SwBNTyBbWOauXfvLkG 4wYj7WvIv4ORFpP4s7XvhKqdwaoKms+LdwMygZW/NFh1om50mBlcr+OX0sg7h+BQEleQ9U6oQkezG 03eyu3HyeqENM17sLyNdUml5nEHR7pognaekra6QjElbnfBWaPu4jBJjtGXpEK4NPN0amjGDwqMOH Vi+VgqdFA==; Received: from [192.168.2.1] (helo=steel) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1kKJAV-0000Lz-6P; Mon, 21 Sep 2020 16:05:35 +0530 From: Arun Isaac In-Reply-To: <87a6xove66.fsf@elephly.net> References: <20200816070318.18642-1-mail@brendan.scot> <20200816070318.18642-2-mail@brendan.scot> <20200824010501.GB14757@jasmine.lan> <87h7sszn4j.fsf@systemreboot.net> <6F7B2CEB-1A83-4B01-B815-1529359169E1@brendan.scot> <87eenwzgoa.fsf@systemreboot.net> <87y2lpvrrd.fsf@gnu.org> <87zh65csve.fsf@systemreboot.net> <871rjhfhtt.fsf@elephly.net> <87y2lj1moa.fsf@systemreboot.net> <877dt3ct7u.fsf@elephly.net> <87sgbq20kw.fsf@systemreboot.net> <874knwbtgv.fsf@systemreboot.net> <87a6xove66.fsf@elephly.net> Date: Mon, 21 Sep 2020 16:06:35 +0530 Message-ID: <87y2l3zaa4.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=systemreboot.net header.s=default header.b=CRddGx6r; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: 5oJFOovVswkh I have pushed my commits to a new wip-swc branch. A few questions and discussion points below. Considering that only the source of rust dependencies is used, should those packages successfully build on their own? In the wip-swc branch, I have only verified that the rust-swc package builds. There may be some dependencies which fail to build on their own. Related to the previous question, what is the purpose of the #:skip-build? argument? Should it be set to #t for all dependency packages? While working on this patchset, I hacked the crate importer a bit to make my life easier. In particular, I modified it to correctly append the version to the package variable name. This requires a slightly more general recursive importer than we have currently. The current recursive importer assumes that we will package only one version for each package. That assumption does not stand for rust crates. We also don't always need to put the minor version into the package variable name. For example, rust-syn-1 is sufficient. rust-syn-1.0 is not required. The exact rules follow from https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html I improved the crate importer to better understand these version requirement rules and put packages of the correct version into the #:cargo-inputs and #:cargo-development-inputs fields. I will send patches for these crate importer improvements separately after this patchset is approved. We also need some automated way to "garbage collect" old versions of packages in crates-io.scm. crates-io.scm is getting quite large, and I suspect many packages in there are old versions that are not really necessary. > I expected as much, but I was hoping that we could invoke it some other > way, much like we invoke uglify-js (the Common Lisp package) with a > little custom wrapper. That is a good idea. But, I have never written any rust. Perhaps someone who is more familiar with rust should write it.