From: "Ludovic Courtès" <ludo@gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: 43746@debbugs.gnu.org
Subject: bug#43746: What to do about packages that don't support --without-tests / #:tests? #f setting
Date: Sat, 03 Oct 2020 12:04:37 +0200 [thread overview]
Message-ID: <87y2knfwwa.fsf@gnu.org> (raw)
In-Reply-To: <20201002224821.64mmk3fzk27c5pvi@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Sat, 3 Oct 2020 00:48:21 +0200")
Hi,
"pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> skribis:
> On Thu, Oct 01, 2020 at 11:07:54PM +0200, Ludovic Courtès wrote:
>> Oh, we should fix ‘glib’ in ‘core-updates’.
>
> I verified the attached patch fixes glib on the ‘master’ branch. I’m
> not sure about adding a copyright. Anyway. Shall I push it to
> ‘core-updates’ or wait until I can test it on ‘core-updates’ without
> rebuilding the world?
If you tested it on ‘master’, you can push it on ‘core-updates’.
> I changed it and pushed the patch to the documentation as
> 3c01fcc1bb9c086f487d9694cb91a57d7abd0880. Thank you!
Great!
> (I maybe should have written in the commit message “Fixes
> <https://bugs.gnu.org/43746>.” Oh well. I will leave the bug open
> though because glib is not fixed yet.)
That’s OK. :-)
> From 505cfd0fa3411a21c8794ab84473dc1dd2b8754c Mon Sep 17 00:00:00 2001
> From: Florian Pelz <pelzflorian@pelzflorian.de>
> Date: Sat, 3 Oct 2020 00:29:56 +0200
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> Subject: [PATCH] gnu: glib: Adhere to '--without-tests' option.
>
> * gnu/packages/glib.scm (glib)[arguments]<#:phases>[configure]:
> Only run tests if 'tests?' is true.
OK for ‘core-updates’, thank you!
Ludo’.
next prev parent reply other threads:[~2020-10-03 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 14:31 bug#43746: What to do about packages that don't support --without-tests / #:tests? #f setting pelzflorian (Florian Pelz)
2020-10-01 21:07 ` Ludovic Courtès
2020-10-02 22:48 ` pelzflorian (Florian Pelz)
2020-10-03 10:04 ` Ludovic Courtès [this message]
2020-10-03 11:03 ` pelzflorian (Florian Pelz)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2knfwwa.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=43746@debbugs.gnu.org \
--cc=pelzflorian@pelzflorian.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.