From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cJF/H7L+NGBXFwAA0tVLHw (envelope-from ) for ; Tue, 23 Feb 2021 13:10:10 +0000 Received: from aspmx2.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OP3SGrL+NGCnKAAAB5/wlQ (envelope-from ) for ; Tue, 23 Feb 2021 13:10:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id D4A15194AC for ; Tue, 23 Feb 2021 14:10:09 +0100 (CET) Received: from localhost ([::1]:37820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEXS4-0005lN-UE for larch@yhetil.org; Tue, 23 Feb 2021 08:10:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEXRy-0005lF-4T for guix-patches@gnu.org; Tue, 23 Feb 2021 08:10:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46987) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lEXRx-0000YW-Sl for guix-patches@gnu.org; Tue, 23 Feb 2021 08:10:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lEXRx-000347-OI for guix-patches@gnu.org; Tue, 23 Feb 2021 08:10:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46697] [PATCH] Added capstone 4. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 23 Feb 2021 13:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46697 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Gerd Heber Cc: 46697@debbugs.gnu.org, Gerd Heber Received: via spool by 46697-submit@debbugs.gnu.org id=B46697.161408576511731 (code B ref 46697); Tue, 23 Feb 2021 13:10:01 +0000 Received: (at 46697) by debbugs.gnu.org; 23 Feb 2021 13:09:25 +0000 Received: from localhost ([127.0.0.1]:58533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEXRN-000339-AP for submit@debbugs.gnu.org; Tue, 23 Feb 2021 08:09:25 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:46591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEXRL-00032t-GQ for 46697@debbugs.gnu.org; Tue, 23 Feb 2021 08:09:24 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 6532D1C000C; Tue, 23 Feb 2021 13:09:16 +0000 (UTC) From: Nicolas Goaziou References: <20210221223521.6116-1-gheber@hdfgroup.org> Date: Tue, 23 Feb 2021 14:09:15 +0100 In-Reply-To: <20210221223521.6116-1-gheber@hdfgroup.org> (Gerd Heber's message of "Sun, 21 Feb 2021 16:35:21 -0600") Message-ID: <87y2ffx75w.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.37 Authentication-Results: aspmx2.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx2.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: D4A15194AC X-Spam-Score: -2.37 X-Migadu-Scanner: scn1.migadu.com X-TUID: /hIycPXKwMQc Hello, Gerd Heber writes: > gnu/packages/engineering.scm | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) Thank you for your patch! Some comments follow. First, there is already a capstone package in Guix, at version 3.5. Is there a particular reason for not updating it instead of creating a new variable? > + (uri (string-append "https://github.com/aquynh/capstone" > + "/archive/" version ".tar.gz")) This URI is unstable. We prefer using tagged commits instead. See for example already defined capstone package. > + #:tests? #t)) This is the default, so it can be omitted. > + (home-page "https://www.capstone-engine.org") > + (synopsis "Lightweight multi-platform, multi-architecture disassembly framework") Nitpick: I would remove multi-platform, since it makes little sense from Guix POV. > + (description > + "Capstone is a lightweight multi-platform, multi-architecture disassembly Ditto. > +framework. Capstone can disassemble machine code for many supported You need to add two spaces after full stops. > +architectures such as x86, x86_64, arm, arm64, mips, ppc, sparc, sysz and > +xcore. It provides bindings for Python, Java, OCaml and more.") Also, could you provide a proper commit message, for example gnu: capstone: Update to 4.0.2. * gnu/packages/engineering.scm (capstone): Update to 4.0.2. Could you send an updated patch? Regards, -- Nicolas Goaziou