all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Rohleder <mike@rohleder.de>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 48198@debbugs.gnu.org
Subject: [bug#48198] [PATCH] gnu: vcsh: Update to 1.20190621.
Date: Mon, 03 May 2021 18:53:55 +0200	[thread overview]
Message-ID: <87y2cvvjvg.fsf@rohleder.de> (raw)
In-Reply-To: <87a6pb4vhc.fsf@nckx> (Tobias Geerinckx-Rice's message of "Mon, 03 May 2021 18:45:19 +0200")

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

Hey Tobias,

Thanks for reviewing!

Tobias Geerinckx-Rice <me@tobias.gr> writes:
>> [arguments]: Add phase install-bash-completion.
>
> Since this isn't new in this release, I think it should be a separate
> commit.  Do you agree?

No, I don't agree.
I think it is new (at least, compared to the version we had/I made
before)

>
>> +                        #t))))
>
> You can (finally!) omit this now.
>
> Ignore the lint warning, which is still there only because its removal
> needs to pass through core-updates.

Ah, ok.  I was wondering about the warning.

Thank you!

-- 
Der menschliche Geist waechst mit dem Raum in dem er sich bewegt.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]

  reply	other threads:[~2021-05-03 17:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03 15:54 [bug#48198] [PATCH] gnu: vcsh: Update to 1.20190621 Michael Rohleder
2021-05-03 16:45 ` Tobias Geerinckx-Rice via Guix-patches via
2021-05-03 16:53   ` Michael Rohleder [this message]
2021-05-03 20:44     ` bug#48198: " Tobias Geerinckx-Rice via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2cvvjvg.fsf@rohleder.de \
    --to=mike@rohleder.de \
    --cc=48198@debbugs.gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.