From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MFqhGqMnkmCxFQEAgWs5BA (envelope-from ) for ; Wed, 05 May 2021 07:05:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iIc5FqMnkmCqGQAAbx9fmQ (envelope-from ) for ; Wed, 05 May 2021 05:05:39 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 33C6620618 for ; Wed, 5 May 2021 07:05:38 +0200 (CEST) Received: from localhost ([::1]:58560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1le9j7-000543-CJ for larch@yhetil.org; Wed, 05 May 2021 01:05:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1le9iY-00053q-Lo for guix-patches@gnu.org; Wed, 05 May 2021 01:05:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46066) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1le9iY-0002X9-D4 for guix-patches@gnu.org; Wed, 05 May 2021 01:05:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1le9iY-0000vu-8h for guix-patches@gnu.org; Wed, 05 May 2021 01:05:02 -0400 Subject: bug#48230: [PATCH] tests: go: Rename and fix duplicate test. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Wed, 05 May 2021 05:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 48230 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: francois.joulaud@radiofrance.com, 48230-done@debbugs.gnu.org Mail-Followup-To: 48230@debbugs.gnu.org, maxim.cournoyer@gmail.com, me@tobias.gr Received: via spool by 48230-done@debbugs.gnu.org id=D48230.16201910463539 (code D ref 48230); Wed, 05 May 2021 05:05:02 +0000 Received: (at 48230-done) by debbugs.gnu.org; 5 May 2021 05:04:06 +0000 Received: from localhost ([127.0.0.1]:57607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1le9hd-0000v1-PA for submit@debbugs.gnu.org; Wed, 05 May 2021 01:04:05 -0400 Received: from mail-qt1-f181.google.com ([209.85.160.181]:44949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1le9hZ-0000ua-CA for 48230-done@debbugs.gnu.org; Wed, 05 May 2021 01:04:03 -0400 Received: by mail-qt1-f181.google.com with SMTP id y12so305625qtx.11 for <48230-done@debbugs.gnu.org>; Tue, 04 May 2021 22:04:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=QlmbDZwsqK5f46uyl7lgSMMil8ZWe6acfTocMyu3mYI=; b=JFYwkXzzYL3e1aimyl9KhYzgfoFX3e8qhpGUGVehUcLhuzvEFXnY+xjXt/u0zMVYUo hl4d7swPcuU4uZ1LkTURF1AqRc8CobJvPDUk5+2kVx52aMgwRnNiPirWI8QBcVw5SHep foHkLJUVaXY0kS4ZepJdKrKEICk/VIE6NnliECC53WTsAsDTt1gBUtbh1tj6nnp2Cp8u ZIVkVv2EJ+xJ9sluGn3fJc8L3TjYz0YN0DGUCVybEhVg6oDA3xRu85KxO+4d8+aiErp+ /cT4Uxv6DlygWSeXywqpLaElAAKKNUBsDdOmRyTh72DcJHI0mZ0C8+7KC0byHRQIS7aq zWlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=QlmbDZwsqK5f46uyl7lgSMMil8ZWe6acfTocMyu3mYI=; b=BXdEGkBTtRYoPefAmYBosVp/BrR3pciLhuy7kdvNlxx3px8USo7eVhkycVh73+jaOo W5IFA09211EM0TkRnFioCdIsmX2Wleij2Zlc9WQIcB7X+JXq7r9ZKUxjz47MAzCkuEOD EKOaN2ZsHEXSwakdwlTgrcXE9qx57sgQldXj74elGKLHy9R2uq8cXrJpCnBEo9xpE/D3 ZoVqMUKLwCbyciUn5jkIyZ0xKNXwZZ16vJjuDMx9sg+ZzRPT3Hxu7aTPun1I7itBSAuU fAw1/N3yXZtCjnH+zYlEDGtFUQ3ZoGS6+sAqQ0Z8Pgovn4gZ3j1qPnQkDd6KmdHtu/MU gEyg== X-Gm-Message-State: AOAM53286UlnUUpDJc82NlvtziqoWO3toA7i5imWwLEl153XMcrYAZrD P0DNsQavN8e61lzQyDdscF4= X-Google-Smtp-Source: ABdhPJxkJh4wFJ9+HBuQvmRud5SIWD4VDMdkFswwClu084BrVngVBPJTNB1YNjbEG83yUJg6kT22ig== X-Received: by 2002:aed:316b:: with SMTP id 98mr25689041qtg.48.1620191035931; Tue, 04 May 2021 22:03:55 -0700 (PDT) Received: from hurd (mtl.savoirfairelinux.net. [208.88.110.46]) by smtp.gmail.com with ESMTPSA id h4sm4016824qtm.88.2021.05.04.22.03.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 May 2021 22:03:55 -0700 (PDT) From: Maxim Cournoyer References: <20210504205548.4232-1-me@tobias.gr> Date: Wed, 05 May 2021 01:03:54 -0400 In-Reply-To: <20210504205548.4232-1-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Tue, 4 May 2021 22:55:48 +0200") Message-ID: <87y2ctkc05.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620191139; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=QlmbDZwsqK5f46uyl7lgSMMil8ZWe6acfTocMyu3mYI=; b=QwbuLxFai4jHiNzuzLkRORcVLv588g8XNB008ukWYi1OTi5xlY6gRcNkb9tXVIjhBj6N4o +nIamZ6bdrKFojcT+4uh234qhrQ2AaVqL+2UHnYmZ2JWpbxxulK6DXiR7zjaZQoGNK1j6e lZ3qiwpwqqPBKQWQQYllBzovFBLoJBivB0cJp1JK4iwX/hn7WTOF+YxM7jCjxYoVrZTyol LXRidjWmB54OSCVkdL0NFKX0qBFWEh09iIZxfvTIq4JHMjtI9+6k1fuN5BUMG00f5fIj2+ YOCBl8W4d+EhlGW/7SMZbcnDzyIurm2QuwK1+lcxePr9cOJVrfiRGcgINSwlaA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620191139; a=rsa-sha256; cv=none; b=QT/9RrWh1aK2XMgF4uWygLElQRNby/vicvh5jEu1pN44bJoAswwvlG3JbMaujYTWYvLJDO oACPLOMFBk+rJd1jQVIRSennD/mR0nk/y4TIEm8jesObghG9rVgwTrrCksTuEIwgvwexyy FLFKXBX3x1hEbZBxqu6qma1uUx7zMaTcgKcHOmNHThykPadYLcy6q0raXxj350EQQkxyqB sqhZAufFw2MbfrQBNBqYeCYXr240WIFGhFazZIRk6rrTGMcI3ButQF2KLitf/EvAF8QBPU QEN0sjb5V7DopNWEFF0M755kxNM51d1DZi0VKRAVCuTpUzopQhUTXwhjQFpjKg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=JFYwkXzz; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.36 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=JFYwkXzz; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 33C6620618 X-Spam-Score: -1.36 X-Migadu-Scanner: scn0.migadu.com X-TUID: OMX2CPTvtVdZ Hi Tobias! Tobias Geerinckx-Rice writes: > * tests/go.scm: Rename "go-version omited 'v' character" to > "go-version without 'v' prefix" and change the code to match. > --- > > Hi all, > > Found on a typo hunt. Eh, thank you! > This is my best-effort guess at what was intended. Maybe I'm > mistaken: is GO-VERSION->GIT-REF supposed to normalise "1.0.2" to > "v1.0.2" instead? Let me know! I wasn't sure anymore, so I looked at the code; go-version->git-ref is a no-op (leaves the version string intact) unless it matches %go-pseudo-version-rx. > tests/go.scm | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/tests/go.scm b/tests/go.scm > index c33a834f69..565a0d451d 100644 > --- a/tests/go.scm > +++ b/tests/go.scm > @@ -1,5 +1,6 @@ > ;;; GNU Guix --- Functional package management for GNU > ;;; Copyright 2021 Franois Joulaud > +;;; Copyright 2021 Tobias Geerinckx-Rice > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -158,9 +159,9 @@ require github.com/kr/pretty v0.2.1 > "v1.0.2" > (go-version->git-ref "v1.0.2")) > > -(test-equal "go-version omited 'v' character" > - "v1.0.2" > - (go-version->git-ref "v1.0.2")) > +(test-equal "go-version without 'v' prefix" > + "1.0.2" > + (go-version->git-ref "1.0.2")) That test doesn't have much value based on my above analysis. I suggest we drop it; it's testing the same thing as the "v1.0.2" case. I've removed it and pushed with commit 2354d79b88. Thank you! Maxim