From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: Rovanion Luckey <rovanion.luckey@gmail.com>
Cc: 48717@debbugs.gnu.org
Subject: [bug#48717] [PATCH] Add lingot
Date: Fri, 28 May 2021 19:12:07 +0200 [thread overview]
Message-ID: <87y2byixzs.fsf@nckx> (raw)
In-Reply-To: <CAAaf0CDHT4CJuDRcnkXYrVkiY2h-26=V=CF+sGYyr1zMKK4E8Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]
Rovanion Luckey 写道:
> Added a tuner program to the package collection.
Thank you!
I should add a copyright line for you at the top of the file, once
you confirm which name & e-mail address to use.
I made the following changes (pay close attention, they might be
on the test):
- moved glib:bin to native-inputs, which means it can be run at
build time even when cross-building (and ‘guix gc --references’
indicates it won't be run at run time anyway),
- the licence is ‘GPL2 or later’,
- removed the leading ‘An’ from the synopsis (in a list, it's just
noise),
- wrapped all text to 80 characters and added a double space after
full stops.
Be sure to run ‘guix lint’ on new packages, it will warn you about
some of these and other cool mistakes.
These minor nitpicks will not be on the test but I applied them
anyway:
- reindented the package (specifically the source form was off?),
- ordered the inputs alphabetically, and put the package somewhere
similar,
- removed the libasound comment because that's 99% of why packages
use alsa-lib. Probably 100. Could the same be said for
glib:bin, which I kept? Perhaps! I am whimsy.
Kind regards,
T G-R
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
next prev parent reply other threads:[~2021-05-28 17:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 15:21 [bug#48717] [PATCH] Add lingot Rovanion Luckey
2021-05-28 17:12 ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2021-05-28 19:18 ` Rovanion Luckey
2021-07-30 19:03 ` Rovanion Luckey
2021-08-02 15:40 ` bug#48717: " Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2byixzs.fsf@nckx \
--to=guix-patches@gnu.org \
--cc=48717@debbugs.gnu.org \
--cc=me@tobias.gr \
--cc=rovanion.luckey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.