From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6IOLCEI2+GCa2gAAgWs5BA (envelope-from ) for ; Wed, 21 Jul 2021 16:59:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id EJ9RBEI2+GALUAAAB5/wlQ (envelope-from ) for ; Wed, 21 Jul 2021 14:59:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5F5B6114C for ; Wed, 21 Jul 2021 16:59:13 +0200 (CEST) Received: from localhost ([::1]:40326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6Dgm-0008Up-Ht for larch@yhetil.org; Wed, 21 Jul 2021 10:59:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53868) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6Dgc-0008OC-FU for guix-patches@gnu.org; Wed, 21 Jul 2021 10:59:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54959) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6Dgc-00028t-8H for guix-patches@gnu.org; Wed, 21 Jul 2021 10:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6Dgc-0005c2-8k for guix-patches@gnu.org; Wed, 21 Jul 2021 10:59:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49421] [PATCH] profiles: Optimise 'fonts-dir-file'. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 21 Jul 2021 14:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49421 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 49421@debbugs.gnu.org Received: via spool by 49421-submit@debbugs.gnu.org id=B49421.162687953121526 (code B ref 49421); Wed, 21 Jul 2021 14:59:02 +0000 Received: (at 49421) by debbugs.gnu.org; 21 Jul 2021 14:58:51 +0000 Received: from localhost ([127.0.0.1]:38270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6DgR-0005b7-AY for submit@debbugs.gnu.org; Wed, 21 Jul 2021 10:58:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6DgP-0005av-LU for 49421@debbugs.gnu.org; Wed, 21 Jul 2021 10:58:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50760) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6DgK-0001yE-Cr; Wed, 21 Jul 2021 10:58:44 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45272 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6DgJ-0006Hk-Uf; Wed, 21 Jul 2021 10:58:44 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87a6myoyl5.fsf@gnu.org> <5ec75ed429133cbc73dc7916959302033fe70a13.camel@telenet.be> <369206a276e225478ed1bbce0b883255dccef369.camel@telenet.be> Date: Wed, 21 Jul 2021 16:58:42 +0200 In-Reply-To: <369206a276e225478ed1bbce0b883255dccef369.camel@telenet.be> (Maxime Devos's message of "Thu, 15 Jul 2021 20:48:09 +0200") Message-ID: <87y29zg1ct.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626879553; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=ClwatzZKEdVaa1TCL86w0ozY28xqcN7ocRnPknQnIbo=; b=WvbUOHD1ixXXg+oRxTzlhcUIIR+3rhWdqGi7UJHIUFDduQE5BgAMO2ueBAnQsF6TBq769X x7q1LX6KdoUJHH2NK/gV8wZVvSrMmX7LKY5ME18ePm2hG1XDNcLIJR64zrHlb2TYK+R8az 2hKB5m1Lmyi4kKooNmdPb+O1/ZCEIWQxx+7ZDWRfqOXpRpk7KMxLedE7W7p1oefruP2k93 ZVVsHCN2BVGyx/XqHp/tc/FeTktFCB5KP/V8vDQmHH9O+JE+DH7c/0fUDU6Ry/8jFy7zKK B5A/ZexZH2iP7+6axPAD6MK6p0OSWXg+ezFxWtCUUzrik3YaxHq2ueTDAd8Ulg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626879553; a=rsa-sha256; cv=none; b=Be8WDxzeKthQe5GJroBy5vjgO5sPqQs5QCo75nfvXh1qxbNDDYhEu2FaDdWAGTsCsXEeqD k1cGvZVsSGEoKjeYAXyIlJO6aoVoaErjswyBMDyyOM0qb75NqkfB7ZggRQbpxtiA2hr0lO NfgwQwHSFNHFPCWlr7PNH52MWBFGQsJHLqF5SQ9JwbwME7QuUkbmFjAOWme7zKzvxpLAGO 7bRE4ab8i+OkkGKUNbQtwrec6GhAGnj83GZf5QGkwbcDK1olnm/8/XNeo8Akpo8PEKU9Yv HTxdJGtpvVSD3Csm2Ea305lzYL+81QV8ja6fJZb18z+pghvO3Dn3AODbTtEahQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.41 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5F5B6114C X-Spam-Score: -1.41 X-Migadu-Scanner: scn1.migadu.com X-TUID: rigLINYpnX6S Hi, Maxime Devos skribis: > I think it's better to optimise 'union-build' and the store deduplication > code though (maybe subdirectories can be process concurrently, to maximis= e I/O > utilisation?). That should improve performance outside the 'fonts-dir-fil= e' hook > as well. I=E2=80=99m afraid there=E2=80=99s little room for improvement on =E2=80=98= union-build=E2=80=99 (Mark put quite some effort on it back in commit 12129998689648923b58c426362a1bc875da75f9), though with a fresh eye perhaps you=E2=80=99ll find optimization opportunities. As for deduplication, there are two cases: deduplication for substitutes, and deduplication upon build completion (what we see here). In the former case, deduplication is part of the substitute unpacking pipeline (see ) and I think syscalls are reduced to the minimum necessary (that=E2=80=99s (= guix store deduplication)). The strace snippet you sent suggests that, in the latter case, the daemon=E2=80=99s code stats the same file several times, so maybe there=E2= =80=99s room for improvement here. Thanks, Ludo=E2=80=99.