From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AC03ADPxL2EQcQEAgWs5BA (envelope-from ) for ; Wed, 01 Sep 2021 23:31:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wL9wNzLxL2HwKgAAB5/wlQ (envelope-from ) for ; Wed, 01 Sep 2021 21:31:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B949B1ACD5 for ; Wed, 1 Sep 2021 23:31:30 +0200 (CEST) Received: from localhost ([::1]:38632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLXpR-0005Dv-Qw for larch@yhetil.org; Wed, 01 Sep 2021 17:31:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLXo3-0004Bd-Fp for guix-patches@gnu.org; Wed, 01 Sep 2021 17:30:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55804) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mLXo2-0000Fw-Ud for guix-patches@gnu.org; Wed, 01 Sep 2021 17:30:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mLXo2-0003UC-Qk for guix-patches@gnu.org; Wed, 01 Sep 2021 17:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49533] [PATCH] gnu: Add omins-lv2. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 01 Sep 2021 21:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49533 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Thorsten Wilms Cc: Ricardo Wurmus , 49533@debbugs.gnu.org, Sarah Morgensen Received: via spool by 49533-submit@debbugs.gnu.org id=B49533.163053177013321 (code B ref 49533); Wed, 01 Sep 2021 21:30:02 +0000 Received: (at 49533) by debbugs.gnu.org; 1 Sep 2021 21:29:30 +0000 Received: from localhost ([127.0.0.1]:39116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLXnW-0003Sl-DY for submit@debbugs.gnu.org; Wed, 01 Sep 2021 17:29:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLXnU-0003SL-Hl for 49533@debbugs.gnu.org; Wed, 01 Sep 2021 17:29:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38704) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLXnN-0008Dg-MW; Wed, 01 Sep 2021 17:29:21 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=48828 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLXnM-0007KY-M6; Wed, 01 Sep 2021 17:29:21 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <86fsw7rnln.fsf@mgsn.dev> <20210724194117.8372-1-t_w_@freenet.de> <874kcc28xz.fsf_-_@gnu.org> Date: Wed, 01 Sep 2021 23:29:18 +0200 In-Reply-To: <874kcc28xz.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Thu, 29 Jul 2021 21:53:28 +0200") Message-ID: <87y28g56j5.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630531890; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=y3QHHaJNGXeDLI4p2hzpV17yo+0xJbQ/8t54J22Tgko=; b=Lsnqg3+piMZ1zMPMwlRVS5gNDXIbWCgjIrDod61JONdLWkAgraVf1k97OULbAVXwiTAb4I 0OaL18CblIkaVJ5IT5YzaNrf7nzEOrLZp7RqvfXG42Pc8LvZlbMoTLrJsty4bKtVXKI7OK jyodiDu1slUPpMaps0rD5NoDNRIOu/RYMnkNe+T4DahXTIY9PoruWe+77q703dsNuks2R0 txgQnn9uy9JXDJD0gyz/3eiNDPETvYsomD8www/FWpPkVwnK4zmKr3v5diJb6Jv7jpc+dK iW+6lN7UMqhSmyF/j3bqS2tPnbQMkj1IrqBijuiV+U9MVTxOujjKMdaVgOVG6A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630531890; a=rsa-sha256; cv=none; b=fbSLp+n2I467xqP+Rb5/5CL9dYaBPKDDAphcGxpeJBMCMEdhERUKG8JQuzOwPK212EelZD 2dJ1ez5yhm5on16qZ4h9cbxbw/wS6+PZMUQ8R0vbezPVkjnzmEFxcoNqyP9VZH7UKDoJLx j6uegK0uoLYoAaP5tTrnW3FhBYDrV0qciHV7qLCDx6mPwy7nnT8XIcylsoAmQJ0j2EHkpo zhN8lLpRrKUq082BXJFV2D4QNDSA4d8jXIIjkdIAJlQdMOcPrzp9U3X2mF+9NWJI91pH05 0O+2VBemsJAReyvjrbX94BUpPvUz4R32XZdWnpVk8scXWFZsYFPnQY06gS4giw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.42 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B949B1ACD5 X-Spam-Score: -1.42 X-Migadu-Scanner: scn1.migadu.com X-TUID: QsTMAsXOH17k Hi Thorsten, Did you have a chance to look into this? Thanks, Ludo=E2=80=99. Ludovic Court=C3=A8s skribis: > Hi Thorsten, > > Thorsten Wilms skribis: > >> * gnu/packages/audio.scm (omins-lv2): New variable. > > It LGTM, modulo minor issues: > >> +(define-public omins-lv2 >> + (package >> + (name "omins-lv2") > > Please consider passing it through ./etc/indent-code.el: > > https://guix.gnu.org/manual/en/html_node/Formatting-Code.html > >> + ;; No release despite being perfectly usable. 0.0.0 seems to be the = only >> + ;; version the author ever specified: >> + (version "0.0.0") >> + (source >> + (origin >> + (method git-fetch) >> + (uri >> + (git-reference >> + (url "https://git.drobilla.net/cgit.cgi/omins.lv2.git/") >> + (commit "058f341053067b69a84d4081107fda5058290ff9"))) > > Please check out > on how > to compute version numbers in such cases. > >> + (native-search-paths >> + (list (search-path-specification >> + (variable "LV2_PATH") >> + (files '("lib/lv2"))))) > > I=E2=80=99m surprised this is here (in the plugin) rather than in the pac= kage > that loads this plugin. There are other LV2 plugins doing that though. > Ricardo, WDYT? > >> + (license (list license:gpl2+ license:gpl2+)))) > > (license license:gpl2+) should be enough. :-) > > Could you send an updated patch? > > Thank you, and thanks, Sarah! > > Ludo=E2=80=99.