From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mE0EJUZujmH7bQEAgWs5BA (envelope-from ) for ; Fri, 12 Nov 2021 14:38:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id QKK2IEZujmHZLgAA1q6Kng (envelope-from ) for ; Fri, 12 Nov 2021 13:38:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5B3FE3451E for ; Fri, 12 Nov 2021 14:38:14 +0100 (CET) Received: from localhost ([::1]:54318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlWku-0000PV-Qv for larch@yhetil.org; Fri, 12 Nov 2021 08:38:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlWkk-0008T5-DN for guix-patches@gnu.org; Fri, 12 Nov 2021 08:38:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60418) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mlWkk-0002Ca-4f for guix-patches@gnu.org; Fri, 12 Nov 2021 08:38:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mlWkk-00009K-33 for guix-patches@gnu.org; Fri, 12 Nov 2021 08:38:02 -0500 Subject: bug#51598: [PATCH 2/2] image: Support generating GPT images via `partition-table-type` Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 12 Nov 2021 13:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 51598 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ryan Sundberg Cc: 51598-done@debbugs.gnu.org Mail-Followup-To: 51598@debbugs.gnu.org, othacehe@gnu.org, ryan@arctype.co Received: via spool by 51598-done@debbugs.gnu.org id=D51598.1636724246519 (code D ref 51598); Fri, 12 Nov 2021 13:38:01 +0000 Received: (at 51598-done) by debbugs.gnu.org; 12 Nov 2021 13:37:26 +0000 Received: from localhost ([127.0.0.1]:43730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlWkA-00008I-5p for submit@debbugs.gnu.org; Fri, 12 Nov 2021 08:37:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlWk6-000083-Rh for 51598-done@debbugs.gnu.org; Fri, 12 Nov 2021 08:37:24 -0500 Received: from [2001:470:142:3::e] (port=40276 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlWk1-00028W-JW; Fri, 12 Nov 2021 08:37:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=dfvvlG8LGEC/Cill4CDiuLM1xfgWtnuWegeezU+j4uw=; b=SDMc4XJfSZKr0cv6SGV1 YfT6veLfTDTxzGShTdyhEJpSzCK1pISjd1uiaWnOR7FY+M4UisflSvc2fIphbh2HP/w5L4zUV2Qxg llaWDQJI0SUgDlVcQzRrhW7FvBPPl9KeYevQXjly67levzb1kH5TzMlUQsCP2UV3Va+9VsOPDcb56 Z6jhZEC98XwBYf7YmIFGjQFOnztkHCuHuJ6ZdfCj8jc8Vo4Q5Y/7CLvvbj4repc/2Vnm4mYSGdiMo yVD4xAB9PQ4/OFduFS4luMyCmbuAuJYCW8xsRYdJylsZK6BSG1To2c9D+T5jniDwpA1DepcS3CS4S NDLYKeKS4aO0HA==; Received: from [2a01:e0a:19b:d9a0:b4a5:c7aa:fee0:cc15] (port=60372 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlWk0-0005Gk-Jt; Fri, 12 Nov 2021 08:37:17 -0500 From: Mathieu Othacehe References: <20211104083511.11852-1-ryan@arctype.co> <20211104083511.11852-2-ryan@arctype.co> Date: Fri, 12 Nov 2021 13:37:15 +0000 In-Reply-To: <20211104083511.11852-2-ryan@arctype.co> (Ryan Sundberg's message of "Thu, 4 Nov 2021 01:35:11 -0700") Message-ID: <87y25tcx6c.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636724294; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=dfvvlG8LGEC/Cill4CDiuLM1xfgWtnuWegeezU+j4uw=; b=FPQ3gZKUnFO5PLS+65Wgw356r6ysOlxpimNH+IIWXZwXmUALA274V9iPOkR40zd6E/zHAu k5S/oecNQzvEWG78ZcrAu6B8l+rK5hel/TM1l82ILnPJAiPVsQaGJSGsDgdSETW2QEsp2u D62o7enk9SS/dnmmDrY4uFh2bQa1+V4ucu2CK925oxygGpYJeBLkKheo6HLGewp5LipSam hK6PQQMaDsrEVEbnwx55ATshnUOjYzUMW2sjUPgUMhMPoLQFqkn/wzterzmGt1xoZ5Lfkp na8L9tpNcmvZGEQiGh3WZdMax7iDVF+VU7DRZg5wbnHR4hiJhbtFs073ZCRgaA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636724294; a=rsa-sha256; cv=none; b=JE7AnSVNfp0fy9+L/+Fk4hqfG0ACnyXSdQgfjdIdJLHKLHJdtizI/afdAYOFLeMxROHWbY aZPiyoAfuuywlb45fjGbh03tKQsN7q3ypprHzY6mruK/eahxtwTzpJIMVa/lDUN4KjUOB3 4JGvEFv3+1bY7tLBvLevqi3ixmK0uu+EL3NKPdDz4sIeiT01zn/FDq0D2fJYbEI+NaUhrJ xzEUivk7g5fTew4403NKR9X/nYFjtIlSfqoGrpDoqJNrB6BpycCZuMh7jn6IRelYGGH3Nu 4CE+uZaqczJm+lmj/r6UwHE+kolfyMiaivMbfMpPlE8lAkYdHoUpHLKZHRMQbg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=SDMc4XJf; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.03 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=SDMc4XJf; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5B3FE3451E X-Spam-Score: -2.03 X-Migadu-Scanner: scn0.migadu.com X-TUID: Rixc7+lbLTIx Hello Ryan Nice one! I tried to generate a GPT image like so: --8<---------------cut here---------------start------------->8--- $ cat /tmp/my-img.scm (use-modules (gnu) (gnu image) (gnu system image)) (define my-os (primitive-load "/home/mathieu/guix/gnu/system/examples/lightweight-desktop.tmpl")) (image (inherit (os->image my-os #:type efi-raw-image-type)) (name 'raw-gpt) (partition-table-type 'gpt)) $ ./pre-inst-env guix system image /tmp/img.scm --8<---------------cut here---------------end--------------->8--- However, the resulting image was not bootable because Grub was lacking the part_gpt module. This is now fixed with fb3df2011692b2a6fea9f4fefd71dd788453fbae. I also noticed that trying to build a GPT image with a grub-bootloader (bare-bones.tmpl image for instance), failed at build time, probably because install-grub-disk-image is expecting an msdos partition. It would be great if you could have a look to this issue as a follow-up :). I pushed this patch anyway as 096a2bf8c59a955c634cc838e7f7111941c07b37. Thanks, Mathieu