From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EBubJQ3PzmFXRgEAgWs5BA (envelope-from ) for ; Fri, 31 Dec 2021 10:36:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id AKP4Ig3PzmGMAgAA9RJhRA (envelope-from ) for ; Fri, 31 Dec 2021 10:36:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BF4DF2EF3A for ; Fri, 31 Dec 2021 10:36:12 +0100 (CET) Received: from localhost ([::1]:50316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n3EKa-0002xo-16 for larch@yhetil.org; Fri, 31 Dec 2021 04:36:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39918) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3EKQ-0002xf-7I for bug-guix@gnu.org; Fri, 31 Dec 2021 04:36:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43553) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n3EKP-0002VK-T6 for bug-guix@gnu.org; Fri, 31 Dec 2021 04:36:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n3EKP-0005Cl-Pu for bug-guix@gnu.org; Fri, 31 Dec 2021 04:36:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#52913: 0ad only builds fine with a specific version of mozjs Resent-From: Guillaume Le Vaillant Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 31 Dec 2021 09:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52913 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 52913@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.164094331419922 (code B ref -1); Fri, 31 Dec 2021 09:36:01 +0000 Received: (at submit) by debbugs.gnu.org; 31 Dec 2021 09:35:14 +0000 Received: from localhost ([127.0.0.1]:55099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3EJe-0005BG-2P for submit@debbugs.gnu.org; Fri, 31 Dec 2021 04:35:14 -0500 Received: from lists.gnu.org ([209.51.188.17]:51958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3EJc-0005B6-9a for submit@debbugs.gnu.org; Fri, 31 Dec 2021 04:35:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3EJc-0002qc-23 for bug-guix@gnu.org; Fri, 31 Dec 2021 04:35:12 -0500 Received: from mout02.posteo.de ([185.67.36.66]:49437) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3EJZ-0001N0-92 for bug-guix@gnu.org; Fri, 31 Dec 2021 04:35:11 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id E528F240101 for ; Fri, 31 Dec 2021 10:35:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1640943304; bh=/08rg3qOlnFhJz4Z1fE+g3mGm9zcD2VPKrjfmu+mKDc=; h=From:To:Subject:Date:From; b=rxg6L+XRi/xUz4M8clSbjs50/bfjFhoeRnmYQbRk5Fb8sKTuq++w4zRjMwpZ59sXd rNrY9MoOADdIKTHqDuCFgYtQ+BWO2IK8SUaV+eQY2DVWyG6CtXIhxix5U2h4olH9Hm XP57CYCuEJhookixmzdkfUFGX+bdM+j5CWAd7zRWvUW0Tm7inzk+flErCw6Lkf7L1g 3DcEnCPnE3IZI/L2ufbAp/1GFvgSZWioevmLHrQb0NenAlv8kI6wn9CCSm9WInCIJi GD3gmdWsJKTAueenc16J3ARoMhImSBjvF6h31BE3ZpHdo/8YNWzn7S8o10aWxMrysa f5qrQtk1YSfGw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JQKk01hXLz6tmF for ; Fri, 31 Dec 2021 10:35:03 +0100 (CET) From: Guillaume Le Vaillant Date: Fri, 31 Dec 2021 09:17:25 +0000 Message-ID: <87y241azi0.fsf@kitej> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=185.67.36.66; envelope-from=glv@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640943373; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:list-id:list-help:list-unsubscribe:list-subscribe: list-post:dkim-signature; bh=BYDFthe5DcbxKvcL7EZljfcznNEzArzItB/rIXUPceY=; b=IZfEXgYBoDfN5x7QGqCDjwPamE2qzN0rcquBOAGz5FIKLaQWWc2IGy+zWUm5g4lSuytiyc DFFzjNHhsRHnWD+7BMwTzHqb6NfHrAT76YaWJJwlsGzPelnjMY3E3BIVmmkkvDLfSgL6R7 yOWaQurq5xfZBWP7ukmm1OhHQPxtCYxXHC5mfHSe2NhOq0p3ojRAd/FVOClnV3aZErqKrC bqti4m0WwY34DzMQY1F/xy4kt7mdiOUJbzKIh4rYIkC4rvzAmVfi8Z+Kr+TBP1FkW2Pzt3 ub1HvaQeIAf+pfVQM9XHPWrlL9MTQvfN1riu+DvWHo0Riqt1Wfwdye5V466wqw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640943373; a=rsa-sha256; cv=none; b=HjdzPQs+GocfLWg0RLRqINtWN2EPPXDC7bx6Rbv0HBn1pUYXuhND7f40Eurr/Xy7E95xDI qbkZikaqGqmwvjR62hq+CobU9hKYeMLsh+p3XudHdGartXFQY/CE+ICfEZrI2N45Kw4jn0 eoOIgUMPOHCtMwJkVsYCaoedVCTxhPcUppP1WQGuuB5MmECChWE51OGZtoXRRDlsNAq8Ey WhlC7HaGatq6KeoIw1Cd9MXC66bk0sDWoJ6dVpu48n/aameMrMvfpiocdEGuwwW4ocPJEl sScjM+Wvc5cZLMe7D0aOIPR/uV8Sbcgtc5CPcNHBibPA2cXLtiL4i/d90IAo1Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=rxg6L+XR; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.78 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=rxg6L+XR; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BF4DF2EF3A X-Spam-Score: -4.78 X-Migadu-Scanner: scn0.migadu.com X-TUID: lxnucMhR6w11 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable The 0ad package checks the version of mozjs and throws an error if it is not exactly the version it expects. This check is done in "source/scriptinterface/ScriptTypes.h" and it currently requires version 78.6 of mozjs. As Guix has mozjs 78.15 instead, 0ad fails to build. Patching "ScriptTypes.h" to remove the check and compile with mozjs 78.15 doesn't work, the build phase fails with: =2D-8<---------------cut here---------------start------------->8--- ../../../source/scriptinterface/ScriptContext.cpp: In member function =E2= =80=98void ScriptContext::UnRegisterRealm(JS::Realm*)=E2=80=99: ../../../source/scriptinterface/ScriptContext.cpp:146:39: error: cannot con= vert =E2=80=98JS::Zone*=E2=80=99 to =E2=80=98JSContext*=E2=80=99 146 | JS::PrepareZoneForGC(js::GetRealmZone(realm)); | ~~~~~~~~~~~~~~~~^~~~~~~ | | | JS::Zone* In file included from /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.= 15.0/include/mozjs-78/js/Value.h:25, from /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.= 15.0/include/mozjs-78/js/CallArgs.h:74, from /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.= 15.0/include/mozjs-78/jsapi.h:31, from ../../../source/scriptinterface/ScriptTypes.h:63, from ../../../source/scriptinterface/ScriptContext.h:21, from ../../../source/scriptinterface/ScriptContext.cpp:20: /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.15.0/include/mozjs-78/= js/GCAPI.h:539:55: note: initializing argument 1 of =E2=80=98void JS::Pre= pareZoneForGC(JSContext*, JS::Zone*)=E2=80=99 539 | extern JS_PUBLIC_API void PrepareZoneForGC(JSContext* cx, Zone* zon= e); | ~~~~~~~~~~~^~ In file included from /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.= 15.0/include/mozjs-78/js/TraceKind.h:12, from /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.= 15.0/include/mozjs-78/jspubtd.h:18, from ../../../source/scriptinterface/ScriptTypes.h:62, from ../../../source/scriptinterface/ScriptContext.h:21, from ../../../source/scriptinterface/ScriptContext.cpp:20: /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.15.0/include/mozjs-78/= js/TypeDecls.h:55:21: note: class type =E2=80=98JS::Zone=E2=80=99 is incomp= lete 55 | class JS_PUBLIC_API Zone; | ^~~~ ../../../source/scriptinterface/ScriptContext.cpp: In member function =E2= =80=98void ScriptContext::PrepareZonesForIncrementalGC() const=E2=80=99: ../../../source/scriptinterface/ScriptContext.cpp:264:40: error: cannot con= vert =E2=80=98JS::Zone*=E2=80=99 to =E2=80=98JSContext*=E2=80=99 264 | JS::PrepareZoneForGC(js::GetRealmZone(realm)); | ~~~~~~~~~~~~~~~~^~~~~~~ | | | JS::Zone* In file included from /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.= 15.0/include/mozjs-78/js/Value.h:25, from /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.= 15.0/include/mozjs-78/js/CallArgs.h:74, from /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.= 15.0/include/mozjs-78/jsapi.h:31, from ../../../source/scriptinterface/ScriptTypes.h:63, from ../../../source/scriptinterface/ScriptContext.h:21, from ../../../source/scriptinterface/ScriptContext.cpp:20: /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.15.0/include/mozjs-78/= js/GCAPI.h:539:55: note: initializing argument 1 of =E2=80=98void JS::Pre= pareZoneForGC(JSContext*, JS::Zone*)=E2=80=99 539 | extern JS_PUBLIC_API void PrepareZoneForGC(JSContext* cx, Zone* zon= e); | ~~~~~~~~~~~^~ In file included from /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.= 15.0/include/mozjs-78/js/TraceKind.h:12, from /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.= 15.0/include/mozjs-78/jspubtd.h:18, from ../../../source/scriptinterface/ScriptTypes.h:62, from ../../../source/scriptinterface/ScriptContext.h:21, from ../../../source/scriptinterface/ScriptContext.cpp:20: /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.15.0/include/mozjs-78/= js/TypeDecls.h:55:21: note: class type =E2=80=98JS::Zone=E2=80=99 is incomp= lete 55 | class JS_PUBLIC_API Zone; | ^~~~ make[1]: *** [scriptinterface.make:146: obj/scriptinterface_Release/ScriptC= ontext.o] Error 1 =2D-8<---------------cut here---------------end--------------->8--- What would be the best way to fix this? - keep a mozjs-78.6 package around just for 0ad - patch 0ad to fix the compatibility issues with mozjs 78.15 - use the mozjs version bundled in the 0ad sources WDYT? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCYc7Oxw8cZ2x2QHBvc3Rl by5uZXQACgkQa+ggit8h/j/KBwD/QRG086d0GsQcaPtmF9XknAi63U5m3nnrocJw 9X8NaqIA+wb0gAz34Lg1aj44VJHxGo+NEADlnRoRQRH1bvIIXxB0 =qyc9 -----END PGP SIGNATURE----- --=-=-=--