From: "Ludovic Courtès" <ludo@gnu.org>
To: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>
Cc: 54659@debbugs.gnu.org
Subject: [bug#54659] [PATCH 2/2] services: Add 'log-cleanup' service to '%base-services' for build logs.
Date: Fri, 01 Apr 2022 17:41:39 +0200 [thread overview]
Message-ID: <87y20on74c.fsf@gnu.org> (raw)
In-Reply-To: <7073d9d64e8c68c943d4d2a03cb6fee2b6a0364e.camel@ist.tugraz.at> (Liliana Marie Prikler's message of "Fri, 01 Apr 2022 08:05:30 +0200")
Hi!
Liliana Marie Prikler <liliana.prikler@ist.tugraz.at> skribis:
>> + ;; Periodically delete build logs more than 4 months old.
>> + (service log-cleanup-service-type
>> + (log-cleanup-configuration
>> + (directory "/var/log/guix/drvs")
>> + (expiry (* 4 30 24 3600))))
>> +
> This might be very nitpicky, but I think we should leave expiry
> undefined so that the default of 6 months is applied. This way, if
> there's a future decision that all logs should probably kept e.g. for
> only 3 months, there is just one place to edit rather than two.
Yeah, dunno; I thought we’d rather be explicit, but maybe you’re right.
Ludo’.
next prev parent reply other threads:[~2022-04-01 15:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 21:20 [bug#54659] [PATCH 0/2] Periodically delete build logs Ludovic Courtès
2022-03-31 21:22 ` [bug#54659] [PATCH 1/2] services: Add 'log-cleanup-service-type' Ludovic Courtès
2022-03-31 21:22 ` [bug#54659] [PATCH 2/2] services: Add 'log-cleanup' service to '%base-services' for build logs Ludovic Courtès
2022-04-01 6:05 ` Liliana Marie Prikler
2022-04-01 15:41 ` Ludovic Courtès [this message]
2022-04-04 21:17 ` bug#54659: [PATCH 0/2] Periodically delete " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y20on74c.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=54659@debbugs.gnu.org \
--cc=liliana.prikler@ist.tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.