From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SLC2FLS2R2JpcQEAgWs5BA (envelope-from ) for ; Sat, 02 Apr 2022 04:36:36 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id iA/oEbS2R2IOlQAA9RJhRA (envelope-from ) for ; Sat, 02 Apr 2022 04:36:36 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E9EA846C76 for ; Sat, 2 Apr 2022 04:36:35 +0200 (CEST) Received: from localhost ([::1]:50154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1naTcx-0000hs-21 for larch@yhetil.org; Fri, 01 Apr 2022 22:36:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naTcn-0000hF-2f for guix-devel@gnu.org; Fri, 01 Apr 2022 22:36:25 -0400 Received: from mx.kolabnow.com ([212.103.80.155]:60870) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naTck-0001xc-VO for guix-devel@gnu.org; Fri, 01 Apr 2022 22:36:24 -0400 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id 9B3321E51; Sat, 2 Apr 2022 04:36:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:in-reply-to:date:date:subject:subject:from:from :references:received:received:received; s=dkim20160331; t= 1648866981; x=1650681382; bh=BoVuKmdwZQkiguTJBccGFMHjWQbJ/v+gsFJ XWAJx4wY=; b=eRo8GHe0XLo7fLhhvqZHnsJxrEopoyqUQ5jCIatEgbeODKFM7Bh zQotTLoKg8QRN/E7I1/aFBbwQJl3G02URyDxygkmnAnq5atgHDCTc4ZW4IJRk7w2 0mDtJXklkqa6HbUXtsxbmiQNufJvt811i+eJ8wnJmFukUnbQG3DOp76958bL0J8u jLSOPy9XYbznyGUzmIGsTkHCyTxdeoWvciHAmW4B8AfxMCDedhN6Mp39Z6XY5dvn +vWCwswqVXBw04FILSyqvy740fOh/n+X6lINCu21wfA7BA23TbDQqw77d+fGbI92 04GowMlT9T/X7jgTaWt46kHySSbD/3aIji7ZPjYVzNK1t44VEI9MHzZ3T3zn/F6j mW5ARjZGQWxOWjZlgNUuMFotrBKHAjF4oLxbN/ZYxBMf3/+P54ZmZMpDiGLfoS0x Tm0XA853DtgYTyZwbVJ+lnFWMOf9SLHaoy5ahkjfS30Izz9NNHstJjD8gzVNxuaL A0UvoXAPG5B5jTG4lP43XsMoPWu43rH0Htonywre2A2QOZErpvfqdYHvUmYpyFpo M9HaA4MpIYOKJBFB2i/+PhqV4BZXuBz9F/NEZDkCKJQcvH/IWMGkmeWsWVl++xsr L02Fgfd3SF0qSiOdhSJsMW40cIs7rqMaxIPOCcXLcnXSBlYaL4xUL3Ww= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HdJgPCaAD7rB; Sat, 2 Apr 2022 04:36:21 +0200 (CEST) Received: from int-mx002.mykolab.com (unknown [10.9.13.2]) by mx.kolabnow.com (Postfix) with ESMTPS id E85F4E67; Sat, 2 Apr 2022 04:36:20 +0200 (CEST) Received: from ext-subm002.mykolab.com (unknown [10.9.6.2]) by int-mx002.mykolab.com (Postfix) with ESMTPS id 8A54B3B32; Sat, 2 Apr 2022 04:36:20 +0200 (CEST) References: <0035734f12073a2f50d41641f66dacc35e2e6a2c.camel@telenet.be> From: Thiago Jung Bauermann To: Maxime Devos Cc: guix-devel@gnu.org Subject: Reviewing the diff when updating a package? Date: Fri, 01 Apr 2022 22:59:40 -0300 In-reply-to: <0035734f12073a2f50d41641f66dacc35e2e6a2c.camel@telenet.be> Message-ID: <87y20ogqjl.fsf@kolabnow.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=212.103.80.155; envelope-from=bauermann@kolabnow.com; helo=mx.kolabnow.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648866996; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=BoVuKmdwZQkiguTJBccGFMHjWQbJ/v+gsFJXWAJx4wY=; b=g3OFjqduZfCeEddS20DarJcOrkFIbxVQkojwY4HHjEGkh6p0jKG9ne94ppgD31HjizcUN6 MODgkP0wbhsDCLRXHRzE9EUYjAlaVstczhqjECwA6775eokWDfduukGa9zZsLN4lj/mTOI KLMF2e5apjbNQMIM1g7E+gApH0LjvuOP3o6s8dZ2Q1gxnTL8bKud/xxsRiYJHhTtJcgIWr fPPS4p0l5MCrUhr4TpkDXOYozznmKVsHzDt7uBLuaxPE8qvaqn7gtshzqN4ZRZElPiNSbH ekE2212T1Zx7KXQ2yuSg+G1fhnMwgjIg2/ym/BLjXoTIMsVCNXDbVMB8PDMAIg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648866996; a=rsa-sha256; cv=none; b=NwBZZyIMDiCtlfdcTd8YRQuYFtS5pDwHo/xckKuDkW5ErxXcNRnsPQCGB/bfiSE2uA73gk O937fFRnJ+5/c9mrIl7jU7n/gB1gGgwe0hyIZX3W60OZYPO3UpGurPdQU3Q0exl82NDLUO I9tSbJ5RXIl5OqTCgETHGLItG6k1EJoNjj6NTrHH5m3VIuBQrwBe8k5ke+ojdgYLe6jKSA 1PBzT76Q69ZoKZhgv4D5UtsUneLRWs7ILBognuo6k86MmmCZs4/2jew/C9F9ZEUv6Nb5sZ 4BbANY+NYHb0pgnfC+meQO6dBAfEt6K9FCCIeu4VumshvtyGAQsEmSQZFzTs6w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=kolabnow.com header.s=dkim20160331 header.b=eRo8GHe0; dmarc=pass (policy=quarantine) header.from=kolabnow.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.08 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kolabnow.com header.s=dkim20160331 header.b=eRo8GHe0; dmarc=pass (policy=quarantine) header.from=kolabnow.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E9EA846C76 X-Spam-Score: -3.08 X-Migadu-Scanner: scn1.migadu.com X-TUID: DfMbKrYkK2yK Hello Maxime, Maxime Devos writes: > Patch is not yet ready (I'm looking at the source code diff for > anything =E2=80=98suspicious=E2=80=99), just reserving a bug number and a= voiding double > work. Will send an actual patch later. I hope you don't mind me asking what do you mean by =E2=80=98suspicious=E2= =80=99? Is it reviewing the code for security concerns? I ask because I've wondered sometimes whether contributors updating a package to a new version should review the new source code. --=20 Thanks Thiago