all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Thiago Jung Bauermann <bauermann@kolabnow.com>
To: Maxime Devos <maximedevos@telenet.be>
Cc: guix-devel@gnu.org
Subject: Reviewing the diff when updating a package?
Date: Fri, 01 Apr 2022 22:59:40 -0300	[thread overview]
Message-ID: <87y20ogqjl.fsf@kolabnow.com> (raw)
In-Reply-To: <0035734f12073a2f50d41641f66dacc35e2e6a2c.camel@telenet.be>


Hello Maxime,

Maxime Devos <maximedevos@telenet.be> writes:

> Patch is not yet ready (I'm looking at the source code diff for
> anything ‘suspicious’), just reserving a bug number and avoiding double
> work.  Will send an actual patch later.

I hope you don't mind me asking what do you mean by ‘suspicious’?

Is it reviewing the code for security concerns?

I ask because I've wondered sometimes whether contributors updating a
package to a new version should review the new source code.

-- 
Thanks
Thiago


  parent reply	other threads:[~2022-04-02  2:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28 13:12 [bug#54611] [WIP PATCH] gnu: Update libgit2 to 1.4.2 Maxime Devos
2022-03-29 20:30 ` Maxime Devos
2022-03-31 17:11   ` Maxime Devos
2022-04-01 14:43     ` Maxime Devos
2022-04-01 14:57     ` Maxime Devos
2022-04-02  4:23       ` Thiago Jung Bauermann via Guix-patches via
2022-04-01 15:05     ` Maxime Devos
2022-04-01 15:09     ` Maxime Devos
2022-04-02  4:07     ` Thiago Jung Bauermann via Guix-patches via
2022-05-11 21:56     ` bug#54611: " Ludovic Courtès
2022-05-12  6:44       ` [bug#54611] " Maxime Devos
2022-04-02  1:59 ` Thiago Jung Bauermann [this message]
2022-04-02  8:27   ` Reviewing the diff when updating a package? Maxime Devos
2022-04-02 21:48     ` Thiago Jung Bauermann
2022-04-05 12:34     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y20ogqjl.fsf@kolabnow.com \
    --to=bauermann@kolabnow.com \
    --cc=guix-devel@gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.