From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WHk2JUG/aWIfJAAAbAwnHQ (envelope-from ) for ; Thu, 28 Apr 2022 00:10:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id eOEIJUG/aWLQjgAAauVa8A (envelope-from ) for ; Thu, 28 Apr 2022 00:10:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0D9EA377F7 for ; Thu, 28 Apr 2022 00:10:09 +0200 (CEST) Received: from localhost ([::1]:40720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njprM-0004va-7Y for larch@yhetil.org; Wed, 27 Apr 2022 18:10:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njprG-0004vK-P2 for guix-patches@gnu.org; Wed, 27 Apr 2022 18:10:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50798) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njprG-0000Hf-Ew for guix-patches@gnu.org; Wed, 27 Apr 2022 18:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1njprG-0006pc-5W for guix-patches@gnu.org; Wed, 27 Apr 2022 18:10:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54986] [PATCH v2 3/3 WIP] services: mpd: Support socket activation. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 27 Apr 2022 22:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54986 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 54986@debbugs.gnu.org, Maxime Devos Received: via spool by 54986-submit@debbugs.gnu.org id=B54986.165109734426178 (code B ref 54986); Wed, 27 Apr 2022 22:10:02 +0000 Received: (at 54986) by debbugs.gnu.org; 27 Apr 2022 22:09:04 +0000 Received: from localhost ([127.0.0.1]:44695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njpqK-0006oA-C8 for submit@debbugs.gnu.org; Wed, 27 Apr 2022 18:09:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njpqJ-0006ni-AD for 54986@debbugs.gnu.org; Wed, 27 Apr 2022 18:09:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njpqD-0000B1-88; Wed, 27 Apr 2022 18:08:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=xw9jaGc4HDhftwm6DNQkQ7997JIT3DN8fEhbiQ1nyRA=; b=RTxQMuZvIiuryEx6zlyR lnKE0GkA+tw4jDDWRH4mgff5MdMlBj9OzfBUnO1ljDtKCC/F9pwUt2dzj+bZo//OJQInGp3OMzO3Z V+Ps5n7xFd7FFuSe+4d2lBXdaRtms1pS3658+5rO+Y/6jiGWIdSFjG0ZYTjD5nN6cVbZV50rznrao ppVBL0NKNOEH8ftiLUg7LM68o9IEzh24zX//OlzRdCMfUVJ3XzCxWponQtShbU2xhIE1R1l8bnYfV NynhL3hJPQ02vmtW+WmBcGIINLFamB8AJGBrW0yF5CWf5aUqZ8W6FK04RWYOl44fxf89FlrSiX4CZ Ci84PWlJx+xO2Q==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:50558 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njpqC-0006nu-Qa; Wed, 27 Apr 2022 18:08:57 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <155723efbcf08c6e0bb6552b8f6341d4a1f20ecb.camel@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 =?UTF-8?Q?Flor=C3=A9al?= an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 28 Apr 2022 00:08:55 +0200 In-Reply-To: <155723efbcf08c6e0bb6552b8f6341d4a1f20ecb.camel@gmail.com> (Liliana Marie Prikler's message of "Sat, 23 Apr 2022 16:39:59 +0200") Message-ID: <87y1zqfabs.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651097409; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=xw9jaGc4HDhftwm6DNQkQ7997JIT3DN8fEhbiQ1nyRA=; b=pVFMQO3zTrKCEH5bT5OsBydOKOx50OHuMsgtoMlfoZbQ9URhCeUwF6F6H/mfPhzxH+ankZ TYkGRU8zIFZolqDtrIVliKdXpP8tZseKmH43lVwiVpG3ozECODgnCUqGVkzMFiRFvGbI+s Xq9nGdg9gALuKGMD0ujH6Nbr83zgUvk96kCQCiiYP9a1gcDJDfl0smdhQDboN/f7GvZZjF ztuKxyczgIufEOzB1TRFaKawFbizgD8Dvqgb1Yr6lOzUF5wxOlyX/vjktCHUkph7QC8SOa Nme8y/rijI4PHi7fGD0T4G3xFF//+BgnAntL6IuZZ7Kt/jziygKLkGCZBKFzTQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651097409; a=rsa-sha256; cv=none; b=CFijkqdRsPB0cZlE1UV10vuh4cGr+oP7mjJlRjLJ3vJgmqdl7cqD/ycgtukgbbILTPCFfZ N3pTIm2so9TBIOVz0Ceo15+tTB//7jIhOBiswJM75kaWjWLK4sdmPcQ4JnnZX0aeY06lfa BpYJDS26Ua0W1gOKnOx6B5CYdk7d6+vKo5OgTWnYA5h20vcjDqqNmkxqdIjUsX+l8vL8Pq vs4cw8tWlTqmOyjPk8mi9tHJPp/g0aYUUso46Vwj6aEoYJ1bnYM+jNoONdNOmzAtXwdu8Z KiTIvGV/PrJfbfUFSGoGEJQDicxst0cA1HP+6ruPg+pntBPs+zbMKSD0hJPc/g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=RTxQMuZv; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.50 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=RTxQMuZv; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0D9EA377F7 X-Spam-Score: -4.50 X-Migadu-Scanner: scn0.migadu.com X-TUID: RKLbggUCaKvM Liliana Marie Prikler skribis: > * gnu/services/audio.scm ()[shepherd-endpoints]: New f= ield. > (mpd-shepherd-service): Use it. > * doc/guix.texi (Music Player Daemon): Document it. [...] > +++ b/gnu/services/audio.scm > @@ -78,6 +78,8 @@ (define-record-type* > (default "6600")) > (address mpd-configuration-address > (default "any")) > + (shepherd-endpoints mpd-configuration-shepherd-endpoints > + (default '())) ; list of The way I see it, service configuration should be oblivious to whether it=E2=80=99s started as =E2=80=9Cforkexec=E2=80=9D, systemd, or inetd. There=E2=80=99s already an =E2=80=98address=E2=80=99 field above, so my sug= gestion would be to reuse it. This is what I did for example for the openssh service, and also for bitlbee and dicod here: https://issues.guix.gnu.org/54997#5 WDYT? Thanks, Ludo=E2=80=99.