From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oExiKYQTjWN/ZAAAbAwnHQ (envelope-from ) for ; Sun, 04 Dec 2022 22:39:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8DlcKYQTjWOl+wAAauVa8A (envelope-from ) for ; Sun, 04 Dec 2022 22:39:16 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4C04A1FA4A for ; Sun, 4 Dec 2022 22:39:16 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1whU-00060b-B6; Sun, 04 Dec 2022 16:39:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1whS-00060J-HP for guix-patches@gnu.org; Sun, 04 Dec 2022 16:39:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1whS-0007eF-6G for guix-patches@gnu.org; Sun, 04 Dec 2022 16:39:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1whS-00031z-1o for guix-patches@gnu.org; Sun, 04 Dec 2022 16:39:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59661] [PATCH v2 1/3] system: Rename and move %base-packages-disk-utilities. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 04 Dec 2022 21:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 59661@debbugs.gnu.org, Efraim Flashner Received: via spool by 59661-submit@debbugs.gnu.org id=B59661.167018990311636 (code B ref 59661); Sun, 04 Dec 2022 21:39:02 +0000 Received: (at 59661) by debbugs.gnu.org; 4 Dec 2022 21:38:23 +0000 Received: from localhost ([127.0.0.1]:59914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1wgo-00031c-OJ for submit@debbugs.gnu.org; Sun, 04 Dec 2022 16:38:23 -0500 Received: from mail-qv1-f42.google.com ([209.85.219.42]:46613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1wgm-00031V-AD for 59661@debbugs.gnu.org; Sun, 04 Dec 2022 16:38:21 -0500 Received: by mail-qv1-f42.google.com with SMTP id mn15so7072751qvb.13 for <59661@debbugs.gnu.org>; Sun, 04 Dec 2022 13:38:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=ujatZ66pvgTRezi+KLRaxbfNdGSoNmvHlR1G0dwKiWE=; b=b06inj5KSSzTJDI3Ybr2wqrnY/Hasu/BgiTvIzbCnQ6YdWsO93OJY707lRmIhKlAJx vnnRuEQrv4LO83qVjmjmOiO8ZyUWnKRmyG8PW3Sjn3x27kr3KDlNmWjDGLDvwC0Ajjf4 p1rMrUjzC5BYjgiZpg6r11UnXSXB6tRnaEdwmjSpWytlgD6/U/8xYPoRWoFFmKM6dOkj 91JVqY+D/baNz3eKwLcOcdmVPrDpi4Pq8tF1wjLxAt9bvB3Wl5PvnGTXvgDRlT+peXL5 +48az+jSrd4h2j9x0tvRTQHN0TZzeKRwSPP9ExAZHYeI31md42Oj6Zy5nFyHcCZm+cmP 8HtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ujatZ66pvgTRezi+KLRaxbfNdGSoNmvHlR1G0dwKiWE=; b=uN7Lr8BBMHb0slYeEetzNBznYH5kMHazRkt4kLT86YY/Rg3hOSTGVfvtrpak4sjVLG 5fO6xV69YWplcYLQJQiyUXqH6rdg7FUPBUBIjk+cULhI2ZeRnSb6ewRoQAqHBPeAh92P VvI3mNVUmsyvUXo+QiaeWTu+53nuBCoLF3ZJTJjy7zgX9z7W5wUPBIZZQzzyXoMgynqm v9oEIkxLYN/YykvJkVpDNUI5/7knSO9KVsB7R1zwpRRSX45DVF135k2ydD/UDv8rKKkX 2j/AN4KzCEofpY9mbbf5irBwo/ZCLa7RW/Eq2+kLsAnHIEZ6Sl9Ni0y0mGNdii7gcdRr //BQ== X-Gm-Message-State: ANoB5plsE/JSa4PJyUQ/gDyS5x9O3OT4/k9pH9/Je6UOR/QJXojOKL+F b8Ee9dq2kRhlo/U5EQsh/RPJ8vIuzcg= X-Google-Smtp-Source: AA0mqf6W518S1XZdyE3XIZyaX85/FN2//k5DWugxl2fXAUsH3yLvBkdb6DnNob5JHsZLAWs8RDs34g== X-Received: by 2002:a0c:de0a:0:b0:4c7:1a90:228f with SMTP id t10-20020a0cde0a000000b004c71a90228fmr21207720qvk.61.1670189894699; Sun, 04 Dec 2022 13:38:14 -0800 (PST) Received: from hurd (dsl-156-154.b2b2c.ca. [66.158.156.154]) by smtp.gmail.com with ESMTPSA id y26-20020a37f61a000000b006fc62eabcc9sm10354604qkj.134.2022.12.04.13.38.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Dec 2022 13:38:14 -0800 (PST) From: Maxim Cournoyer References: <20221204044347.23147-1-maxim.cournoyer@gmail.com> <875yernns5.fsf@gnu.org> Date: Sun, 04 Dec 2022 16:38:13 -0500 In-Reply-To: <875yernns5.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 04 Dec 2022 17:20:42 +0100") Message-ID: <87y1rm6e9m.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670189956; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ujatZ66pvgTRezi+KLRaxbfNdGSoNmvHlR1G0dwKiWE=; b=Yh/WG0cN1FAALJxkXXk9Az8XxYQkPkRmP0MZSi4VgRUN6HifUgH7OfDdEWxlXcik4x4/VA ilygJqazfkmbL8XhrH74tLuLCmSWGJ/vH5j+PshGlNF7mv7dB9t+ayb1+UymXwxCYjlQ4A vWbLatn6Ccu6CWKLRMeXHMml+xtbm9kHVDcKJEGW1FVYZxu5F5Hxt3FBmyIUF1hBil/d2r mcDCWQEilUV0qXsiy4CnO3Lp5ZP+tJlCd66tvYEgjp1erkJc29U27zsYLjkqotUWFgADrm Cw2iogvHzuWzb90Kxy9/GhANIcFWZs2jwhc5YOdhqR2AN3Ub9pgUFMnyR5QbOw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670189956; a=rsa-sha256; cv=none; b=GfayyAa0bI35O77kPGi94XGmkzAtVvEIrdrn8TF4tEl0WwV2S7qdLtPU9WZw0WgWkk+HjB zUk68kzDXs8QF2CFkd+QTeAVTYTrAdcymZUZmjI9b/OXyni2MLW9fE///s4oEX49mU2Ihc jFaPODyXSRGRFWwV96nkPHzbGLyrxd9PFXGcOyjkAJRi67tDqP6i3nkxqdHabSYJZMD8Es 1iTU6712cAp7VwXoGJzsJKV7lsU9KwcTDshPOxMUjGoBxnknhf1Gg9JM7MB4MKDaqRbuOz OK3mPUlekgDO4ADupTTC/SwArPXBQfVdssg2hVuXs80/5TJq8l5Jcv7GbjXxLQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=b06inj5K; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.04 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=b06inj5K; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4C04A1FA4A X-Spam-Score: 6.04 X-Migadu-Scanner: scn1.migadu.com X-TUID: gIi7llKfJ6sq Hi Ludovic, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> Rationale: It is only used in INSTALLATION-OS and doesn't make sense to = be >> used in another context, given that file systems now automatically pull = their >> dependencies since commit 45eac6cdf5c8d9d7b0c564b105c790d2d2007799 (serv= ices: >> Add file system utilities to profile). >> >> * gnu/system.scm (%base-packages-disk-utilities): Deprecate and rename t= o... >> * gnu/system/install.scm (%installer-disk-utilities): ... this. >> (installation-os) [packages]: Adjust accordingly. > > Efraim, this variable was added in > e6e076281e62518056987e9ddd3d96fccab20475 and used in > 4170af491c8bc3b0a5308116a26e758d8ff245c5; do you think it=E2=80=99s okay = to > remove now? (It LGTM, but I=E2=80=99d like to make sure we don=E2=80=99t= create churn.) > >> +(define-deprecated %base-packages-disk-utilities #f '()) > > =E2=80=98#f=E2=80=99 here would lead to weird deprecation messages. I=E2= =80=99d make it: > > (define-deprecated %base-packages-disk-utilities %base-packages '()) > > This is not quite accurate but it should convey the idea. I had shown an actual message example produced when using #f. It is what I want (it just mentions the variable is deprecated, and doesn't mention a replacement -- there are none in this case). For a quick reference, this is how 'warn-about-deprecation' is defined: --8<---------------cut here---------------start------------->8--- (define* (warn-about-deprecation variable properties #:key replacement) (let ((location (and properties (source-properties->location properties))= )) (if replacement (warning location (G_ "'~a' is deprecated, use '~a' instead~%") variable replacement) (warning location (G_ "'~a' is deprecated~%") variable)))) --8<---------------cut here---------------end--------------->8--- So I prefer my version. If you still think the produced message is weird, I'll need a bit more explanation to understand why you think so :-). --=20 Thanks, Maxim