From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 2NtfMrYt8GPuSAEAbAwnHQ (envelope-from ) for ; Sat, 18 Feb 2023 02:45:26 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id cFlAMrYt8GMNlwAAauVa8A (envelope-from ) for ; Sat, 18 Feb 2023 02:45:26 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 772E221560 for ; Sat, 18 Feb 2023 02:45:26 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=UqpHGfQx; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676684726; a=rsa-sha256; cv=none; b=BfzSqmp49jAXs42550ILbNSI0bTlM1wo7WDJlE78j6KO1Tb9mf4cUMO/GSOdMYIN10sGoV hu1hZbXUDb0M92KFWM7HHEYQAciuESBDyiuBZcqlj+LnGbs5oS6pwxZ8fnoDF4m2ev3duH pBaIgg0BtbXVDOMcFXu5EpuDKCgDKqWEYJiDevu8/d01XAgrzUFhj2eiGC4Knl2JlWC8YQ 1L832ySPtumR83nup252nIWlscoCaNbveUYo+AYefsSURWMXVON8huoWu7uJ5X1f/IaVMm +5JclN6yo/PT5c5wZdKaym3fJJvFeQKG/rSBMXb1LnvwO104AGaj0FebNFlkeA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=UqpHGfQx; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676684726; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Ry75VHXy2v0lUt+0SwOpiFD6Fims72dbpebRcFE2jM0=; b=VYrJbZErmQAeRx03Zh/kaU8rzoruZ1rbmL1gwhcI5xDKhQFNmGNCZfcnWvMgCN5viaJnUQ EFfAPvFBedH7AJ0HrRACT8J6b/qRN/S2qMuVXduuztZsI1Q86flpLdyfXn5IS0+0X/A2UK FADUs4CrLQmaNgjdvuf2ZuckRt0/ru54/BqJhJD/DGueHvuBrEnFNy5iIlDe2CE2vnwSDx motqGVvV84E2Tpnc5XTROOtPInEMZQkcqivOwosq5ZUfp585vSs2GCyKdT/Dbjq8mIclwQ 0HRwE6+IJ0cXVccoTeMtjFj52Aj1hJrZXifMd3wdexDAxlzGymeI8+MWsiWrFw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTCHg-0003zc-2S; Fri, 17 Feb 2023 20:45:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTCHe-0003yo-U8 for guix-patches@gnu.org; Fri, 17 Feb 2023 20:45:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTCHe-00059i-Jn for guix-patches@gnu.org; Fri, 17 Feb 2023 20:45:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTCHe-0001Eg-Ez for guix-patches@gnu.org; Fri, 17 Feb 2023 20:45:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59355] [PATCH] gnu: Add dataparksearch. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 18 Feb 2023 01:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59355 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Adam Faiz Cc: 59355@debbugs.gnu.org X-Debbugs-Original-Cc: 59355@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by 59355-submit@debbugs.gnu.org id=B59355.16766846434635 (code B ref 59355); Sat, 18 Feb 2023 01:45:02 +0000 Received: (at 59355) by debbugs.gnu.org; 18 Feb 2023 01:44:03 +0000 Received: from localhost ([127.0.0.1]:42022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTCGg-0001Cg-Kc for submit@debbugs.gnu.org; Fri, 17 Feb 2023 20:44:03 -0500 Received: from tobias.gr ([80.241.217.52]:55720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTCGd-0001C9-CY for 59355@debbugs.gnu.org; Fri, 17 Feb 2023 20:44:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=Ry75VHXy2v0lU t+0SwOpiFD6Fims72dbpebRcFE2jM0=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=UqpHGfQxqyhou+G6sSfBkJ7vqdi2sje+WOikRn 2hlWf3jxbxdLNjGzxtNk+S8qIinUFCjaHpzjDdpGHgo48B/Z+oYgyWXbFiY04QhgcUPH4K kbLMekw3uYIkk2M7pE2mWlvQ2ZyIhcSc1B/1ITb/v9seAwHz1/iuWycrwRD8nUo/vHdSLO Xp6Urk6i1zHcPfT8Tn88z0Cqcg2r8UGuITuH3OG/I5urpEPsK1Hi0BurGaZZ4F+WzzitUm e90XWBWbzIHbV9CAvbs67+IhWgNcvJQKoM+PuaYzQ7cqzFdJ0KAM/f2/Ckg5XpG3pOVEyQ ULFh+AcuYbpKIuycQCtjQYgQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 380b3588 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 18 Feb 2023 01:43:55 +0000 (UTC) References: <9ff6c39e-933b-d16e-3e3f-ad62c4a09f54@disroot.org> Date: Sat, 18 Feb 2023 01:13:24 +0100 In-reply-to: <9ff6c39e-933b-d16e-3e3f-ad62c4a09f54@disroot.org> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87y1ovbvfd.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Tobias Geerinckx-Rice X-Migadu-Queue-Id: 772E221560 X-Spam-Score: -4.03 X-Migadu-Spam-Score: -4.03 X-Migadu-Scanner: scn0.migadu.com X-ACL-Warn: , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: kyMzcQrZDHY+ --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Adam, Adam Faiz via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A > * gnu/packages/search.scm (dataparksearch): New variable. Thanks! I've applied the patch locally but stopped short of=20 pushing. I have several questions and [notes]: > +(define-public dataparksearch > + (package > + (name "dataparksearch") > + (version "4.54-2016-12-03") I don't think this tag is anything special compared to other=20 commits. Is it? There are many more recent commits, up to 2022. If the argument=20 is =E2=80=984.53 is ancient=E2=80=99 (it is!), should we just package the l= atest=20 commit? Would the latest release (4.53) instead still be useful today? > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url=20 > "https://github.com/Maxime2/dataparksearch") > + (commit version))) > + (sha256 > + (base32 > "1g5kxw2d8jbc1h9yyy0xpnd3gkscj5a32k6hk3brvdwcbsnjbgyg")) > + (modules '((guix build utils))) > + (snippet > + #~(begin > + (for-each delete-file-recursively=20 > '("config.sub" > +=20 > "config.guess" > +=20 > "configure" [All checked into Git. Nice. This snippet is =E2=80=98ugly=E2=80=99 becau= se it=20 addresses an ugly problem. I think I'll keep it but add an=20 apologetic comment.] > +=20 > "Makefile.in" > +=20 > "missing" > +=20 > "depcomp" > +=20 > "ltmain.sh" > +=20 > "compile" > + )))) [We don't dangle brackets like this but keep them on the previous=20 line.] > + (file-name (git-file-name name version)))) > + (build-system gnu-build-system) > + (native-inputs > + (list pkg-config automake autoconf libtool openjade)) > + (inputs > + (list mbedtls-apache zlib postgresql aspell c-ares=20 > libextractor)) [For consistency with other packages, I've moved the =E2=80=A6inputs below= =20 the arguments field.] > + (list #:configure-flags > + #~(list "--disable-syslog" Is this not useful? If not, could you provide a short comment=20 explaining why? > + "--with-gnu-ld" And here? > + (add-before 'bootstrap 'fix-configure > + (lambda _ > + (substitute* "configure.ac" > + (("MY_DIRS=3D\"/usr/local/include") > + (string-append "MY_DIRS=3D\"" > #$(this-package-input "aspell") "/include")) > + (("MY_DIRS=3D\"/usr/lib") > + (string-append "MY_DIRS=3D\"" > #$(this-package-input "aspell") "/lib")))))))) Why not use --with-aspell=3D=E2=80=A6 as you did for Postgres? > + (synopsis "Libre, feature rich search engine") [We don't need to include =E2=80=98libre=E2=80=99 (or =E2=80=98Free=E2=80= =99, =E2=80=98open-source=E2=80=99, =E2=80=A6) in=20 descriptions: there's no other software in Guix. \o/ ] > + (description > + "Dataparksearch is a full featured web search engine. > +It has support for http, https, ftp (passive mode), nntp and=20 > news URL > schemes, and > +other URL schemes with external parsers. > +It can tweak URLs with session IDs and other weird formats, > +including some JavaScript link decoding. > +Options to query with all words, all words near to each others,=20 > any > words, or Boolean queries. > +A subset of VQL (Verity Query Language) is supported.") > + (home-page "https://www.dataparksearch.org/ ") [Extra trailing =E2=80=98 =E2=80=99 removed.] > + (license license:gpl3+))) Why GPL3+? [I was unable to get this package to build reproducibly, although=20 I tried only disabling #:parallel-build?.] Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCY/AtJg0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15g+wA/RYqRuVZpVxRXQJlUIBjnggIUnxHRNfo5cADuy3H GVlLAQDTmXjKxa0wanweimNFqLDBU6l8dKgQa9HfA3FFXG4rDQ== =xAw1 -----END PGP SIGNATURE----- --=-=-=--