From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iFVaBHXZ/WPdeAAAbAwnHQ (envelope-from ) for ; Tue, 28 Feb 2023 11:37:41 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id gMhUA3XZ/WOrswAAG6o9tA (envelope-from ) for ; Tue, 28 Feb 2023 11:37:41 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 89FA7CC91 for ; Tue, 28 Feb 2023 11:37:40 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWxM6-00044A-MV; Tue, 28 Feb 2023 05:37:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWxM0-0003wO-On for bug-guix@gnu.org; Tue, 28 Feb 2023 05:37:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pWxLz-0001Id-9R for bug-guix@gnu.org; Tue, 28 Feb 2023 05:37:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pWxLz-0000JP-4m for bug-guix@gnu.org; Tue, 28 Feb 2023 05:37:03 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#61684: can't compose 'with-patch' with 'with-source' Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 28 Feb 2023 10:37:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61684 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 61684@debbugs.gnu.org, Maxim Cournoyer Received: via spool by 61684-submit@debbugs.gnu.org id=B61684.16775805991139 (code B ref 61684); Tue, 28 Feb 2023 10:37:03 +0000 Received: (at 61684) by debbugs.gnu.org; 28 Feb 2023 10:36:39 +0000 Received: from localhost ([127.0.0.1]:49788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWxLa-0000I7-VQ for submit@debbugs.gnu.org; Tue, 28 Feb 2023 05:36:39 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:37624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWxLZ-0000Ht-G6 for 61684@debbugs.gnu.org; Tue, 28 Feb 2023 05:36:38 -0500 Received: by mail-wr1-f51.google.com with SMTP id h14so9190999wru.4 for <61684@debbugs.gnu.org>; Tue, 28 Feb 2023 02:36:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677580591; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=GfcTrYkN9JqnhY0sZHosQvmuMNwuwj+f+QTjtt7StW0=; b=drJ+j71MvDsPBkQ61rfX03gny3gsOggnY1Nz5KROh/KQgS5CebOy9amjnU1j9s8daO EiQZNWHpvskpR09TLifPL74cJ0u+cfqrw7TIN9iW3YHJMrwezDCAxMIJhbQLrYGXJgnc VzwEh5uqx5As0wGCiYqCtIJc/sZoVHuIi7OR5c1R+n6QeWNsVHmAzTID6htUSy8c6Ynk dSMr3US6OEXO9wtKLGx85/0vNrBzgNVgs+6/hPsdrWMcwNVRw5QEyrekp0RL5LqrNG57 EwHJhuzjGJCWEgYperGqCwfrHdYik8Ybis+Yc7Yih4wry7TYtPJZXYcS5+9N2/37SwQ+ kYcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677580591; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GfcTrYkN9JqnhY0sZHosQvmuMNwuwj+f+QTjtt7StW0=; b=HELVmMfD71LtMnNO5iX3oN84pneMyAybThU3L364GKu0QR62SOJnfsY3gby52IifvM j87wvhdCXraafSPLm2n7rs38aklxqtBVRLR6dLqgh49Ev3zxq5zwpuQ27vWI2yPY+Kt3 97qaSa23cLfIR9XJZvbBJ+bs9HtIID2nOV5TIQ8TBg45x/pt0gQ54X8feSOus2fnGvY4 q4T1PdT8SG4Eq5NAEkuhwG/nPVNFCCHYaKoaQTjwOwYdVzi/CPjiDdh7BiOUuGSYSZTM 0JDFeOpeaPuH8pSIM6g3TqB1g5iWN/s5GK8PT0O28modqHxoGLc7TVLR23/LqjXBhwSe XBkQ== X-Gm-Message-State: AO0yUKU0LoK4+1Z44ciBnKVgnwnAy6/VGPkii3fRYooZv3ATApU8Y3IO HJctFT7t8aPbkuONUZSTmNk= X-Google-Smtp-Source: AK7set9gbeZ1fA2S4j93ea+qC2ilBZ9+GK4ejIXfgAn1B9K/lfD44T+2KQe+gv593TRH6SP0bll78w== X-Received: by 2002:a05:6000:90:b0:2c7:1a96:efc2 with SMTP id m16-20020a056000009000b002c71a96efc2mr1544466wrx.4.1677580591718; Tue, 28 Feb 2023 02:36:31 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id n17-20020a05600c4f9100b003e876122dc1sm16488902wmq.47.2023.02.28.02.36.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 02:36:31 -0800 (PST) From: Simon Tournier In-Reply-To: <878rgjkxnw.fsf@gnu.org> References: <87mt56gac6.fsf@gmail.com> <871qmg79u7.fsf@gnu.org> <87356whvaa.fsf@gmail.com> <875ybrmfuv.fsf@gmail.com> <878rgjkxnw.fsf@gnu.org> Date: Tue, 28 Feb 2023 11:00:08 +0100 Message-ID: <87y1oijejb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=drJ+j71M; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677580660; a=rsa-sha256; cv=none; b=F6JiAIjUnGEVcVjhltvq2BlyKoF7Ljxl1LTkXHnjsPfVA0VPNTiM/muyDgWFBZrwAoaYA4 F6SOcQ2q2IP0Mtr0eflug8aszUlMt52rs4lcn3nQ+yThleKbOEVeval/A6CVdS3SIxG8NU X4mZZBiw2VqjQrVHP3YvanhsmvaVUYhAGuDEBcSwGQSRHt1ydZLHxuzY62tM/IlwUoh1iy tmcaHQ7fOadCNlu4ODsciNmk9xTkXdcX/ZkWmF2UK+6rqVyGW/0dEIU47pfz/CVSKEVYHy tdh9oLhhW+vr/XnYVudSCuJcL2k53YXXEgwSf3QuYpysmQo1aLrt8pzLWioTtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677580660; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=GfcTrYkN9JqnhY0sZHosQvmuMNwuwj+f+QTjtt7StW0=; b=TC5i4ZYO54SkPeHnmw87CHs9TVE2dGuhRX/sdyNxJqP6rYl80mCASq6JnY/TJKQJBh9on/ NCKxj+C4IqkfKzD4RHmKxX7ESRJvTN8jbH4SU2U7o6j7Xjzyx706f2p1ZTI4YCcFwpcilx tggVHPY3+ERM1/LgzENej7LisJwzGAn6nXR7eYmEKS29oJCzgAKFPXLQm3Kj8bxpzRPafU isXfjSHJ5Z+j25Zlv9+XPsCVjSBFx0Q0BwWyJn0lCuGN22o/j9kWLWhJthcqHmkJT71RiE /gCIMPRhlFUthgIw6X/OrsPt1LR7Hs3n7cx60uk3en95jFfXCPJeinm85zfkfw== X-Migadu-Spam-Score: -2.09 X-Spam-Score: -2.09 X-Migadu-Queue-Id: 89FA7CC91 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=drJ+j71M; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-TUID: lhrdDQsAHFwt Hi Ludo, On lun., 27 f=C3=A9vr. 2023 at 15:09, Ludovic Court=C3=A8s w= rote: > However, as I explained before, there=E2=80=99s no clear way to do that f= or two > reasons: > > 1. Transformations apply to bags, not packages, so we cannot tell > whether a transformation has an effect until after the transformed > package has been lowered. Even then, it=E2=80=99s tricky. > > 2. In this case, this has to do with the semantics of transformations > themselves: by definition, =E2=80=98with-source=E2=80=99 dismisses p= atches. I probably miss many details and that=E2=80=99s why I do not understand correctly your words. Or maybe we are not using the same meaning behind =E2=80=9Creport if the transformation makes sense or not=E2=80=9D. 1. From my point of view, the transformations are functions that you compose. The composition rule is not commutative maybe neither associative. Writing down how each function (transformation) composes with the others allows to specify the composition rules. 2. All the code in (guix transformations) acts at the package level, so I am still missing why it would not be possible to detect some issues there. For instance, --8<---------------cut here---------------start------------->8--- (define applicable ;; List of applicable transformations as symbol/procedure pairs in the ;; order in which they appear on the command line. (filter-map (match-lambda ((key . value) (match (transformation-procedure key) (#f #f) (transform ;; XXX: We used to pass TRANSFORM a list of several ;; arguments, but we now pass only one, assuming that ;; transform composes well. (list key value (transform (list value))))))) (reverse opts))) --8<---------------cut here---------------end--------------->8--- and I miss why, 1. it would not be possible to check if the transforms compose well; somehow verify the assumption. For instance, =E2=80=99package-with-upstream-version=E2=80=99 raises many w= arnings depending on various cases, and I miss why, 2. it would not be possible to have similar warnings for other transformations. Cheers, simon