From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Bruno Victal <mirai@makinata.eu>
Cc: dev@jpoiret.xyz, 60756-done@debbugs.gnu.org
Subject: bug#60756: [PATCH 0/2] Add x11-socket-directory-service-type.
Date: Tue, 21 Mar 2023 16:50:15 -0400 [thread overview]
Message-ID: <87y1nplth4.fsf_-_@gmail.com> (raw)
In-Reply-To: <4eab1cc425f89bf321477b432ba407a71285e974.1678105938.git.mirai@makinata.eu> (Bruno Victal's message of "Mon, 6 Mar 2023 12:35:01 +0000")
Hi,
Bruno Victal <mirai@makinata.eu> writes:
> The x11-socket-directory-service misuses activation-service-type
> to create directories. This kind of usage is incorrect since
> activation-service-type does not depend on file-systems, hence incompatible
> with user defined /tmp mount.
>
> This commit turns x11-socket-directory-service into a shepherd one-shot
> service by defining a new x11-socket-directory-service-type.
>
> * gnu/services/desktop.scm (x11-socket-directory-service-type): New variable.
> (x11-socket-directory-service): Deprecate procedure.
> (desktop-services-for-system): Use new service-type.
> * gnu/tests/lightdm.scm: Ditto.
I've applied this series, with the small change:
--8<---------------cut here---------------start------------->8---
modified gnu/services/desktop.scm
@@ -1578,7 +1578,7 @@ (define sugar-desktop-service-type
(define x11-socket-directory-service-type
(let ((x11-socket-directory-shepherd-service
(shepherd-service
- (documentation "Create /tmp/.X11-unix for XWayland.")
+ (documentation "Create @file{/tmp/.X11-unix} for XWayland.")
(requirement '(file-systems))
(provision '(x11-socket-directory))
(one-shot? #t)
--8<---------------cut here---------------end--------------->8---
Thanks for the contribution and to Josselin for the review, which made
me much more confident to install it (along with the QA badge).
--
Thanks,
Maxim
prev parent reply other threads:[~2023-03-21 20:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 15:43 [bug#60756] [PATCH 0/2] Add x11-socket-directory-service-type Bruno Victal
2023-01-12 15:46 ` [bug#60756] [PATCH 1/2] services: " Bruno Victal
2023-01-12 15:46 ` [bug#60756] [PATCH 2/2] Revert "tests: Add gdm tests." Bruno Victal
2023-01-12 15:49 ` [bug#60756] (no subject) Bruno Victal
2023-02-18 15:19 ` [bug#60756] [PATCH v2 1/2] services: Add x11-socket-directory-service-type Bruno Victal
2023-02-18 15:19 ` [bug#60756] [PATCH v2 2/2] tests: gdm: Remove tmpfs related tests Bruno Victal
2023-03-06 13:16 ` [bug#60756] [PATCH v2 1/2] services: Add x11-socket-directory-service-type Josselin Poiret via Guix-patches via
2023-03-06 12:35 ` [bug#60756] [PATCH v3 " Bruno Victal
2023-03-06 12:35 ` [bug#60756] [PATCH v3 2/2] tests: gdm: Remove tmpfs related tests Bruno Victal
2023-03-21 20:50 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1nplth4.fsf_-_@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=60756-done@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=mirai@makinata.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.