From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id iFrXMeDGMWTsfAEASxT56A (envelope-from ) for ; Sat, 08 Apr 2023 21:56:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uLfhMODGMWTRcQEAG6o9tA (envelope-from ) for ; Sat, 08 Apr 2023 21:56:16 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 73F2631B92 for ; Sat, 8 Apr 2023 21:56:16 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plEf6-0000h4-Kl; Sat, 08 Apr 2023 15:55:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plEf3-0000gk-3o for guix-devel@gnu.org; Sat, 08 Apr 2023 15:55:46 -0400 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1plEf1-0008RV-8N for guix-devel@gnu.org; Sat, 08 Apr 2023 15:55:44 -0400 Received: by mail-qt1-x82c.google.com with SMTP id g12so1394897qtj.12 for ; Sat, 08 Apr 2023 12:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680983742; x=1683575742; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=r12El6Df9o94Dv3SQ2qfEeLjvSg8z+U1NWk64Cl85Mc=; b=EbNf5Hkv/ImGVp69nJ9njO/tHLfpwwTmcHcEkhqhc6Khj3jDDQYdbGDW/ddB1F34pk rEtXN7abc3WsfhKfQwoNNDjHsWFdaEhCtoEEOCQLHN7z5WXBTfESNCkBJpVJsYtYJuqi AEgdYLYNltMFxHuDdTwmK/ufwQ+ode5I8PTbBn/gBiTMUjaXlkiM+rwdVI2QI0RF2qnp DIl6VYV3+zphPhcZ5uBLEge0M0BVF6RZJovv7pAFE1Oy2bfXu/YXmiFy/1OnLR22Bzi5 ZT2f6s0gY59lSoENrT7WHe5Q4qUpaCaeSgqeeM3d3ntxxYDh1ix0G7qJuUjAA7oxzRos b67g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680983742; x=1683575742; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=r12El6Df9o94Dv3SQ2qfEeLjvSg8z+U1NWk64Cl85Mc=; b=AaHh+irdHVizTXWr7AcoB+gjchJJALvNN+xw1Xz5jY+tQFLf82QjjhM75Bl/HCjKRP 2YPRc77y8e7RR2oKVVpSBCXCmxNYW3IWKHGI7z2PcSuKXiE072KHzcNOhIQ4VU6LNoKb tGSQKpmA5Z+AXDW1WKBqUv1ETIX7Yttptwpvaq7SoLg4BIUOz4xImFUzwI6QqBqZsKSJ RUrugBzYM73PpyGdJxT7fcJwd5Cw2mSwsPWyp+7llbt55yh/zmgsS5kqAgfqK/PD88Ug H1nzlppMlrRYAQqm62wH720PuKY91TWIeka19ckFf4sduHqCb5+F81jSZrfQfVV/PHfi y7rA== X-Gm-Message-State: AAQBX9dMBg6syI/KeRBXPg4YNu2m0ITTTHhFRYhELU83EX1bAbuP7c7S uNlJ2M94y/OdQ/e1Vp+A+hc= X-Google-Smtp-Source: AKy350YRFa0dXSCsrIn2e3gr9M6CI/upckRfdKtLzdHKSV4uhmv4L44wh6G5BgQijm8Df9zjuatK0w== X-Received: by 2002:a05:622a:1301:b0:3e3:867e:1801 with SMTP id v1-20020a05622a130100b003e3867e1801mr11584736qtk.31.1680983741984; Sat, 08 Apr 2023 12:55:41 -0700 (PDT) Received: from hurd (dsl-205-233-125-210.b2b2c.ca. [205.233.125.210]) by smtp.gmail.com with ESMTPSA id m17-20020ae9e011000000b00746b2ca65edsm2164231qkk.75.2023.04.08.12.55.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Apr 2023 12:55:41 -0700 (PDT) From: Maxim Cournoyer To: Bruno Victal Cc: guix-devel , cox.katherine.e@gmail.com Subject: Re: [RFC] Cosmetic changes to define-configuration usage References: <87lejdvuzn.fsf@gmail.com> <66232cd3-ff0b-e248-1ae0-4839e793e994@makinata.eu> Date: Sat, 08 Apr 2023 15:55:40 -0400 In-Reply-To: <66232cd3-ff0b-e248-1ae0-4839e793e994@makinata.eu> (Bruno Victal's message of "Mon, 3 Apr 2023 15:13:02 +0100") Message-ID: <87y1n2p2rn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::82c; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x82c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680983776; a=rsa-sha256; cv=none; b=lnVeO2RoqPBpOkUmPsaVYDB6j1PWPN1RmUI8ClOBl8cWI7BkhXB1HXYzV1zctZ6MXKG3TB TuFQhMSiuzFJbDo7Zo31D03Mv0muV4ZC55tSsFrrdQVibZbDCPMJrbLYVEViN9BS2tWiJS qxdnYkx8rwfDBqLZvI14d7vZe7g401QOGIb8z8+PeEWpf6eb+ZjzlsGT/zuP99tWefRzhA fneYtequ1VNiWYWKlM/vMlYYs/rzq0BjofErdmxTvykcjqxkvbyubd/SRCjBy3n1O3CnoD qKgtVdeVLtDpE4CiS0GJOwIu6KyR8NYZANWG2qM9I0nY0AjXgtdzURVgFQWmRw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=EbNf5Hkv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680983776; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=r12El6Df9o94Dv3SQ2qfEeLjvSg8z+U1NWk64Cl85Mc=; b=ab+PfHoMrnBrvNgnTPDyU80SBUnWk1KPokhtF4rhrkPL75A0HAr7HXPhf1JuYOAsd/O+j7 4+YzhFmNsCsq+pyGmyGvcCF/5v2hV7xi/ycV9Ws3R4uIwRa89SVv1LWXe2bXBSB4mAfO4o Pj2lDhJ0fet/2+4NxjQgeF51uQBTTrayHyHYlngD4EaNHP8isoTtaiaQLphiWOPHdKiEUg sypo5hFqbyvgrgyIMGsTuBwZWSyZPVgMq2P0pe8VbG4lE/OZDCMLvwdWvDYHcRmXbsCnAa GJzcq0G7zMpDDa7FcQ0VFwPFKMBZH/R+LhaTxgc8BHnwdt/PLThe8gdwHVdiBg== Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=EbNf5Hkv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -9.75 X-Spam-Score: -9.75 X-Migadu-Queue-Id: 73F2631B92 X-TUID: cMgWE2ns+mCd Hi Bruno, Bruno Victal writes: > On 2023-03-31 15:46, Maxim Cournoyer wrote:> I have some apprehension > that if we start adding white space between the >> fields here, we'll soon have people adding white space to many other >> places (for consistency or other reasons), which I wouldn't welcome (I >> value compactness, and since in Scheme a single newline is used to >> delimit things at the top level, too much of white space can make things >> less readable in my opinion). > > I don't think it needs to be an all-or-nothing situation, > the spacing rules can be always applied selectively =E2=80=9Cwhen it make= s sense=E2=80=9D. > > I think spaces between fields is consistent with the general way of thing= s, > for instance, throughout Guix, sections that are only scheme code often do > have some spaces here and there that were added without any adherence to = some > rigid criteria but the programmer found it to be an adequate point to=20 > partition the logic. > > The same reasoning applies here, the logic partitioning is done per field= instead. > Objectively, there's also a small quantitative difference that's not comm= only > present in the rest of the codebase. define-configuration handles both co= de and documentation, > or putting it another way, it intersperses code and (rather long) strings= . The result > is that it's particularly information-dense compared to any other part of= the guix codebase. You make convincing arguments. If it's understood that it makes sense in this specific case and not to be taken as "let's add white space to all the records in the Guix code base", I don't oppose the change, if people find it makes a difference for the better in terms of readability. Are there people who would like to block the change? Otherwise, I'll contribute it as-is in a few days. --=20 Thanks, Maxim