From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 0JKMC0YEVGSMhwAASxT56A (envelope-from ) for ; Thu, 04 May 2023 21:15:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id MJ7MCkYEVGTQMwEAG6o9tA (envelope-from ) for ; Thu, 04 May 2023 21:15:18 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EF19C23569 for ; Thu, 4 May 2023 21:15:17 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puePz-0000Xq-Ro; Thu, 04 May 2023 15:15:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puePv-0000WB-Ae for guix-patches@gnu.org; Thu, 04 May 2023 15:15:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1puePv-0005oe-1e for guix-patches@gnu.org; Thu, 04 May 2023 15:15:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1puePu-0006Mr-GC for guix-patches@gnu.org; Thu, 04 May 2023 15:15:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63263] [PATCH] gexp: Stop generating unreadable builder scripts. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 04 May 2023 19:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63263 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 63263@debbugs.gnu.org Received: via spool by 63263-submit@debbugs.gnu.org id=B63263.168322765224382 (code B ref 63263); Thu, 04 May 2023 19:15:02 +0000 Received: (at 63263) by debbugs.gnu.org; 4 May 2023 19:14:12 +0000 Received: from localhost ([127.0.0.1]:52101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pueP6-0006LC-D5 for submit@debbugs.gnu.org; Thu, 04 May 2023 15:14:12 -0400 Received: from jpoiret.xyz ([206.189.101.64]:35014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pueP4-0006L3-4f for 63263@debbugs.gnu.org; Thu, 04 May 2023 15:14:11 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id F40D0184F2D; Thu, 4 May 2023 19:14:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1683227648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w5Rgo9zd4+3P0i3wRbdsPpWMuJbxRsyr/8khsGvgSU8=; b=WcGGBfxdJM6LjKUw27KIcC4etFFs2fEtJ9F7uBf1g+GxNkBtwanSIFqMMTEz3OwTpmXfqg an8ag9De/kArUF5NL6O+Z2nNAknXJQKzFFmonfjkW00Mm3fIIUyfGZMRDYBzCeaa7Cccc7 ZHI62hIH1Q61BphdbdJEVRYWAHTCjZPDIqQ0UnkNHMB+du3QVOpzvgiMRItz0qxtbuAk9m llPiJAFBj7AW9fQT3gxNUhmPe3vXcYDLyTdkITRXAc0tYIF+Pvj5kgpXLTwvch6DscP5X3 iC9JYouEnZ4/zn1pxr5oEvCvh+DHoREQ7MRpJa0yuO1tqABKiL59f5cQlmTxIw== In-Reply-To: <875y98nryn.fsf@cbaines.net> References: <20230504112448.22462-1-mail@cbaines.net> <87zg6kqn50.fsf@gnu.org> <875y98nryn.fsf@cbaines.net> Date: Thu, 04 May 2023 21:14:05 +0200 Message-ID: <87y1m33o5e.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Josselin Poiret X-ACL-Warn: , Josselin Poiret via Guix-patches From: Josselin Poiret via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683227718; a=rsa-sha256; cv=none; b=f515PYlFsoesZAxEH5T8gjRe71z0EvT7BTrfMhBLExsbsplsquv1cZtCIz/1ozFVwbHfMO +NR8vFNvUyu9AuRxJsKVK3y8QzVHzr5GgkGNUzA3py1eu3uLE/TANfCEymn/hpmGvRHhNS 19aAQS3yWN3WVD7fhRMhzWWb0NRzLohjjFJywoMRQ2qBsRojxg9xyi9fGKK4IZjhtoWsU4 7rMNYkGg13DyrwZIsoK1jy9P4KJjEA7c+274HSczY7gRNzx7xyQjckfzT/tcpF7TIFsuKD /GHOvgYPBXnGm6sPOIxPmJvQG5MzgngEyKN3hCMMIemQOFDT9+PgxcxyP+rtKg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=WcGGBfxd; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683227718; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=w5Rgo9zd4+3P0i3wRbdsPpWMuJbxRsyr/8khsGvgSU8=; b=DFDTk8yeyAyY+wewctlQLjfsddygIB+rtJGMZQIe5ZzwsvQmW76J1oVMYqXDwdhSDj6MQ8 JO30YJYSuuzwe4o674GMwmAbHvFptVA48eaUlbk4v+65NWYycmBelGJBFtu/48362bgwCn mchz4AQXeSmVeHIxDd9Tt4OAayBqsjN+FM0fLnlfbbcrH9cAizv3Y9kV23sPSr68U3GXVd RMwC1WSi04eE5QsW5sUC1KMvwYLOUfmb/8reGl/AYZgiEq3HAeyqWcXLoIXxTSTPMMvgZl umq40pM93ArDmdRysy9ccTPuCDsqDiP+zQp6TMvuYMLkdVNBIvLDDNBe1V6XUQ== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=WcGGBfxd; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.80 X-Spam-Score: -3.80 X-Migadu-Queue-Id: EF19C23569 X-TUID: n1Q/cx/Lh8Dz --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Chris and Ludo, Christopher Baines writes: > I guess my perspective on this is more from the operation of the guix > data service, which is carefully computing and storing all of these > broken derivations (and there's a lot, like 10,000+ per revision at the > moment, since they change every time you compute them). This then > propagates down to the build coordinator as well, since there's builds > being submitted for all these broken derivations. I have considered > trying to detect these breakages in the data service, but I'm not sure > how to do it while removing the possibility of false positives. I guess you already read the derivations from the data service to find out what has changed, right? Would you also be able to try to read the builder script from there, before trying to build? And if the derivation is bad, signal it somehow and flag it for some sort of gc? Although then, all other derivations depending on it would also need to be gc'd, which might be annoying. I don't know if the data service's architecture would allow this to be done before trying to build derivations though, sorry in advance if that would be too much work. Best, =2D-=20 Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCgAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmRUA/0QHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5FhcaiucaC/46cA5Fnamrlu1fZ3ZeknxPuuHsj1+NTlaZ GNdDkH07RPTDA0gl28CZUEgt/xYRwW8R0HGxK5xVMP3z0n/MOVwPfTZ1Lb3kOUaU Qjc/qKh3EYrpyTHwed4AshNAE1SepSfYGnCq6KZ5M5XxcSAF42bgyDUmbFaUbRps CYf5diJMSlIdZPTXrMYyAQbpNDZdX1wmKdLm+EXGli+NI4rXvPXjtm9MSIfM2i98 HVF5TCiXlg7hJeZRorymOPSf+Y9EVv/OqiZzQ1ojbzfoI9xFAn3FnjXHsB/iVCRQ Z91jtJj9s9j/271lxbFx1yheNIDFLla5ETWuztQ3L1uGch6edvvRa15Jp7RXHfi2 BHO5OEWzV/AI4P2ockAHxYS6fhVeEdrgZVvkElOvxnP1p7WpfDP5sg53fqBEJWJD nS1BBGAokegdmL8SF4R88GaazYBQIBLg/Y5mX9A8v8UcWqWbsqVDQO5XZDOR574k 4qTLv0UDzozq/DAWYjmJKkRFVf+zdU0= =9oUI -----END PGP SIGNATURE----- --=-=-=--