From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id iP7rN1DrXGTUdwAASxT56A (envelope-from ) for ; Thu, 11 May 2023 15:19:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id QC/RN1DrXGT1JQAAauVa8A (envelope-from ) for ; Thu, 11 May 2023 15:19:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 88F27C8D0 for ; Thu, 11 May 2023 15:19:12 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px6CH-0006ZA-EH; Thu, 11 May 2023 09:19:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px6CE-0006Yn-Sg for bug-guix@gnu.org; Thu, 11 May 2023 09:19:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1px6CE-0001Qo-K2 for bug-guix@gnu.org; Thu, 11 May 2023 09:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1px6CE-0007wg-GD for bug-guix@gnu.org; Thu, 11 May 2023 09:19:02 -0400 Subject: bug#63378: [PATCH] teams: Fix script to produce a single X-Debbugs-Cc header. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Thu, 11 May 2023 13:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 63378 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Arun Isaac Cc: rekado@elephly.net, 63378-done@debbugs.gnu.org Mail-Followup-To: 63378@debbugs.gnu.org, maxim.cournoyer@gmail.com, maxim.cournoyer@gmail.com Received: via spool by 63378-done@debbugs.gnu.org id=D63378.168381113630517 (code D ref 63378); Thu, 11 May 2023 13:19:02 +0000 Received: (at 63378-done) by debbugs.gnu.org; 11 May 2023 13:18:56 +0000 Received: from localhost ([127.0.0.1]:50041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1px6C7-0007w8-Ik for submit@debbugs.gnu.org; Thu, 11 May 2023 09:18:55 -0400 Received: from mail-qk1-f177.google.com ([209.85.222.177]:52653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1px6C6-0007vu-9l for 63378-done@debbugs.gnu.org; Thu, 11 May 2023 09:18:54 -0400 Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-75773ff9830so266562385a.1 for <63378-done@debbugs.gnu.org>; Thu, 11 May 2023 06:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683811128; x=1686403128; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=OCwLU1tfSWzQK3msEsfuENY2n16RZ7xnW1nLE0qsynk=; b=DXSV+oEP3BD1ddFcYj9be134Gbq8y/KwCcMM1ywAzrSLpyGxV2CtMRf2pEiaoxEe2e GQhojbqQyxKn68+plYJL2cAVPLUaJsH0cmyHe59HIFzxcpsjyfQ2ErL3/k6L4XsQJOGM /slAXYB305pEahMXDqFCTMfphV4pYskGkLM3tLgYK0u/mCvFCADY5Rjkw4AlJMVgyiWd ZmFocmZH7MMm3jytcex5YNaNAUsvpnW/8lSYg6DCY0BrcxkokhwnH71vQq1ebj3Mp521 3mjA1y96MXam2m36/h6s399fklmi3D84P01IcM1NA1vH6INoUv1dbFCsymejBinWgZoa h24Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683811128; x=1686403128; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OCwLU1tfSWzQK3msEsfuENY2n16RZ7xnW1nLE0qsynk=; b=NXrIfZhpiivRVrP2unC6oLZx8M6yrQV1FI8E3piy7N+raDUSkmlS/hCLop7qNyMnVP YBhK9wniOYjE6UrP+hVZnqqJaHpZ+Iub9OncFKHCnaa0feYFz/bKb1BKP4G8xKojDvvL rPg5hDn8tZif9qBXMRMzd1lByOoNWqCYGfcPE+JsRv2Ly0wgq7BYMSyyZjuFpW6IH//p MiaGYDlOj6o+wRtMmMinY7rPGP3o+bhpdk50wIucbEVlzG77iFSzejISuF4gyqHZSBAe CpYllpLH5R7TjYOGL2/0h23cc4Jb8ke0VFxT1uXMsKRWzxQN5qI1lwokC3oLBPRqmdfd QFRQ== X-Gm-Message-State: AC+VfDxLypsxIdbc3TftN4RhbApT+GmeRJCcYSu65WuhsH04f278dwOl m0AidPsQG07CU3+jBGlWuMFa7LU9CcI= X-Google-Smtp-Source: ACHHUZ6rDA1DDSrlGjdbSez2ZeMjkWHPKpFIJlQN+b7LR3sHuED15PBAqvP9x39YmaVxuKSqWRg66w== X-Received: by 2002:ad4:5ecf:0:b0:5f1:31eb:1eff with SMTP id jm15-20020ad45ecf000000b005f131eb1effmr32501695qvb.2.1683811128202; Thu, 11 May 2023 06:18:48 -0700 (PDT) Received: from hurd (dsl-155-1.b2b2c.ca. [66.158.155.1]) by smtp.gmail.com with ESMTPSA id ph1-20020a0562144a4100b005ed90bf69efsm2268635qvb.114.2023.05.11.06.18.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 May 2023 06:18:47 -0700 (PDT) From: Maxim Cournoyer References: <875y92vj2j.fsf@gmail.com> <3e14e27ad26ce9dee230733c7e77935b5f43599d.1683570582.git.maxim.cournoyer@gmail.com> <87jzxh6ovy.fsf@systemreboot.net> <87bkisqi24.fsf@gmail.com> <87zg6b5dew.fsf@systemreboot.net> Date: Thu, 11 May 2023 09:18:46 -0400 In-Reply-To: <87zg6b5dew.fsf@systemreboot.net> (Arun Isaac's message of "Thu, 11 May 2023 12:13:27 +0100") Message-ID: <87y1lvngzt.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683811152; a=rsa-sha256; cv=none; b=dLGFLp64hMuZaCPWlcJIZADBI6+hc9n1Y7gxV7KoDcFzQZL0B7zmCnasvR3Gi5YhrWgJAF 12aldibiRQ8/muMGYzSnYRVKotNg5FcmXYE87XkR7rhDNq+b4C40dzyHuzLIGY2xD1THw3 PGehanJR07ygrNoXJUL7K9m6FGi59c48k0SKqzct+QiC3sGw9RI+jI1SF4pliBq1IMK/2G UpHLpBJg4nW4whh05OplwEqpBn7QMsCOWNnS81yli8QOjwDZItJ4jU6wXTu+iBIeVl0tYy RGEy8pUj2dKHTmW3nkC1XU2RgquPftqQxG+TbUzZfvrc+RDboAFHvuja6h1jZQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=DXSV+oEP; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683811152; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=OCwLU1tfSWzQK3msEsfuENY2n16RZ7xnW1nLE0qsynk=; b=YtPaRID0M+RjHZWgRUPXi9K744JEBPpPZn44eoB75Nb9+rXxl93tKpNsxszUfWa7DDpsJ+ YqZ87c4XPoBD5+YNOkvaMfXsPVwZ4xXqPvDEGST+8bp64ttSzlIzw3b3ZyueKBybspKt+l aCjXcaCb4qI5rCBtZ4Yjrv2qc0Mmo7IH5U/S5VzG++vW4juV4AZ7V8oRRZovmhpjLNwP8l Wv23f7pH+5J/QlsINlfqaeTql5vY1+foeITxEDVgQFBE4ZmUrzYglh+FhhXX+beOIevo37 /JisWE/bmF8lBT6cXrzcCMLRqP2CKrg/TlQrdYmhOC44xo9qjgWYIGsJT6D7vA== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=DXSV+oEP; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.32 X-Spam-Score: 7.32 X-Migadu-Queue-Id: 88F27C8D0 X-TUID: 8xKd0hg0kYpa Hi Arun, Arun Isaac writes: > Hi Maxim, > > Thank you for the updated patch! :-) It LGTM. Please push. > >> OK! I opted for simplicity and double-quoted all the names. > > Fair enough. Though a check is only one condition away! ;-) > > (if (string-contains? (person-name member) ",") > (string-append "\"" (person-name member) "\"") > (person-name member)) It's string-contains without ?, apparently. Let's try this (and save a few bytes per submission :-)): --8<---------------cut here---------------start------------->8--- modified etc/teams.scm.in @@ -618,7 +618,11 @@ (define (sort-members members) (define (member->string member) "Return the 'email ' string representation of MEMBER." - (format #false "\"~a\" <~a>" (person-name member) (person-email member))) + (let* ((name (person-name member)) + (quoted-name/maybe (if (string-contains name ",") + (string-append "\"" name "\"") + name))) + (format #false "~a <~a>" quoted-name/maybe (person-email member)))) (define* (list-members team #:optional port (prefix "")) "Print the members of the given TEAM." --8<---------------cut here---------------end--------------->8--- The change is now installed; thanks for the review! -- Thanks, Maxim