From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id GHgqO5jytmR5CgAASxT56A (envelope-from ) for ; Tue, 18 Jul 2023 22:14:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id +GslOpjytmTjXgEAG6o9tA (envelope-from ) for ; Tue, 18 Jul 2023 22:14:16 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 552223D947 for ; Tue, 18 Jul 2023 22:14:16 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ROU3Xxgg; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689711256; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Y4jZsjTFRe46ujHFrSI+gAgQIiAC74YHi84iNcBFc38=; b=uGynwJPCa6z1Szu77UNLLFtiVCaAS2P2HqLtg/Y9Yy3yHw059Qof/Kvrnc08jdxtaYSup0 i1tkjnkgT1tUyHbaNodgzQFzq9u2sCebBEufSvrGuY0OoIVnp9RmIRuWbf9VbZ2VG+YnVK FGHfzlBdM+lVbW9/xxw9Kt8XEufDFlUANijB8i7BAAYUnh5ldUBl52YkOQk7VHVmaC/3Pk 6rTepyVw8nnVWP70/kP2jQ9r/cejzxDJW+zVOro+a4ufJb1MV5rB/b182lFViDbxGRX/e6 1bnhE/KYXUgxOINpSxqJXzhvDFlaqv+Mltpc07EAmResk/yaj9kuDRWxSxyfbQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689711256; a=rsa-sha256; cv=none; b=T0IveWXG/lPpJ1SHwjmE9BBPPoJwdBAkLrw9SHbVpQ0bezrv/zDDI0La7wLKiiVPXDu0Jc 5cV/bU2ja/V1y9/YKc+MWwwpFz3q/7VRyMtflHw+i7wyQXU9E+ynfMFaQhzzwMW6wGKHBv 2euEJOjsLU0YnRyA2DJ1ef3yfTqGgu+1xO18noWJy6lM3qeeUZYe2udRbPp/kGjIvOwyQ0 NKW3fUchHTZR+YwMcsUgLIIAgB94L0QMjy/WXrX7bWBGjQmNozk+mzOTFcygi2QTCclYhp 5UnzSk4sIpxqHESfqUyjBTnBdOSfRqGslmJ2dcdhuD9WaOLMk1/FD7b0wm08Sg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ROU3Xxgg; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLr59-00087H-Hs; Tue, 18 Jul 2023 16:14:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLr58-00086j-6P for guix-patches@gnu.org; Tue, 18 Jul 2023 16:14:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLr57-000092-UK for guix-patches@gnu.org; Tue, 18 Jul 2023 16:14:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLr57-0003y2-I3 for guix-patches@gnu.org; Tue, 18 Jul 2023 16:14:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64711] [PATCH 00/45] Fix builds and skip failing tests for the Hurd. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 Jul 2023 20:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64711 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Janneke Nieuwenhuizen Cc: 64711@debbugs.gnu.org Received: via spool by 64711-submit@debbugs.gnu.org id=B64711.168971122915217 (code B ref 64711); Tue, 18 Jul 2023 20:14:01 +0000 Received: (at 64711) by debbugs.gnu.org; 18 Jul 2023 20:13:49 +0000 Received: from localhost ([127.0.0.1]:54383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLr4r-0003xH-MH for submit@debbugs.gnu.org; Tue, 18 Jul 2023 16:13:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLr4l-0003wu-QD for 64711@debbugs.gnu.org; Tue, 18 Jul 2023 16:13:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLr4g-0008M5-F2; Tue, 18 Jul 2023 16:13:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=Y4jZsjTFRe46ujHFrSI+gAgQIiAC74YHi84iNcBFc38=; b=ROU3XxggTYYCqapn0Rnn 2gfpPV8Fmt/f7jX3UZUE9fVN8VLuhCP05UDGUti59lzMA/GHhN0f+W/VEASVVsQv9SPKx5LC24Ib4 k06mHfM+KPUjtrBESFEmwcvvQyGBLHtBItR7o0DTQhAUENR3U68LuA7kL68MSZQpnRloWKvx5vJSd 9lQ5nsj8K/T1uC18X7nBtbI/fgnrEdaYEpZy7GPSCTw7MatYuqmKlokO+zs7y1+P71jJvo/XBKk8o tf9MXk2eHWbqFw0ts+VZx4nQX8cFUqqN821WGkjLZn9NkF3DzeOgYm13w86saEhTUtp4XxmaAIfH7 2qWFuC1HLF0vpg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLr4d-0007IR-5v; Tue, 18 Jul 2023 16:13:34 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <53cd3ef833e0f894e620f8e3a43cdbe6e1f6f62b.1689690897.git.janneke@gnu.org> Date: Tue, 18 Jul 2023 22:13:28 +0200 In-Reply-To: <53cd3ef833e0f894e620f8e3a43cdbe6e1f6f62b.1689690897.git.janneke@gnu.org> (Janneke Nieuwenhuizen's message of "Tue, 18 Jul 2023 16:39:56 +0200") Message-ID: <87y1jdgeqf.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -5.34 X-Spam-Score: -5.34 X-Migadu-Queue-Id: 552223D947 X-TUID: 6VA12UUdFr5s Hello! Great work! A general comment: these changes to test suites were made based on feedback from non-chrooted builds, whose outcome is influenced by system state such as running translators. Until we have chroot builds, I think we should be cautious and not invest too much time. Janneke Nieuwenhuizen skribis: > * gnu/packages/base.scm (coreutils)[arguments]: When building natively on= the > Hurd, remove "test/df/unreadable.sh" and "test-perror2" from #:make-flags= 's > XFAIL_TESTS as they now pass. Move failing script tests from XFAIL_TESTS= to > 'remove-tests' phase. In phase 'remove-tests' rewrite substitute* to skip > tests instead of removing them. Add hanging and failing tests. [...] > + '((substitute* > + ;; These tests hang > + '("tests/cp/sparse-to-pipe.sh" > + "tests/split/fail.sh" > + ;; These tests error > + "tests/dd/nocache.sh" > + ;; These tests fail > + "tests/cp/sparse.sh" > + "tests/cp/special-f.sh" > + "tests/dd/bytes.sh" > + "tests/dd/stats.sh" > + "tests/ls/dangle.sh" > + "tests/ls/follow-slink.sh" > + "tests/ls/hyperlink.sh" > + "tests/ls/infloop.sh" > + "tests/ls/inode.sh" > + "tests/ls/selinux-segfault.sh" > + "tests/misc/env-S.pl" > + "tests/misc/factor-parallel.sh" > + "tests/misc/ls-misc.pl" > + "tests/misc/nice.sh" > + "tests/misc/pwd-long.sh" > + "tests/misc/shred-passes.sh" > + "tests/misc/stat-slash.sh" > + "tests/rm/fail-eperm.xpl" > + "tests/split/filter.sh") > + (("^#!.*" all) > + (string-append all "exit 77;\n"))) For example, I wonder how reliable this long list is. Some of these tests may fiddle with /proc, /etc/fstab, and other things not under control, which means some might suddenly pass for some reason. So I wonder if we should just #:tests? #f in this case. Thoughts? (With other, higher-level test suites with a couple of failures, it=E2=80= =99s probably still a good idea to skip individual tests instead of the whole test suite.) Ludo=E2=80=99.