From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 6JEnO7dCwWQLCQAASxT56A (envelope-from ) for ; Wed, 26 Jul 2023 17:58:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 6NvxOrdCwWQaGgAAauVa8A (envelope-from ) for ; Wed, 26 Jul 2023 17:58:47 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9129E51A64 for ; Wed, 26 Jul 2023 17:58:47 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=UCFzk6Jb; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1690387127; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=RTfy5ngZW8nJfFVptzGvEx370gIvFzJyoNgohmOPyrs=; b=KbWcwQ9ie/zHWKSAjvoVwzt2m7jr2mjLJ+mUo5E+anONGJ75+d32p3bq40G4f6d0K63u7J IzSc6FCjKvoCufKY8ESzTj0zdnz04dFNdFZ/mQ3Pa/LsdFfHvKmgUVO3L6VdKC1jKFiK0r onZCpyi/Pcy1dZzLiSEaxVLxvHOYz831SGjmE5gTcSTce9gMGO/FOuraIIspbj3xReR8By nKpD/Qjatd/woYyNh8VkTYIzfadHxjYU81qkHJaLOcAICk9GelHYt8vkJquP4KcDyS0Eyo z4Sr0gm9Vnj5Wo07RGW/GMPkWdZCW5W8i+niYmXwM6Oy4Kgx0xxOisa6axVxXw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1690387127; a=rsa-sha256; cv=none; b=DLz09Viae49dI29Pm9IDwJA4FyJnbLQenJsnm70LWTP0755Wk85nbEJ9xkFaKDvvfMBQ8s NnJ5l1PeyuWAjScn5wnWpJG715aELm74uADuTTlUnWo0KAbCLAMT6EIXEwk0kN+xvdo5C8 jUmM2wg2ZWyNfI2t+s6XhYRUYMc3qu6ydCVsOEMXKCzGaYopqH6Sc/FW8wxDDTQe2Y5HXK BnADYw1foO6Tq4XIDoWxUJ0F1rQjw56GoRSjnVNnu3u/vHPp2/RUgXH8iPn0Fi3H5HnQ+J Pp4Zzc+S56i3XW1Aaj443LSjzQVAcxgwYzUGU8gCu+E7tXN4qFvS3ZTIGPqp+w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=UCFzk6Jb; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qOgrc-0005M8-RT; Wed, 26 Jul 2023 11:55:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOgqt-0004v6-7q for bug-guix@gnu.org; Wed, 26 Jul 2023 11:55:05 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qOgqs-0002Qm-RM for bug-guix@gnu.org; Wed, 26 Jul 2023 11:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qOgqs-0004UE-MY for bug-guix@gnu.org; Wed, 26 Jul 2023 11:55:02 -0400 Subject: bug#63082: [PATCH v3 10/16] services: mpd: Let Shepherd effect the user/group change. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Wed, 26 Jul 2023 15:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 63082 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Bruno Victal Cc: Liliana Prikler , 63082-done@debbugs.gnu.org Mail-Followup-To: 63082@debbugs.gnu.org, maxim.cournoyer@gmail.com, maxim.cournoyer@gmail.com Received: via spool by 63082-done@debbugs.gnu.org id=D63082.169038688117208 (code D ref 63082); Wed, 26 Jul 2023 15:55:02 +0000 Received: (at 63082-done) by debbugs.gnu.org; 26 Jul 2023 15:54:41 +0000 Received: from localhost ([127.0.0.1]:49928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOgqW-0004TT-Lt for submit@debbugs.gnu.org; Wed, 26 Jul 2023 11:54:41 -0400 Received: from mail-qt1-x836.google.com ([2607:f8b0:4864:20::836]:55693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOgqU-0004TG-Vn for 63082-done@debbugs.gnu.org; Wed, 26 Jul 2023 11:54:39 -0400 Received: by mail-qt1-x836.google.com with SMTP id d75a77b69052e-4055c143ca6so30633461cf.3 for <63082-done@debbugs.gnu.org>; Wed, 26 Jul 2023 08:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690386873; x=1690991673; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=RTfy5ngZW8nJfFVptzGvEx370gIvFzJyoNgohmOPyrs=; b=UCFzk6Jbaly8EmqKPbYaS/euEHnPd2J3ZcyJwr6OKlW156hioJR0l1CII3EEz4MRC6 VkAz95cZf/kqK/q8sLKsLRYuxR+DLXWl7XrJQnwLDN0DJKkg0wNJ9JPoIRkts69r9pA8 XM7gLzUjdfeaS3gpl0RggroXn0d8GEfQuHM1pNdNmi4KznSYTqJjFmyUBl/uqtOuk7qx sk3ms+a5JVeCYxZsGU8CZld+yCcmaUGODPGsqrhDCi/IBKGstVyGLmQgCP8diy2iIk+p ymcvCc/mwNBVry8EYVv5KDMbRUozqhqiMZM26O3v1nYC/Lxe0d5dpy2Y/ImfBDY3o1+y yLiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690386873; x=1690991673; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RTfy5ngZW8nJfFVptzGvEx370gIvFzJyoNgohmOPyrs=; b=GKBp2U5hGXfX2OLm3hoO4h1aRedtksOmWxtJs/ksp9ArnX+gDOzV3hHAXADAKwXRiG Iwoy9R6uMDno5ZdmBjJw8V6ftHnEVfrLup6Od/Y6zec3baTjrRxY/tJcZ3n28KQu/t95 TkiF94dEl7Y43nq6Ba5ImELY7ZYMHiCqUH6ub9eZ5gb5xsatyz1V6xml/fgKziFq/AEK BeWmvfIBtKMScHJ6mU4LK+myQcJiMTNeyJ6VNiJy05yTp2cMCZ8Ux95ERIJ48Z0TXDq+ bC/pKnV6LhCJHa/Kyr4kkNyemAnr1moGMonNDkbKjm9277XNqihlDLqjbowmq/CTy1dR WeUQ== X-Gm-Message-State: ABy/qLa/NoKHBK9UXJuX8dwCtye6jvzQuV8iUBqm0OIJ5W9i/Wab8apD NIPF50CAkBmCgDTkE6LuHyg= X-Google-Smtp-Source: APBJJlFBsqwJpGFHb7x9rHi2tgWVBohrUsNcNelrwboOfyLsH1XDmGl0obWRjO9u5kHnSRtVbHQmNg== X-Received: by 2002:a05:622a:1793:b0:405:50b8:dc1d with SMTP id s19-20020a05622a179300b0040550b8dc1dmr2652344qtk.48.1690386873209; Wed, 26 Jul 2023 08:54:33 -0700 (PDT) Received: from hurd (dsl-10-141-65.b2b2c.ca. [72.10.141.65]) by smtp.gmail.com with ESMTPSA id ff20-20020a05622a4d9400b00403f1a7be90sm4892006qtb.88.2023.07.26.08.54.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jul 2023 08:54:32 -0700 (PDT) From: Maxim Cournoyer References: <5c6d38ec1621cf031175df6e05c027285d0acaae.1683299529.git.maxim.cournoyer@gmail.com> Date: Wed, 26 Jul 2023 11:54:31 -0400 In-Reply-To: (Bruno Victal's message of "Wed, 24 May 2023 17:41:23 +0100") Message-ID: <87y1j2zn0o.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -5.06 X-Spam-Score: -5.06 X-Migadu-Queue-Id: 9129E51A64 X-Migadu-Scanner: mx1.migadu.com X-TUID: AB49aqnp45Uc Hello, Bruno Victal writes: > On 2023-05-05 19:29, Maxim Cournoyer wrote: >> Relates to . >>=20 >> Quoting a MPD developer, regarding MPD's feature to switch user itself: >> "that's legacy for the dark ages when proper service managers did not ex= ist" >> :-). >>=20 >> * gnu/services/audio.scm (mpd-serialize-user-account) >> (mpd-serialize-user-group): Delete procedures. >> * gnu/services/audio.scm (mpd-configuration) [user]: Do not serialize. >> [group]: Likewise. >> (mpd-shepherd-service): Provide the #:user, #:group and #:supplementary-= groups >> arguments. >> (mympd-shepherd-service): Likewise, and remove the '--user' argument. >> * doc/guix.texi (Audio Services): Update doc. >> (mympd-configuration) [port]: Change default value to 8080. >> [ssl-port]: Change default value to 443. >> * gnu/tests/audio.scm (run-mympd-test): Adjust accordingly. >> --- >> doc/guix.texi | 12 +++++----- >> gnu/services/audio.scm | 52 +++++++++++++++++++++++++----------------- >> gnu/tests/audio.scm | 4 ++-- >> 3 files changed, 39 insertions(+), 29 deletions(-) > > This contains a submarine change that isn't easily spotted from the > commit message, that mympd is getting its default port changed and that > it can no longer bind to privileged ports, since although mympd can > start as root in order to bind to possibly privileged ports, it will > explicitly refuse to continue running as root afterwards. > > I think we can have shepherd effect for mympd, but only if (and after) > shepherd gets support for POSIX capabilities (CAP_NET_BIND_SERVICE) or > a suitable way to specify that =E2=80=9Cyes, the program invoked by the s= ervice > should have CAP_NET_BIND_SERVICE=E2=80=9D is provided. As mentioned before, I've let go of this commit for now (though that means supplementary-groups on a user-account are not honored anymore) and other commits touching the current group mechanism until we've implemented support for POSIX capabilities as mentioned in https://issues.guix.gnu.org/64862. We can thus close this issue for now, keeping on mind that some bits could be salvaged at a later time when 64862 is done. --=20 Thanks, Maxim