From: "Ludovic Courtès" <ludo@gnu.org>
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: 64874@debbugs.gnu.org, dev@jpoiret.xyz, mail@cbaines.net,
othacehe@gnu.org, me@tobias.gr,
Jean-Pierre De Jesus DIAZ <jean@foundationdevices.com>,
rekado@elephly.net
Subject: [bug#64874] [PATCH] guix: tuned-package: Use target on cross-compile.
Date: Wed, 16 Aug 2023 23:54:01 +0200 [thread overview]
Message-ID: <87y1ia1wna.fsf_-_@gnu.org> (raw)
In-Reply-To: <87r0o3dj6v.fsf@gmail.com> (Simon Tournier's message of "Wed, 16 Aug 2023 18:51:36 +0200")
Hi,
Simon Tournier <zimon.toutoune@gmail.com> skribis:
> On Wed, 26 Jul 2023 at 17:37, Jean-Pierre De Jesus DIAZ via Guix-patches via <guix-patches@gnu.org> wrote:
>> * guix/transformations.scm (tuned-package): Use either bag-target if
>> available or bag-system to select the CPU architecture of the package
>> that is going to be tuned. This enables the tuning of cross-compiled
>> packages.
>>
>> Signed-off-by: Jean-Pierre De Jesus DIAZ <jean@foundationdevices.com>
>> ---
>> guix/transformations.scm | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/guix/transformations.scm b/guix/transformations.scm
>> index 92d9c89c0e..76d0208bf1 100644
>> --- a/guix/transformations.scm
>> +++ b/guix/transformations.scm
>> @@ -510,8 +510,9 @@ (define (lower* . args)
>> ;; leading to an obscure build error, check whether the compiler is known
>> ;; to support MICRO-ARCHITECTURE. If not, bail out.
>> (let* ((lowered (apply lower args))
>> - (architecture (match (string-tokenize (bag-system lowered)
>> - %not-hyphen)
>> + (target (or (bag-target lowered)
>> + (bag-system lowered)))
>> + (architecture (match (string-tokenize target %not-hyphen)
>
> Ludo, WDYT?
LGTM, thanks for the heads-up!
Ludo’.
next prev parent reply other threads:[~2023-08-16 21:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 15:37 [bug#64874] [PATCH] guix: tuned-package: Use target on cross-compile Jean-Pierre De Jesus DIAZ via Guix-patches via
2023-08-16 16:51 ` Simon Tournier
2023-08-16 21:54 ` Ludovic Courtès [this message]
2023-09-17 13:08 ` bug#64874: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1ia1wna.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=64874@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=jean@foundationdevices.com \
--cc=mail@cbaines.net \
--cc=me@tobias.gr \
--cc=othacehe@gnu.org \
--cc=rekado@elephly.net \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.