From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 0GjHLJr2+WSUUAEAauVa8A:P1 (envelope-from ) for ; Thu, 07 Sep 2023 18:13:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 0GjHLJr2+WSUUAEAauVa8A (envelope-from ) for ; Thu, 07 Sep 2023 18:13:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8666831FDF for ; Thu, 7 Sep 2023 18:13:14 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debian.org header.s=1.vagrant.user header.b=ojFZIBSC; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694103194; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=q3mNKHW1pS3OP3pXS8TkoMseoMnFerLpuSE4+7DHzOM=; b=RYSkna9eMFdNzRBGN+2f8FPZ7MSTVLmLDSsG+ho0VlZws9dj5VdtK9tGzUSyXMLI/9b8We FIV4vZHYzMaqcNbx0pLYY8K68iXqIo5778hmeyaAF+k3PMl+65X05MVTSB0bOXzcRpTfAv CgOBgwc2ZX6izE2VqWlMQsgRI/VqUmqEpBFDQsY+wg29+Y4hpsuJ+0Sc8VBfq0ZT0rWEc6 lnEIXsws4JtVJ/A2FH3L8m0DQHLCM5rKpyj/YvoWpAlBhdw+182MDOhF2M9gUNsFAPUtkg EkZptdYk0FyR3fZKWIwv12eMM25gHKwxlKvW5m53ME72YsSRShD4Z0SV4aHvJQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694103194; a=rsa-sha256; cv=none; b=H21VUp+taLOA3lrTP3W+c4JH/jXfINLtTX6C8MIdWpdDi5trFWWVglJ88GvvDN2c5iEOL6 lUxIa8f629rBqocRMt7x6jPtPXXIrtNeLr6MPA+E0BgrXz6irHEuF8YFqR0arkwE9Qfd6m eFpWeFl3jwUR9VP6drnenL4/OvhA33uSVuWN2dvh4QyhxMY1kBEjbemQwiSg4h1fa2a/W4 Cc7Ni3EC1hOTvWXghvJvHJKeNY+BMEFfvYCqM0hNBNt3lRs0GqZTj0IHa8QdHg2J/BS/cN +OxnJPa3LQ/kECj6rafXROCYytpk8UktfGU922pZFN5YbQig2dwOeuz6lgZVFg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debian.org header.s=1.vagrant.user header.b=ojFZIBSC; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeHca-0006eE-1F; Thu, 07 Sep 2023 12:12:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeHcY-0006Zx-JR for guix-devel@gnu.org; Thu, 07 Sep 2023 12:12:42 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeHcV-0006JP-NZ; Thu, 07 Sep 2023 12:12:42 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 3BD441AD30; Thu, 7 Sep 2023 09:12:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1694103153; bh=L/hhKFVdb2WDd58h0nx0Afe6e/oIQXzKqVCMcikYklE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ojFZIBSCq/YqANs8pxhEMP6D3kADeKpVq0aXLqvCTel/hO40oyhdjGfhE5zANutVQ 5RwG4zFY1+9cCNe5NT4BgWyYmsFkCYEwUrUKhsJZQmklllX044yVLXVa+z+OIleJvo L39IRGDN+gpxTdmwopdVwuhl1OW6vYG0276OEZq3Bt1i8GisESDtHnPyPf76nnka09 UWWYGFDp2WVzallHT+vSzvKws0mkLR6xKif0WZQrN06y9ZhNaZatFfnOCXgXO+lehj J0gMtRghdmJwI1O5pk/ZBCJueVZ/y5t12G6DQrfknuFFGHocS5nWyOJEac4lAI9NxK JA7H1bX8A4Nig== From: Vagrant Cascadian To: Giovanni Biscuolo , Maxim Cournoyer Cc: guix-devel@gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [workflow] Automatically close bug report when a patch is committed In-Reply-To: <87jzt2feq6.fsf@xelera.eu> References: <8734zrn1sc.fsf@xelera.eu> <87edjb5le5.fsf@gmail.com> <87jzt2feq6.fsf@xelera.eu> Date: Thu, 07 Sep 2023 09:12:29 -0700 Message-ID: <87y1hikln6.fsf@wireframe> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=173.255.214.101; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Spam-Score: -12.92 X-Migadu-Queue-Id: 8666831FDF X-Migadu-Spam-Score: -12.92 X-TUID: hOZnXHtkl03h --=-=-= Content-Type: text/plain On 2023-09-07, Giovanni Biscuolo wrote: > Hi Maxim and Ludovic, > Maxim Cournoyer writes: >> Giovanni Biscuolo writes: .. >>> When I asket I though the best way would be to scan for a string like >>> "Close #" in the commit message (the committer should add >>> such a string) but probably this can be avoided: the bug can be closed >>> when a patch is committed to one of the listed official brances (master, >>> core-updates, etc.) >> >> You mean by simply matching the subject? Maybe that could work. > > Thinking twice maybe it's better to add a "Close: #" to the commit > message. Sooooo... I maintain the guix package in Debian, and want to make sure that whatever bug-closing indicator guix upstream uses, does not end up triggering when I push new upstream versions to salsa.debian.org ... and start incorrectly marking incorrect bug numbers on bugs.debian.org that were meant for debbugs.gnu.org. Currently that is: https://salsa.debian.org/salsa/salsa-webhook/-/blob/997412ad4b1d89fd3227d5409471bdf71abcf863/helpers/bugs.rb#L19 SCAN_BUGS = /Closes:\s+(?:Bug)?#(?:(\d{4,8})\b)(?:,?\s*(?:Bug)?#(?:(\d{4,8})\b))*/i "Close: #" is a bit nervously close; I could see a stray typo of an extra "s" triggering the occasional very annoying problem. I am much more comfortable with the "Fixes" convention of: Fixes: https://issues.guix.gnu.org/NNN So, while I cannot insist here... I can plead a bit... and a namespaced URL is kind of better in some ways anyways. :) live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZPn2bQAKCRDcUY/If5cW qp9kAQDE9zo156AyqhvxjfYMI+6NcI26YAYDMqVLt2n5AiUgtwEAhefaldJBNSTg 5cX03ne/fx8A8zJPYxwrjx9aUIpVWwQ= =ODyN -----END PGP SIGNATURE----- --=-=-=--