From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id EInpDk+rLmVhpwAAG6o9tA:P1 (envelope-from ) for ; Tue, 17 Oct 2023 17:42:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id EInpDk+rLmVhpwAAG6o9tA (envelope-from ) for ; Tue, 17 Oct 2023 17:42:07 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DB21D3C5FC for ; Tue, 17 Oct 2023 17:42:06 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=irHJoSQk; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697557327; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=m1ak/pH7O+6FmiR17Ul4YdxU03N/Y5s3KtKpugJI0PQ=; b=udBvLnyuhSKN/MvwRBpeBFlqdDd/3PejU83eRwwxTn3Pb5RNf0KeKypg21R5MaXN4ELi3n CL0hy50s/3pxYZNNSptXgTvWJ/dvePJPh9zdZC6/ocIm+vKObidi9rOxxYvT6yTkmRqbnP 7KqwI0eM1CMhuTKzKHr998QEtzgSriM+ieelesGBuRzPmiZSJ2z1oLha6jihk06yoM/1w5 TfmqQTzTkpP3NQl77wysuMsDxa3ZzDxcRVk2uo5b9OsISwjHZlqSdT3p20xaQJ+fmbYj4o nDQitLbkXuEY9ksfLhvd4dA1BCuUmnPSbsJ2I80xVslsYybEnTMkCnCrbffbJQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=irHJoSQk; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697557327; a=rsa-sha256; cv=none; b=UbjA7RjErqK18ViWPI/5IwoIw70Jww0IGgY6LgQDIqrDCpFTfcEzLESAtL6Td8XsVfsPf5 JWGOUNNnaE9sYcR309obOYX5ham+TgcYvX6cL4FtOW819nPrf6YdcQMtTiikuCAwngEaN0 THkVii9jQkaLYvNG/oRvSM4MqQY9cN47xGHvn/lWhcnh2Yef3s5CxFPmxE9MUkISF4BM/x 3b1R5YMSdXKKjoP2N01wDgD3nb/ACs8g16aALgpXay7waO0QFmjp2RFxehQrwqgsAUvpFJ b09uzjlawFmJ/NpF4OhzgXkA/Xo7o7mAuXBGPhHX+YPZC7zUUNlI4Fhkl5f22g== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qsmCS-0000bt-2c; Tue, 17 Oct 2023 11:41:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qsmCP-0000Yk-8C for guix-patches@gnu.org; Tue, 17 Oct 2023 11:41:38 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qsmCO-0001aX-RT for guix-patches@gnu.org; Tue, 17 Oct 2023 11:41:37 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qsmCo-0005Ak-8Q for guix-patches@gnu.org; Tue, 17 Oct 2023 11:42:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66576] Request for merging "rust-team" branch Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 17 Oct 2023 15:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66576 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Efraim Flashner Cc: 66576@debbugs.gnu.org, 66553-done@debbugs.gnu.org Received: via spool by 66576-submit@debbugs.gnu.org id=B66576.169755730619855 (code B ref 66576); Tue, 17 Oct 2023 15:42:02 +0000 Received: (at 66576) by debbugs.gnu.org; 17 Oct 2023 15:41:46 +0000 Received: from localhost ([127.0.0.1]:60860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsmCY-0005A8-CK for submit@debbugs.gnu.org; Tue, 17 Oct 2023 11:41:46 -0400 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]:53645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsmCV-00059s-WA; Tue, 17 Oct 2023 11:41:45 -0400 Received: by mail-qt1-x82c.google.com with SMTP id d75a77b69052e-4194c3cf04aso40114871cf.3; Tue, 17 Oct 2023 08:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697557272; x=1698162072; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=m1ak/pH7O+6FmiR17Ul4YdxU03N/Y5s3KtKpugJI0PQ=; b=irHJoSQkNjOf9L2GW1wfCOZQJVGT6WLtpT4XTfgBIhqT2mPOeDhf/bR8EHCnyZqsg6 +OOLyP8bJRu3/gPIrv15ipdtwLSXlOVLdo+WsqxmutrVljBDV3DMH45TLkH+5jbZJt5a J0jz4uarYXANyLbEBbq9HF7Xv36mrLfYMl9HTJe42rABaQeuxava6QTh3eRacNZMnGya 4q622e76ZTzN/7TCt8g4aaX8T01mKtD2xzUTI/y7EE3+dgyflt0MZnC2LtpGLdVZgRV9 eq9cNshv7bS6tEMrT+mwhaKLxrHcBJLJ6TBYK/DUjvNTjcRTIJu3GJJGBkA9CECJhG4y NG8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697557272; x=1698162072; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=m1ak/pH7O+6FmiR17Ul4YdxU03N/Y5s3KtKpugJI0PQ=; b=t4SjdgR9OGFbtg6NBJTTemx0Aua8KOjThaGCt1je44igjDhdVHV1q1LoUfLQaDKz9X s92Z7QYLHtU7yVKJjawlhAZjxqQmksrZRZW/jhxN4yFEf/SOYRth+sISeY6JjkJl70Zh IAFWdvg/IPEA7f+7+saV4YbH+fjJgD9crkGcIT6GgR2hZNnJ6UgoyvKWi4mvbmOl5Ovy UmqsVZKfB6CLtxLoSCQ2sR5ykD90afFkyyBqLIRg5rtclNCtGVM+X1rdbPgXhG8/T803 XVmjX6xz7dioRJHSCJm2NdwYHz0SsV/6TrD/JW2L9Y3rkQ9L2l3VTz1e7BNlcQcVEaVC KAAw== X-Gm-Message-State: AOJu0Yw1Hb0Ct6i6YdTi2rO1eYIW6AbTgjDeDdMNIaQhLHzZcj0xaerN 1QZnRNkUxI01vZm/W5cDZoKEtRliaHPnUw== X-Google-Smtp-Source: AGHT+IH1U367kvmxWLvg9H9TCVinV412MxsRCOlUxHRhASOcDop3PFqSsLayOAumTSMsgz4Jt38aGA== X-Received: by 2002:a05:6214:d05:b0:66d:25f9:13ad with SMTP id 5-20020a0562140d0500b0066d25f913admr3106720qvh.39.1697557272624; Tue, 17 Oct 2023 08:41:12 -0700 (PDT) Received: from hurd (dsl-155-177.b2b2c.ca. [66.158.155.177]) by smtp.gmail.com with ESMTPSA id n11-20020a0ce94b000000b00647386a3234sm645634qvo.85.2023.10.17.08.41.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 08:41:12 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <4D6214A4-E59F-4166-B4D0-2CCCE42F5DB4@flashner.co.il> (Efraim Flashner's message of "Mon, 16 Oct 2023 12:30:12 +0000") References: <4D6214A4-E59F-4166-B4D0-2CCCE42F5DB4@flashner.co.il> Date: Tue, 17 Oct 2023 11:41:11 -0400 Message-ID: <87y1g1tfxk.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 2.86 X-Spam-Score: 2.86 X-Migadu-Queue-Id: DB21D3C5FC X-Migadu-Scanner: mx2.migadu.com X-TUID: XPe/q/mWmUy4 Hi Efraim, Efraim Flashner writes: > IMO rust-team branch is ready to merge. We've updated rust to 1.70, > librsvg to 2.56.4 and many new and updated packages. We've added a phase > to the cargo-build-system to fail if it detects pre-built files and > we've set the cargo-build-system to skip the test phase by default, > allowing us to make sure that the packages have the correct inputs. With > these changes I've gotten 100% of the packages built using the > cargo-build-system to build successfully. This sounds good except I don't understand how disabling the tests by default help to "make sure that the packages have the correct inputs" ? You've explained the rationale here: , saying we sometimes use a newer Rust than the package tests are expecting; how does it work in the Rust world? Don't they always build even older versions against the most recent compiler? What about the test suites then? Are these not typically run by users/distributions? For one thing the 'guix lint' command would need to be told that cargo-build-system has #:tests? set to #f by default to not warn without reasons that '#:tests? #t' is unnecessary. -- Thanks, Maxim