From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id wH3mOm6IjGXcawEAkFu2QA (envelope-from ) for ; Wed, 27 Dec 2023 21:26:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 2FJDN26IjGW3RAAA62LTzQ (envelope-from ) for ; Wed, 27 Dec 2023 21:26:22 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=HMlojZdC; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1703708782; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=5cVuvXeCzi2m8XPyZcRGoMEkGT2SyvxYbd/czJI0Ljw=; b=a4YwpYa4wequnkGlQXJzkiv2HQw/4w5pKoyq0fduj+8/JJ2FTsnN5myOUKIPQb+iIXg2Kn SUuI28YWB/171hOgsYomGjDlHGJK+FijvNDWpndSNvrG91rU3zgcbd0lKD6TCFWtMkHDXV WLibekwXc58UsBpB3yTnYs/TLNn5MxEAvhvU4NcxFQaOUhnfLJj43w1Dfc+7P8Vv/pbO1G IO+58TC8Cf2d+JZKy51kHzAJoTvRnLh7MJJxyKOa7iD3O49TbeNYTxXPw/9KwHPr1IS3Ws X3O0sR43pvIQjx4LSfXcO21GJuOxPJyj5TFbGIionsjP35KAFaU4rJDeAGChzQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1703708782; a=rsa-sha256; cv=none; b=IVgZlmcu+N22Wk2SFLTvhwad2EYvORvCX/kXQWgoN9ZIT5rqcmY17GmELS7zi4luyvEOlH j76EFUkodvicnvUuRMUA8c7mJN/OQzHeTSKEfvqq5lDNwGxX2wPqnYgId54L17V/Gf74ZY fuhYuw63gRCTmMsvPD6YVe0YQLDRpruOXRD+Z0OjXyzxB0C7kQnC4O7ReWoY4o5oDJHxBT CRQOiTumdSOeIWQXgh204Arr8Z8p0V33ELvtcO/WiJvTk4SKcZPEadCTK9bof3jjNA9ew9 B3xeYXRrA8J1K9s48ISwevz7f4bX9IdXyI8NOTLufivTi1N2paOuPzJd1HkwHA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=HMlojZdC; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C616919A1E for ; Wed, 27 Dec 2023 21:26:22 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rIaTe-0007qR-ET; Wed, 27 Dec 2023 15:26:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rIaTc-0007q9-4Q for guix-patches@gnu.org; Wed, 27 Dec 2023 15:26:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rIaTb-0000mm-St for guix-patches@gnu.org; Wed, 27 Dec 2023 15:26:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rIaTa-0006P3-76 for guix-patches@gnu.org; Wed, 27 Dec 2023 15:26:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#62153] [PATCH 4/5] guix: pack: Build layered images. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 27 Dec 2023 20:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62153 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: Josselin Poiret , Simon Tournier , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Ricardo Wurmus , Christopher Baines , 62153@debbugs.gnu.org Received: via spool by 62153-submit@debbugs.gnu.org id=B62153.170370874224586 (code B ref 62153); Wed, 27 Dec 2023 20:26:02 +0000 Received: (at 62153) by debbugs.gnu.org; 27 Dec 2023 20:25:42 +0000 Received: from localhost ([127.0.0.1]:37802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rIaTG-0006OU-0R for submit@debbugs.gnu.org; Wed, 27 Dec 2023 15:25:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rIaTD-0006OG-Jl for 62153@debbugs.gnu.org; Wed, 27 Dec 2023 15:25:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rIaT6-0000j1-7Y; Wed, 27 Dec 2023 15:25:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=5cVuvXeCzi2m8XPyZcRGoMEkGT2SyvxYbd/czJI0Ljw=; b=HMlojZdCZWuklz43Gpc4 xYAYtqagnWMlt60Oc6vt+F/remuRuh99yXBVX4yEgrhZW7lCViMZhaHefKJlGuJlo+zooREGsvnY1 OAI/S+zJowjxcC0Ol7BAUMGQk2MlSfHkZixXdB8rVPSmwHWR/OpEVmBvpa5bcVBHmCcS7Bghj4KRI 0zU6zgPXaLjx+Z6Je/l9gKYpP2NhvJUAztsua7vt5GfLMRcWJNpSD12I9O3HcPsYKD4pNgzeNJ7FF wSkd4mv4bvexCsTSMhmWF21/14U9wefdXZdHkbfeTlYd5j0XWcYiDtkGRnT8vxj0XQgOahQKbxvCE 0hJEUv9p6bNMOg==; From: Mathieu Othacehe In-Reply-To: <77bae2565cb5506342028896e1a45c757f3bad51.1703556298.git.go.wigust@gmail.com> (Oleg Pykhalov's message of "Tue, 26 Dec 2023 05:18:56 +0300") References: <77bae2565cb5506342028896e1a45c757f3bad51.1703556298.git.go.wigust@gmail.com> Date: Wed, 27 Dec 2023 21:25:02 +0100 Message-ID: <87y1df4cm9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.45 X-Spam-Score: -5.45 X-Migadu-Queue-Id: C616919A1E X-Migadu-Scanner: mx12.migadu.com X-TUID: G6GI4dM26QEG > +If MAX-LAYERS is not false, the image will with many of the store paths being > +on their own layer to improve sharing between images." Same comment as in previous patch, "many" is a bit vague. "the image will be splitted in up to MAX-LAYERS layers" or so could work. > + (check (gexp->derivation "check-tarball" > + (with-imported-modules '((guix build utils)) You could rearrange as: --8<---------------cut here---------------start------------->8--- (check (gexp->derivation "check-tarball" (with-imported-modules '((guix build utils)) --8<---------------cut here---------------end--------------->8--- to reduce the indentation of this block: > + #~(begin > + (use-modules (guix build utils) > + (ice-9 match)) ... > + (string=? (string-append #$%bootstrap-guile "/bin") > + (pk 'binlink (readlink bin))) > + (string=? (string-append #$profile "/bin/guile") > + (pk 'guilelink (readlink "bin/Guile")))) Left over pk's? Thanks, Mathieu