From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id cBMcNh5wk2VzaQAAkFu2QA (envelope-from ) for ; Tue, 02 Jan 2024 03:08:30 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id mGyiMB5wk2VpZAAA62LTzQ (envelope-from ) for ; Tue, 02 Jan 2024 03:08:30 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=BQCWGQLp; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704161310; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=zBFJcWHj2AeuAmkMF8eCwFNTZxc4qasEvu3iIKIi9Mw=; b=DUnRjj3TpEN3cwFUPZTYGyJIWnnN20KdDocJYGmda/UJkljC8QMFNL6LIqeBKv9dF+8Oa3 D4dPJjZOySuaxyBUGY2jpllMd8e2um9uMuH5GLXwY/U1ULjqhgbmt1pEuIIP8Is/oIRxmx jc6h8RizONIHu/LVmHmGlTVCZGEtR/5pVaIJ+5DWylPhQoQ/VCZXKN9ZGLy0ptQK1CEGs5 Y3sQ5G1UrhNthfWpATNAGJ1Lc/LEsxWfvNlDyjKMNeDzrA8ZUBQ+hrXKDF7+VRtW2EI0i/ UgOY1UpPd9bvk+RysKDht1SaUa37Ci0rZ236Anap5xyAnZM7dXmJgZfffvH/BQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704161310; a=rsa-sha256; cv=none; b=OhDZ5K0+rz03qngnOO3dJxPdWZRkM/gzj6LwbLgc0p+vetibG2S98mPWv68Dado83sh2wv b/GAB5vAJ4hUh7seyYG5WYEHy4BT1k6MxUO65ie+xVx8TyNoQG9wDjW5Kn1eWz73pht56r sVNmjx0eGGGvXK5CPxUjccfv0bVrWClAf4UyxIjJSddjTF41jsfXYh1yjWwFXOzT1QxRGc QsQCtx9NA3FfGiCNi+E2SzkiQU+Ow0hQEzWgqH/VI4t5PXKmIeCh60nhX8C7fXJP8g0kSr VGn3HeiWp6X6XtySv2SGkGnUgtp8wq++UgWvIJ4ip7GesqIl+sKNvN9/KPuRJQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=BQCWGQLp; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A654B3B6D0 for ; Tue, 2 Jan 2024 03:08:30 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rKUCP-0006j9-LC; Mon, 01 Jan 2024 21:08:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rKUCG-0006i3-Bi for guix-patches@gnu.org; Mon, 01 Jan 2024 21:08:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rKUCG-0008RW-1y for guix-patches@gnu.org; Mon, 01 Jan 2024 21:08:00 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rKUCH-0002oG-QS for guix-patches@gnu.org; Mon, 01 Jan 2024 21:08:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68180] [PATCH 1/4] gnu: emacs: Add awk, find, sed and sh to PATH wrapper. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 02 Jan 2024 02:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68180 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Tropin Cc: 68180@debbugs.gnu.org, Katherine Cox-Buday , Liliana Marie Prikler Received: via spool by 68180-submit@debbugs.gnu.org id=B68180.170416126910773 (code B ref 68180); Tue, 02 Jan 2024 02:08:01 +0000 Received: (at 68180) by debbugs.gnu.org; 2 Jan 2024 02:07:49 +0000 Received: from localhost ([127.0.0.1]:49104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKUC4-0002nh-Sf for submit@debbugs.gnu.org; Mon, 01 Jan 2024 21:07:49 -0500 Received: from mail-qk1-x730.google.com ([2607:f8b0:4864:20::730]:60566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKUC1-0002nR-VZ for 68180@debbugs.gnu.org; Mon, 01 Jan 2024 21:07:47 -0500 Received: by mail-qk1-x730.google.com with SMTP id af79cd13be357-781600ab3d8so430567985a.0 for <68180@debbugs.gnu.org>; Mon, 01 Jan 2024 18:07:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704161258; x=1704766058; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=zBFJcWHj2AeuAmkMF8eCwFNTZxc4qasEvu3iIKIi9Mw=; b=BQCWGQLpxeF9rBO8fNjZMMxboamIEzXWTey8LoA87xT2Z4h7pMs6+5I8C0cCKhmN6c AIlG/Xop0OSaiFY4/xqm1V/RPmJv+Jmke2wqmtwrQZWgBMVlhUKSrToxDGXKMZTPL2wR VqakZvlsLDhWxMw+mEWxJhworXo2sS3IgazOtoYRZH3d5CmYTxRaHS9U/9Epl7JYyPr5 aho1DedPDHPkhgdxRZU8m8GRbXpWcSL/P1vdeGR2WBnSO6Ts6hHP93+Cy4amC15Q/GiC FQyqzFQqCpl1n8ELs+43Nc8x9iuyNHIOxP8wksAOWjovt/qgKV6bCZcMEY0RRFFKl2yK 9buQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704161258; x=1704766058; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zBFJcWHj2AeuAmkMF8eCwFNTZxc4qasEvu3iIKIi9Mw=; b=l5XttVPUdfah+VNpFrdpo9vcwW3OmU1JD21lnGmT6H0rKMhXbfVE7pTpH3LaikrHxg pD5coJ1FawY2bwaoSOSqcNzL/+gUa+tzMUC772xDdflTzv4D+0Qh9yUb1ogph7vVF3Nj NqZilWoxbw+GrEG1vn1kxa6dmHC/G5oWLOJUrUEKZ6HNc5rRi+xwu1LkHt5ibQL670vT LYxuPqQdpFxZ4wKNvQcWkV0IT58wyNgl+5btNJqDojCQuZF0RR6TWai4LV2Ai+lE5HqM ZoFrID5oDqz/nDZUffexnHXd/cbokdDNejYyUtN7GDV+ya1QllCz/RS4w7wLOB0PPHKs z/BA== X-Gm-Message-State: AOJu0YxGr235L3WVH5o/z9mtjlXu8a3ghQnh/8gjOgZcBprS+CbycRoe +z3GgZbr+S84uUL1xRHOOeCe8N8P53g= X-Google-Smtp-Source: AGHT+IHUcwpJln0oogigOOXAF/8/4kQRvgtotkIgA+Cf4iOwB3EwESs5KR3CVMl2/m0wknHWRHT8qg== X-Received: by 2002:a05:620a:3915:b0:781:314b:3605 with SMTP id qr21-20020a05620a391500b00781314b3605mr24057287qkn.56.1704161258261; Mon, 01 Jan 2024 18:07:38 -0800 (PST) Received: from hurd (dsl-10-141-187.b2b2c.ca. [72.10.141.187]) by smtp.gmail.com with ESMTPSA id x9-20020ae9e909000000b007815c99209csm4677415qkf.131.2024.01.01.18.07.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jan 2024 18:07:37 -0800 (PST) From: Maxim Cournoyer In-Reply-To: <87plyl4ie1.fsf@trop.in> (Andrew Tropin's message of "Mon, 01 Jan 2024 10:33:58 +0300") References: <6b33be06b0ea3a9aa4e29b8c8a958150cc05a7e9.camel@gmail.com> <874jfyoz84.fsf@gmail.com> <87plyl4ie1.fsf@trop.in> Date: Mon, 01 Jan 2024 21:07:36 -0500 Message-ID: <87y1d8o5cn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.79 X-Spam-Score: -2.79 X-Migadu-Queue-Id: A654B3B6D0 X-Migadu-Scanner: mx11.migadu.com X-TUID: Yhyl5fXex5lC Hi Andrew, Andrew Tropin writes: [...] >>> We already have a phase to patch in the real path of /bin/sh where it's >>> used. This appears to be an odd case that's missed. >> >> I appreciate exactness, but it seems fragile to rely on nobody adding >> new references or someone catching them as new Emacs modules get added >> or changed :-). >> >> My reasoning was that since Emacs already depends on bash, why not >> ensure it'll always be found on PATH, by wrapping instead of >> substituting. >> >> Does it make sense? > > Yep, make sense to me. I also find cases from time to time, when some > binary or another isn't found by some elisp code. > > However, providing those binaries via PATH can make some code or > programs to work, when executed from inside Emacs and not to work in the > environment outside, which can be really confusing in some cases. > > A simple example, imaging we have a script: 1.sh, which contains: > sh --version > > This one will work: > guix shell emacs-with-bash --pure -- emacs --eval '(shell-command "./1.sh")' > > This one will not: > guix shell emacs-with-bash --pure -- ./1.sh > > That said, the idea of patching all the pathes to binaries seems better > to me. I'm not sure if I got you correctly: do you prefer to wrap Emacs with the tools it needs in PATH, or patch the references exactly in its source, as Liliana suggested? I've tried the "exact" patch suggested by Liliana in v2. I tested that reading a manual page was possible in a containerized environment still worked. -- Thanks, Maxim