From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id qKbNEDUexmVmyAAA62LTzQ:P1 (envelope-from ) for ; Fri, 09 Feb 2024 13:44:37 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id qKbNEDUexmVmyAAA62LTzQ (envelope-from ) for ; Fri, 09 Feb 2024 13:44:37 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=lassieur.org header.s=fm2 header.b="U9BJy/At"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=cD0WMyH1; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707482677; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=GNTW6QyiSo+/nTp1n+ej7s0Fjz9vF4xeiCgXw6ciXMw=; b=a7rt6VHQ3kkJg5V6Q+ndYOyokPkmZJj0xW2Di3pZT3hipyULIOR5WFM+fxMBg6Gz78GqmI WlnP5yLK5ljvJULHc6iZjw0FAe0IcFVfMdkoXC8B2nteeaqJLbFUJyCwIYvr4sxuB9IQNk CQs8bfA+E/7W3AZb54V+BreYyeD8k/tf92bWxHs02w0YpuyyFrb855tviszc0fgFkRBva6 8zg41Jok0LdKoUnRcEJ86pLCGojG7q6b6pDWWZecBUImYJmVEsyx+oLPN5MLcOhxqu5LbK GWlazA7GLDn/EsqZ/6d0mqApK4bOtdko9sWa+rVaAihiAiOHoIbWUBbfDFewmQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=lassieur.org header.s=fm2 header.b="U9BJy/At"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=cD0WMyH1; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707482677; a=rsa-sha256; cv=none; b=XZtbP1IfrRpddGMCvhDLjv3as2KsAvvE6CUXpl8fJUuwPibWnDv1A+DnpFaevnN82wwSjA tPJFhhZjfr2xMxFOjUctZh9WInl0uU7sqgBQWbQvlW/8uMb7FAOrX4zTREbKNQba1BMdS/ 5X+u0xGT6xme5HT7hqaP3jvtxOSrzuyzAMte/S6fRtOySeHUg4EIXtHqRrPTuF85wMAljv DSXqT7osN28z/6YUZu2ZPNmDn4Vn99u1ai2MvnaqOu4Uu+vLPgWi9MdpoHOFjfuAoVuLuq iL4epMaoxXV8cfmHNX00Vk9zaROrvqqzq3D/zl2XZ4rR4jm2DnqXQHeMlwVy+w== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E9FA61337E for ; Fri, 9 Feb 2024 13:44:36 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYQEZ-00029X-Qu; Fri, 09 Feb 2024 07:43:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYQEX-00025G-2d for guix-devel@gnu.org; Fri, 09 Feb 2024 07:43:57 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYQEU-0003Zv-KK for guix-devel@gnu.org; Fri, 09 Feb 2024 07:43:56 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 6B2EF5C0094; Fri, 9 Feb 2024 07:43:49 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 09 Feb 2024 07:43:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1707482629; x=1707569029; bh=GNTW6QyiSo +/nTp1n+ej7s0Fjz9vF4xeiCgXw6ciXMw=; b=U9BJy/At7SZApT/n+akLjs0djD I+cWzLXxoUmYEh4QO/baW5bib53a+98TnRpidlD9XIV9rp49WHb+FOA4bvjwEvgr cL28A++zkVHnTxbWcYDUY9BTaMD36NjIeyAD8dCyzJoed6yXW7uf8cfBrmATqT0T kLepDk2r0XcIuWP4uqa3eOhgzg8RTkduXzVQ++t9D/ocu3pk0z3r+Sd3rmRZIV2x QDG7oytL2YwqaZjR+sn1opUTNXxTrXBZn7YcDZ5DB7YyhSCfVgvozIqnD44NqDTW BZxgPEDAuu6ttAxrYDV/MXIsZD8jiN/1m5Ia5/t4CR9rNE/QazLMpucrktug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1707482629; x=1707569029; bh=GNTW6QyiSo+/nTp1n+ej7s0Fjz9v F4xeiCgXw6ciXMw=; b=cD0WMyH1gezc5dk6HSo9kDXghPADOS9B2a5K26IM3Z5u 4oGVoDUJCoFiHxCnTjI5FKbojEW8EkEqQoHHNFHZlo40/v2SDAaSwoPZgWoWutxA IyxLOCBUzIphj0VDbp6wHkUOhou3sKusPdY5NsrDhcB6WX8hdwrhRuKrO1Bjd1PM wcvWvgwbcovHMrgMHxa3Ph99JXIRtIvbXyzxJ7XNexQTnqVXM9xsp7zTAo4fe6dC Hv71eTjvpH00qmohJycz3KqXghnRhDCBnHdhpF+eephi63ojX/9IQqD7NvnRWLzd /KHeN1iYT73FKjdLR5PecNExAucuJcQUIKE2SiYM+g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrtdeigdegvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefujghffffkfgggtgesthdtre dttderjeenucfhrhhomhepvehlrohmvghnthcunfgrshhsihgvuhhruceotghlvghmvghn theslhgrshhsihgvuhhrrdhorhhgqeenucggtffrrghtthgvrhhnpeevjeeljefhledthe dukeejhfekuefglefgtddvudetveeljeekudevtdfhtdfgffenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegtlhgvmhgvnhhtsehlrghsshhivg hurhdrohhrgh X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 9 Feb 2024 07:43:48 -0500 (EST) From: =?utf-8?Q?Cl=C3=A9ment_Lassieur?= To: Christopher Baines Cc: guix-devel@gnu.org Subject: Re: QA is back, who wants to review patches? In-Reply-To: <87wmrddheu.fsf@cbaines.net> (Christopher Baines's message of "Fri, 09 Feb 2024 10:44:11 +0000") References: <87wmrddheu.fsf@cbaines.net> Date: Fri, 09 Feb 2024 13:43:46 +0100 Message-ID: <87y1bt6c59.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=66.111.4.25; envelope-from=clement@lassieur.org; helo=out1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.70 X-Migadu-Scanner: mx13.migadu.com X-Spam-Score: -6.70 X-Migadu-Queue-Id: E9FA61337E X-TUID: EA4gies00I59 On Fri, Feb 09 2024, Christopher Baines wrote: > After substitute availability taking a bit of a dive recently, the > bordeaux build farm has finally caught back up and QA is back submitting > builds for packages changed by patches. > > QA also has a feature to allow easily tagging patches (issues) as having > been reviewed and ready to merge (reviewed-looks-good). You can do this > via sending an email and QA has a form ("Mark patches as reviewed") on > the page for each issue to help you do this. > > I'd encourage anyone and everyone to review patches, there's no burden > on you to spot every problem and you don't need any special > knowledge. You just need to not be involved (so you can't review your > own patches) and take a good look at the changes, mentioning any > questions that you have or problems that you spot. If you think the > changes look good to be merged, you can tag the issue accordingly. > > When issues are tagged as reviewed-looks-good, QA will display them in > dark green at the top of the list of patches, so it's on those with > commit access to prioritise looking at these issues and merging the > patches if indeed they are ready. > > Let me know if you have any comments or questions! This is great, thank you.