From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 6OmGBjrZyGW7LwEAqHPOHw:P1 (envelope-from ) for ; Sun, 11 Feb 2024 15:27:06 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 6OmGBjrZyGW7LwEAqHPOHw (envelope-from ) for ; Sun, 11 Feb 2024 15:27:06 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b="P/sUyDzK"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707661626; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=AenQgpY35lvCmDooWr7ookt3UfSkANyVbujvgW3cUJM=; b=G3HH2ovC6GcSlsc4DZM6C+IFBzb964Ygku7scep0XGN8pb2CUZ5FXjh/zypm+wUANoqDiu 3AKWEAzDrMI0iDcfk4bqGueDSewati2T/ev+qsq4iHYNUNbz/76MPtKuBR3iUY8KqrWhcu bp29mRgPCyhGK7KI1iTb+WIwZf1lPZpWiV0FbRxLzceFp/4YfKjnoCtnS2nJIt/TaKjBd9 KDUthXaXY8iwzBdCXG1Ex9QcYogyfyI9z1d64gJo4cBgxt2NkbLTicMzkxEpIPnPrCCO8q f5AL372yNfhLeyjnHaNjhGA4RI8lNXqo5AWtVQ7474KB4GQvYtXGbRgiYOqc+A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b="P/sUyDzK"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707661626; a=rsa-sha256; cv=none; b=OSsvzGaZX0Fp2Z0IdMSkX3jxpV53nj6VChq/bvK8RTVkzhsdN+LnycbPm9v5jRgUMCLhUU NOLNwMJEfXzefiwQ9tXl0LCjvaq179GBOa9A/gbL3XQhVkllhLK5hkOICgPOkFpD/p1pBI uG0xFBRyVfD05+u5GO25JZItbVDUodOpN82rGCcVI0SEQ+tXLkPyhO4WJQ9PLB8jnr+ykU NzVYsFbL9ySy6U/cY1hHgr43WxOAfdRGHcgOmDyBMJOv5WDf/JLNNPOGvHkfIkPYNBqZLf rIJRdBOYbvzm7yMAWCyocn4yUc3Jnak9hpjCFKI1geNYf/fOE125IRo0tkglZQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0A39116308 for ; Sun, 11 Feb 2024 15:27:06 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZAn9-0002RY-P7; Sun, 11 Feb 2024 09:26:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZAn8-0002RK-Dw for guix-patches@gnu.org; Sun, 11 Feb 2024 09:26:46 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZAn8-0002gO-6E for guix-patches@gnu.org; Sun, 11 Feb 2024 09:26:46 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZAnO-0000ve-Cw for guix-patches@gnu.org; Sun, 11 Feb 2024 09:27:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69043] [PATCH] gnu: go-github-com-charmbracelet-bubbletea: Delete examples. Resent-From: Hilton Chain Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 11 Feb 2024 14:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69043 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Troy Figiel Cc: 69043@debbugs.gnu.org Received: via spool by 69043-submit@debbugs.gnu.org id=B69043.17076615883487 (code B ref 69043); Sun, 11 Feb 2024 14:27:02 +0000 Received: (at 69043) by debbugs.gnu.org; 11 Feb 2024 14:26:28 +0000 Received: from localhost ([127.0.0.1]:50114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZAmp-0000uB-SA for submit@debbugs.gnu.org; Sun, 11 Feb 2024 09:26:28 -0500 Received: from mail.boiledscript.com ([144.168.59.46]:37944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZAmm-0000tx-RM for 69043@debbugs.gnu.org; Sun, 11 Feb 2024 09:26:26 -0500 Date: Sun, 11 Feb 2024 22:24:47 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1707661482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AenQgpY35lvCmDooWr7ookt3UfSkANyVbujvgW3cUJM=; b=P/sUyDzK3fSMf1NvNwouCFGZVOLJdVQl59KxhoVj61f3Ki3Zq3+ZpYk6fIFBb0tW6LSVNF rdOksTYwZnnTvoPF4f5uLr1pqxT0NpMfaaUGwGzSHJRz6R/eRWSKJx7BQgwwWtJiKEzTZy hRiySMSyDzhvq5yHAPC1h3j5TedaXnkVjGI/RqgrlpggptM/5WfudaFHXtwF49pmH5953I DwNX+PsqFVvuFurrl/wxEDqPaxBZoU5cMxMQHBPZQHnqAzhcaBmxIm2QHFz9+yl3HtmnVX 5hLyVRQSNb63dC4DEzTai/aDAyRso3gCPFQsZIT1GfsC546T0425CbP/wnUpFQ== Message-ID: <87y1brrscw.wl-hako@ultrarare.space> In-Reply-To: <7a3b964d-36ff-4c10-b83a-be696a6332c6@troyfigiel.com> References: <87ttmf9tj0.fsf@troyfigiel.com> <7a3b964d-36ff-4c10-b83a-be696a6332c6@troyfigiel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Hilton Chain X-ACL-Warn: , Hilton Chain via Guix-patches From: Hilton Chain via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.18 X-Spam-Score: -7.18 X-Migadu-Queue-Id: 0A39116308 X-Migadu-Scanner: mx12.migadu.com X-TUID: qNndKnkl++FJ Hi Troy, On Sun, 11 Feb 2024 18:50:18 +0800, Troy Figiel wrote: > > As a note, quite a few Go packages come with "examples", "tutorials" or > "benchmarks". These prevent us from recursively building or testing all > packages, as they often come with their own go.mod file or require Go > libraries that create cyclical dependencies. These directories are not > needed for the package to work though. > > On 2024-02-11 01:24, Troy Figiel wrote: > > * gnu/packages/golang.scm (go-github-com-charmbracelet-bubbletea)[sourc= e]: Delete examples and tutorials. > > --- > > gnu/packages/golang.scm | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm > > index 163691a1e6..d917f02a25 100644 > > --- a/gnu/packages/golang.scm > > +++ b/gnu/packages/golang.scm > > @@ -10443,7 +10443,10 @@ (define-public go-github-com-charmbracelet-bub= bletea > > (file-name (git-file-name name version)) > > (sha256 > > (base32 > > - "1105cggi5fwqx69m0vrhgwx6kaw82w4ahn58sj0a81603c4yvrk0")))) > > + "1105cggi5fwqx69m0vrhgwx6kaw82w4ahn58sj0a81603c4yvrk0")) > > + (modules '((guix build utils))) > > + (snippet '(for-each delete-file-recursively > > + '("examples" "tutorials"))))) > > (build-system go-build-system) > > (arguments > > `(#:import-path "github.com/charmbracelet/bubbletea")) > > > > base-commit: 9edbb2d7a40c9da7583a1046e39b87633459f656 Since examples and tutorials are still useful for context like getting sour= ce code with =A1guix build --source go-github-com-charmbracelet-bubbletea=A2, = and when distributing source code, it makes more sense to have them as well, I'd sug= gest deleting them in a separate build phase. Thanks