From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id 8LadM4MyRmZkJgEAe85BDQ:P1 (envelope-from ) for ; Thu, 16 May 2024 18:21:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 8LadM4MyRmZkJgEAe85BDQ (envelope-from ) for ; Thu, 16 May 2024 18:21:23 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=XhVd6cCm; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715876483; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=PkV1JxOZkP/QlDIR0MYg780rgWHeEJPbkSa9pYNLZVM=; b=TLOdzFp+QkZdDsouuHZOrBDybJphvOKwtffivLndK81vTODr2Wjh0kxl/y44J7raiLSwT9 jrXlsK9WfQ5GTSnKtImNU0UOPkXYR6pXv5xLxNNAPKuGXmkgZiGrMei/mU5uRfUvpSGB3S QIivI9hInJMSzDv/zzH5ULW2gshlgC+0TSQlY0XDG06jGs+ou6BQ7tMpnF1nObYqEIRwjg 9/Cdp94uf4h7TBcT8QY5caFkEZ30S/U6Fb+dDHrJW9NVawyUDlJk3euy5qk2hCh/zRYHAr Rn+Mg6UWYlZ+1YMdu7rEnYJyvaBqjMCUbEP1COC8Z7YEcSnrJJX21zvXLZ5jzQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=XhVd6cCm; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715876483; a=rsa-sha256; cv=none; b=DOcAI2p2VeIN4AZfgphtwSbpdNFpGABmkmbenn9iv1833S83pM6OZSBoCdS5cxZRYko3E1 ObxWdARMtoAzdqzL0w7DiB47L9qDEvh+rXcnGifQDqPyfxcDABuFZ2C1k970ZsQxfhgIhS 6uRAozrsNLv8aVNtEF5i92o+GizoR7eCg31TDLaZeCsejV9K7Cau6h3UblbBZCvE3UCki0 k5EzbAAzOvdBHZd6eawHeLEGNH9KHseEp3BZZkRcQlIptojW6fTwAf/9NjXUmPoR4QBBwA dMENexpaxBjBuyP3I4WtAH+3v/NkgJJJgDAP+9H3I1bop8BOeRVMenjyYZZlXA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B27236B7A7 for ; Thu, 16 May 2024 18:21:23 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s7dqs-0005Ts-7r; Thu, 16 May 2024 12:21:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7dqm-0005Qc-LK for guix-patches@gnu.org; Thu, 16 May 2024 12:21:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s7dqm-00031j-Ct for guix-patches@gnu.org; Thu, 16 May 2024 12:21:00 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s7dqo-0000Sm-Bq for guix-patches@gnu.org; Thu, 16 May 2024 12:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70494] [PATCH 16/23] store: database: Log when aborting transactions. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 May 2024 16:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70494 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: Josselin Poiret , 70494@debbugs.gnu.org, Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , Christopher Baines Received: via spool by 70494-submit@debbugs.gnu.org id=B70494.17158764531765 (code B ref 70494); Thu, 16 May 2024 16:21:02 +0000 Received: (at 70494) by debbugs.gnu.org; 16 May 2024 16:20:53 +0000 Received: from localhost ([127.0.0.1]:49659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7dqf-0000SP-CF for submit@debbugs.gnu.org; Thu, 16 May 2024 12:20:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7dqc-0000SH-QC for 70494@debbugs.gnu.org; Thu, 16 May 2024 12:20:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7dqV-0002og-3g; Thu, 16 May 2024 12:20:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=PkV1JxOZkP/QlDIR0MYg780rgWHeEJPbkSa9pYNLZVM=; b=XhVd6cCmpdh6kNOW+bkx qHUzHheVwnB78r18AXxYEaTjHTHR5kpzwKf1xSraQCo0ngxzr8+MlE3NFLOcxhqCnT9676o+qaRRp 927QuFJfET3D3mVuQZx2jHnBDDSRyr9uwHkZaWwDPguFWYKPsFaSOLhe3BSz2TGtFfhLsl76UHP9B iBea5g9x5IE5iSH6gdXyKcyPxhuoL/KF/7B0UUKCK5ANQBXLhu+cqteBnlXd4rDPm+uw2EJPBcpo3 Nzo5L++GtLXt585jcpj//iOKuW6444DzXsKwBGztXuPwe1JZzYXeyEt7JOw/N02yfIdrpdKQWQc3c vPEb83GZuT3ZqQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <21c24e8933feb110c2e6cd5782d39adab3b66546.1713692561.git.mail@cbaines.net> (Christopher Baines's message of "Sun, 21 Apr 2024 10:42:34 +0100") References: <87bk632h36.fsf@cbaines.net> <21c24e8933feb110c2e6cd5782d39adab3b66546.1713692561.git.mail@cbaines.net> Date: Thu, 16 May 2024 18:20:40 +0200 Message-ID: <87y189919j.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -5.75 X-Migadu-Queue-Id: B27236B7A7 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -5.75 X-TUID: 2ll4Kn52abig Christopher Baines skribis: > Otherwise this has the effect of masking the backtrace/exception. > > * guix/store/database.scm (call-with-transaction): Log when aborting. > > Change-Id: Iee31905c4688dc62ef37a85b0208fd324ee67d70 > + (with-throw-handler #t > + (lambda () > + (call-with-values proc > + (lambda vals > + (sqlite-exec db "commit;") > + (apply values vals)))) > + (lambda (key args) > + (simple-format > + (current-error-port) > + "transaction aborted: ~A: ~A\n" key args) > + (backtrace)))) I would just let the sqlite exception through, which should have a similar effect (Guile will exit and display a backtrace).