From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id cI/qKYjTUWaPTAEAe85BDQ:P1 (envelope-from ) for ; Sat, 25 May 2024 14:03:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id cI/qKYjTUWaPTAEAe85BDQ (envelope-from ) for ; Sat, 25 May 2024 14:03:20 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1716638600; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=I264d5cciuy+07jjamAY2RPx21NE2I8SdQ47jFbZoNM=; b=KMrxYulpPETokrc6k3gdRqVrVaZDKcRI4XFlOjWrXqgLXJuukw0XdfpIJrk2sjGVc2rZJv 0Y2YczAHusOfv1FMLYde5UbbbyTT6UzGyMVw9Bc8zfH9yPf+Dg7p4veaAnsV7HdaEMv0Xq PKJUNIcPHnF+N2Gd6ZVAZOWCV6sw7JXIlUm2cybLH3rGRwYNhMeYvJNqJXhhlRBDO6JZn6 XyudX7dGjlFMhE6iO3mBp62vD+f2xrqnkLhMuFvoJIftuV2U7JE/nWadsIQT80bBD/Lsoa PUc7KqXyJtyKrPmmzbxkgx3rr5kkh8gP8IRQYltMjsu56az86WzD2AmzuYI+Ew== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1716638600; a=rsa-sha256; cv=none; b=m2IXQhhXMUvV2/2PfxRO38eqc/2PuNSkyfdPj3IFNQQJHnJPEgCWmsq6WXOHgiOshqxesq iBEm3BhMUyd6IPmQL9AgbjmT+4qWciKd+OX/aiaP9QQb38cjVTHd7DxxGXr/qV+A9miWjU BZjCQrHxijyeXKYgZPGg5K+zwvH8v9YwRAIjV06xHbT7EWCPvhoP9sbLkhQQRr4ka8rwbg 0GeMX66vE0/+Pzq2qUhkY9vcsmVkGi8pygk6cgxStg8Yn/Lcc8WVDizloBgKqsDvfVFAt1 moVt7h2P7NeC/AK6xnoAQ73uSMg8ZPEqFgMCsWJzzhRuu6Q+Mo3Aw06c9QreIQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 61EEA7D96A for ; Sat, 25 May 2024 14:03:20 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sAq75-0002WV-KK; Sat, 25 May 2024 08:03:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAq6y-0002Vb-6L for bug-guix@gnu.org; Sat, 25 May 2024 08:02:57 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sAq6x-0002Gb-TR for bug-guix@gnu.org; Sat, 25 May 2024 08:02:55 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sAq74-0001C0-5c for bug-guix@gnu.org; Sat, 25 May 2024 08:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#71144: Interactive prompt opened upon shepherd config file error Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 25 May 2024 12:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71144 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 71144@debbugs.gnu.org, Andreas Enge Received: via spool by 71144-submit@debbugs.gnu.org id=B71144.17166385384464 (code B ref 71144); Sat, 25 May 2024 12:03:02 +0000 Received: (at 71144) by debbugs.gnu.org; 25 May 2024 12:02:18 +0000 Received: from localhost ([127.0.0.1]:43034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAq6L-00019v-J0 for submit@debbugs.gnu.org; Sat, 25 May 2024 08:02:17 -0400 Received: from mira.cbaines.net ([212.71.252.8]:43578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAq6J-00019l-Pa for 71144@debbugs.gnu.org; Sat, 25 May 2024 08:02:16 -0400 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id AC89827BBE2; Sat, 25 May 2024 13:02:07 +0100 (BST) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 6688f8f2; Sat, 25 May 2024 12:02:07 +0000 (UTC) From: Christopher Baines In-Reply-To: <878qzy45p3.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 25 May 2024 11:11:04 +0200") References: <87sey894kj.fsf@inria.fr> <878qzy45p3.fsf@gnu.org> User-Agent: mu4e 1.12.2; emacs 29.3 Date: Sat, 25 May 2024 13:02:05 +0100 Message-ID: <87y17yf6bm.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.45 X-Spam-Score: -5.45 X-Migadu-Queue-Id: 61EEA7D96A X-Migadu-Scanner: mx11.migadu.com X-TUID: kEorYw+P1Xf7 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Ludovic Court=C3=A8s skribis: > >> I think we should change the above to log and gracefully handle failure >> to load an individual service file. > > With the change below, every service except the offending one is loaded > and started as expected: > > --8<---------------cut here---------------start------------->8--- > [ 22.450515] shepherd[1]: Service root running with value #t. > [ 22.454624] shepherd[1]: Service root has been started. > [ 22.711738] shepherd[1]: Exception caught while loading '/gnu/store/fj= is6iqpjfcnr90fy8rsg9v4j828jslv-shepherd-gwl-web.go': #<&compound-exception = components: (#<&undefined-variable> #<&origin origin: #f> #<&message messag= e: "Unbound variable: ~S"> #<&irritants irri > [ 22.711839] tants: (make-forkexec-constructor/container)> #<&exception= -with-kind-and-args kind: unbound-variable args: (#f "Unbound variable: ~S"= (make-forkexec-constructor/container) #f)>)> > [ 22.755146] shepherd[1]: starting services... > [ 22.756491] shepherd[1]: Configuration successfully loaded from '/gnu/= store/mq7y31xnjcjwjkyf6w7qiaq61g6n9f5x-shepherd.conf'. > Uncaught exception in task: > In fibers.scm: > 172:8 7 (_) > In ice-9/exceptions.scm: > 406:15 6 (_) > In ice-9/boot-9.scm: > 1752:10 5 (with-exception-handler _ _ #:unwind? _ # _) > In shepherd/service.scm: > 824:39 4 (_) > In oop/goops.scm: > 1567:11 3 (cache-miss #f) > 1585:2 2 (_ _ _) > In ice-9/boot-9.scm: > 1685:16 1 (raise-exception _ #:continuable? _) > 1683:16 0 (raise-exception _ #:continuable? _) > ice-9/boot-9.scm:1683:16: In procedure raise-exception: > No applicable method for #< one-shot-service? (1)> in call (one-= shot-service? #f) > [ 22.798737] shepherd[1]: Starting service user-file-systems... > [ 22.800361] shepherd[1]: Starting service root-file-system... > [ 22.802015] shepherd[1]: Starting service host-name... > [ 22.803688] shepherd[1]: Starting service pam... > [ 22.805372] shepherd[1]: Starting service sysctl... > [ 22.806926] shepherd[1]: Starting service loopback... > [ 22.808225] shepherd[1]: Starting service firewall... > --8<---------------cut here---------------end--------------->8--- > > (There=E2=80=99s still this scary-looking but harmless backtrace in the m= iddle: > that=E2=80=99s because (start-in-the-background '(something-that-does-not= -exist)) > throws like that as of 0.10.4.) > > Once booted, shepherd is fine and you can interact normally with it; the > only thing missing is, in this case, the =E2=80=98gwl-web=E2=80=99 servic= e, which we > failed to load. > > I think that=E2=80=99s a significant improvement. > > Thoughts? That looks good to me, the "Arrange to spawn a REPL if something goes wrong" comment needs removing/updating, but that's the only thing I spotted. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmZR0z1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xc2PBAAjgpksQf5mX5x9jbdj6ujQ4vTlhCkJS0t 1B0eiqqq0GqJxFN0dsYAxQwOHnAPi+Glm+GmbEpW9sBjS8nBb7vxHXf2ECdUZKmP hJMxOA0FIggXNU6bsdUSKVYkwK5zXsPCiAJRfUAsCLJEucdaMRiIvmgAThKrkO1M Ap0ggbXSf3uuR5Um82eB5jIoNosI77GC2egpnjSinpA2ndkPhg1mgEvBOG6Wb4TZ qlDc0mGZd3Q8Ztc+ULYMwitlxzD1VsuDH9/eATj4D+nC2SdPHY5ZeoODYBRdaPzU 7k3UZ3ghrdRxTTxhwvY/7yv/TFc9UsLrbah+v3ZRffhPskjPQsksf0p9p08khE+I m7lifaVLC1CMNsNOznvQNmvRphnIrD2Vnbqb2rjjcPsmX1qi2NWzU1vqMrq7pNxX M0ItsH2lxBoLiFM7s0AQeC+qlsO7HyFnVHhTqT7PMBAZMbL3QdfIWsHrTCIjsQzP 6BAhLoCAydEvWHQuGtg842HclygCDHLXbHGHLwm0ZOZ9o6qmOFjJPRMvnRgzYcj+ 37l0QKXJicOdYkKKgviJ9pdkYaJcOwTdeFmFDruORUOQIrt2UZA+zGDOoBJ7+Ek9 Tiyz8NXoIvfoxeumFxLcKVcekUTg/g+8NEcYVRaQi4uJ+hkyv3vh9gcs0Zjs5Qsy Rsxuihqkc5E= =7r7N -----END PGP SIGNATURE----- --=-=-=--