[bug#72173] [PATCH] gnu: chicken: Update to 5.4.0.

[bug#72173] [PATCH] gnu: chicken: Update to 5.4.0.

[ashish.is--- via Guix-patches via]

From: Ashish SHUKLA <ashish.is@lostca.se>

* gnu/packages/chicken.scm (chicken): Update to 5.4.0.

Change-Id: I448bdc25a5cb11e55c7ebb9d9e0cf1876ca958d8
---
 gnu/packages/chicken.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/chicken.scm b/gnu/packages/chicken.scm
index 8f5e8ce98d..d48a0c89c0 100644
--- a/gnu/packages/chicken.scm
+++ b/gnu/packages/chicken.scm
@@ -33,14 +33,14 @@ (define-module (gnu packages chicken)
 (define-public chicken
   (package
     (name "chicken")
-    (version "5.3.0")
+    (version "5.4.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://code.call-cc.org/releases/"
                                   version "/chicken-" version ".tar.gz"))
               (sha256
                (base32
-                "0xhdvcdwlv9vbhxh7k0fzd32ybhc7fn83y9fj48dhzp1z7c9kbf3"))))
+                "0pzcrnzkjw2sa44vy59wbygvlc3nva8zisprkdnvyrqi3jk4lp9w"))))
     (build-system gnu-build-system)
     (arguments
      `(#:modules ((guix build gnu-build-system)

base-commit: ee7e5e00bf2b9257e67d785b37efddb008c5da37
-- 
2.45.2

bug#72173: [PATCH] gnu: chicken: Update to 5.4.0.

[jgart via Guix-patches via]

Applied, thanks!
-- 
all the best,
jgart

[bug#72173] [PATCH] gnu: chicken: Update to 5.4.0.

[Ludovic Courtès]

Hey jgart & Ashish,

ashish.is@lostca.se skribis:

> From: Ashish SHUKLA <ashish.is@lostca.se>
>
> * gnu/packages/chicken.scm (chicken): Update to 5.4.0.
>
> Change-Id: I448bdc25a5cb11e55c7ebb9d9e0cf1876ca958d8

This caused a number of Chicken packages to fail to build:

  https://ci.guix.gnu.org/eval/1498240?status=newly-failed

In particular, ‘chicken-compile-file’ fails to build with:

--8<---------------cut here---------------start------------->8---
starting phase `build'

Error: extension or version not found: "compile-file"
fetching compile-file
TCP connect timeout
TCP connect timeout
error: in phase 'build': uncaught exception:
%exception #<&invoke-error program: "chicken-install" arguments: ("-cached" "-no-install" "compile-file") exit-status: 70 term-signal: #f stop-signal: #f> 
phase `build' failed after 0.0 seconds
--8<---------------cut here---------------end--------------->8---

(From <https://ci.guix.gnu.org/build/5185638/details>.)

Could you take a look?

Thanks,
Ludo’.

[bug#72173] [PATCH] gnu: chicken: Update to 5.4.0.

[jgart via Guix-patches via]

July 20, 2024 at 8:53 AM, "Ludovic Courtès" <ludo@gnu.org> wrote:

Hi Ludo,

Sorry, I forgot to check the dependent chicken packages 🙃🦆

I will revert this commit immediately on Monday when I get back.

I don't think I'll have time to look into the chicken package failures this weekend or next week.

ashish, could you send a v2 with the dependent chicken packages passing in order for this to be merged properly by Monday?

all the best,

jgart

[bug#72173] [PATCH] gnu: chicken: Update to 5.4.0.

[jgart via Guix-patches via]

Hi all,

I've reverted this commit for now.

Hi ashish,

Feel free to send a v2 including the build passing dependents.

If you'd like to me to review it again please Cc me.
-- 
all the best,
jgart

[bug#72173] [PATCH] gnu: chicken: Update to 5.4.0.

[Ashish via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 626 bytes --]

On Mon, Jul 22, 2024 at 11:04:18AM -0500, jgart wrote:
> 
> Hi all,
> 
> I've reverted this commit for now.
> 
> Hi ashish,
> 
> Feel free to send a v2 including the build passing dependents.
> 
> If you'd like to me to review it again please Cc me.
> -- 
> all the best,
> jgart

Sorry about the lack of proper testing, and lack of timely follow up on 
my part. I'll work on a fix sometime this week, and will get back to 
you.

Apologies again.

-- 
Ashish SHUKLA | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0

"If I destroy you, what business is it of yours ?" (Dark Forest, Liu Cixin)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

[bug#72173] [PATCH] gnu: chicken: Update to 5.4.0.

[jgart via Guix-patches via]

> Sorry about the lack of proper testing, and lack of timely follow up on 
> 
> my part. I'll work on a fix sometime this week, and will get back to 
> 
> you.
> 
> Apologies again.

No worries and thanks for contributing.

Keep us posted on the new version. 

I can review and test again once ready.

all best,

jgart

[bug#72173] [PATCH v2 0/2] gnu: chicken: Update to 5.4.0.

[ashish.is--- via Guix-patches via]

From: Ashish SHUKLA <ashish.is@lostca.se>

In this revision, I have updated the chicken-build-system. These
changes are based off the work in nixpkgs[0].

All of the failed dependents seem to build fine.

References:
[0] https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/compilers/chicken/5/eggDerivation.nix

Ashish SHUKLA (2):
  gnu: chicken: Update to 5.4.0.
  guix: chicken-build-system: Update for 5.4.0.

 gnu/packages/chicken.scm            |  4 ++--
 guix/build/chicken-build-system.scm | 11 ++++++-----
 2 files changed, 8 insertions(+), 7 deletions(-)


base-commit: 03062c7a9fd74d625639e1a325e9cb58d1cd74e3
-- 
2.45.2

[bug#72173] [PATCH v2 1/2] gnu: chicken: Update to 5.4.0.

[ashish.is--- via Guix-patches via]

From: Ashish SHUKLA <ashish.is@lostca.se>

* gnu/packages/chicken.scm (chicken): Update to 5.4.0.

Change-Id: I448bdc25a5cb11e55c7ebb9d9e0cf1876ca958d8
---
 gnu/packages/chicken.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/chicken.scm b/gnu/packages/chicken.scm
index 8f5e8ce98d..d48a0c89c0 100644
--- a/gnu/packages/chicken.scm
+++ b/gnu/packages/chicken.scm
@@ -33,14 +33,14 @@ (define-module (gnu packages chicken)
 (define-public chicken
   (package
     (name "chicken")
-    (version "5.3.0")
+    (version "5.4.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://code.call-cc.org/releases/"
                                   version "/chicken-" version ".tar.gz"))
               (sha256
                (base32
-                "0xhdvcdwlv9vbhxh7k0fzd32ybhc7fn83y9fj48dhzp1z7c9kbf3"))))
+                "0pzcrnzkjw2sa44vy59wbygvlc3nva8zisprkdnvyrqi3jk4lp9w"))))
     (build-system gnu-build-system)
     (arguments
      `(#:modules ((guix build gnu-build-system)
-- 
2.45.2

[bug#72173] [PATCH v2 2/2] guix: chicken-build-system: Update for 5.4.0.

[ashish.is--- via Guix-patches via]

From: Ashish SHUKLA <ashish.is@lostca.se>

* guix/build/chicken-build-system (build): chdir to the directory containing
  sources, and let chicken-install process the current directory.
  (install): Switch to define as we do not need any keys.
  (check): Remove unused egg-name from the arguments.

Change-Id: I4adf5e2378deab6e3f3b3c128c3cc75ce43f0e8a
---
 guix/build/chicken-build-system.scm | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/guix/build/chicken-build-system.scm b/guix/build/chicken-build-system.scm
index 8f9f59cc25..fd5a33fd22 100644
--- a/guix/build/chicken-build-system.scm
+++ b/guix/build/chicken-build-system.scm
@@ -93,13 +93,14 @@ (define* (unpack #:key source egg-name unpack-path #:allow-other-keys)
 
 (define* (build #:key egg-name #:allow-other-keys)
   "Build the Chicken egg named by EGG-NAME"
-  (invoke "chicken-install" "-cached" "-no-install" egg-name))
+  (chdir egg-name)
+  (invoke "chicken-install" "-cached" "-no-install"))
 
-(define* (install #:key egg-name #:allow-other-keys)
+(define (install . _)
   "Install the already built egg named by EGG-NAME"
-  (invoke "chicken-install" "-cached" egg-name))
+  (invoke "chicken-install" "-cached"))
 
-(define* (check #:key egg-name tests? #:allow-other-keys)
+(define* (check #:key tests? #:allow-other-keys)
   "Build and run tests for the Chicken egg EGG-NAME"
   ;; there is no "-test-only" option, but we've already run install
   ;; so this just runs tests.
@@ -109,7 +110,7 @@ (define* (check #:key egg-name tests? #:allow-other-keys)
                          ":"
                          (getenv "CHICKEN_REPOSITORY_PATH")))
   (when tests?
-    (invoke "chicken-install" "-cached" "-test" "-no-install" egg-name)))
+    (invoke "chicken-install" "-cached" "-test" "-no-install")))
 
 (define* (stamp-egg-version #:key egg-name name #:allow-other-keys)
   "Check if EGG-NAME.egg contains version information and add some if not."
-- 
2.45.2

[bug#72173] [PATCH] gnu: chicken: Update to 5.4.0.

[jgart via Guix-patches via]

Hi,

Thanks for the v2. I can't apply this patch series with mumi am.

Can you share the method that you used to send it?

Thanks,

jgart

[bug#72173] [PATCH] gnu: chicken: Update to 5.4.0.

[Ashish via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

On Thu, Jul 25, 2024 at 03:48:58PM -0500, jgart wrote:
> 
> Hi,
> 
> Thanks for the v2. I can't apply this patch series with mumi am.
> 
> Can you share the method that you used to send it?

Sure.

git send-email -2 -v2 \
  --in-reply-to=a2cc7b416a4a87e086dd432c889b2f96270cbccb@dismail.de \
  --to=72173@debbugs.gnu.org --cover-letter --annotate \
  --base=origin/master

origin/master was 03062c7a9fd74d625639e1a325e9cb58d1cd74e3

Thanks!
-- 
Ashish SHUKLA | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0

"If I destroy you, what business is it of yours ?" (Dark Forest, Liu Cixin)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

[bug#72173] [PATCH] gnu: chicken: Update to 5.4.0.

[Ashish via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 2223 bytes --]

On Fri, Jul 26, 2024 at 08:35:21AM +0000, Ashish wrote:
> On Thu, Jul 25, 2024 at 03:48:58PM -0500, jgart wrote:
> > 
> > Hi,
> > 
> > Thanks for the v2. I can't apply this patch series with mumi am.
> > 
> > Can you share the method that you used to send it?
> 
> Sure.
> 
> git send-email -2 -v2 \
>   --in-reply-to=a2cc7b416a4a87e086dd432c889b2f96270cbccb@dismail.de \
>   --to=72173@debbugs.gnu.org --cover-letter --annotate \
>   --base=origin/master
> 
> origin/master was 03062c7a9fd74d625639e1a325e9cb58d1cd74e3
> 
> Thanks!
> -- 
> Ashish SHUKLA | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0
> 
> "If I destroy you, what business is it of yours ?" (Dark Forest, Liu Cixin)

❯ git rev-parse HEAD                                                                                                                                                                          
efc26826400762207cde9f23802cfe75a737963c                                                                                                                                                      

❯ git checkout -b testing-pr-72173                                                                                                                                                            
Switched to a new branch 'testing-pr-72173'                                                                                                                                                   

❯ curl -sL https://issues.guix.gnu.org/issue/72173/raw/{12..13} | git am
Applying: gnu: chicken: Update to 5.4.0.
Applying: guix: chicken-build-system: Update for 5.4.0.


Please note that the URLs above are not quite what are reflected in the 
web UI, so my guess something in the upstream mumi DB is messed up.

e.g. https://issues.guix.gnu.org/issue/72173/raw/13 is associated with 
your reply in the web UI, but if you download it, it's the one that 
contains the message containing the patch.

My guess is this is why mumi is getting confused.

HTH
-- 
Ashish SHUKLA | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0

"If I destroy you, what business is it of yours ?" (Dark Forest, Liu Cixin)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 963 bytes --]