[bug#72452] [PATCH] add guile-swayer package

[bug#72452] [PATCH] add guile-swayer package

[mrh]

guile-swayer provides guile bindings to manipulate windows via the sway wayland compositor

Change-Id: If579694d8fb20bec5f3fd542430783a25a6c155b
---
 gnu/packages/guile-xyz.scm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 3ce4f6a8d6..5693bbde0f 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -1027,6 +1027,24 @@ (define-public guile2.2-filesystem
     (name "guile2.2-filesystem")
     (inputs (list guile-2.2))))
 
+(define-public guile-swayer
+  (package
+    (name "guile-swayer")
+    (version "0.2.0")
+    (home-page "https://github.com/ebeem/guile-swayer")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ebeem/guile-swayer")
+             (commit "9c962281f405453fb3770dd0546ef6951c9236dd")))
+       (sha256 (base32 "09c0143q9sm75xp1qz7a7ihdqfwqg4w8nlq0mmnivhvamww775ss"))))
+    (native-inputs (list guile-3.0))
+    (build-system guile-build-system)
+    (synopsis "Extensible Guile bindings for SwayWM")
+    (description "Extensible Guile bindings for SwayWM")
+    (license license:expat)))
+
 (define-public guile-syntax-highlight
   (package
     (name "guile-syntax-highlight")

base-commit: b20956651a53a8f23828fdeb6945e1a31e6997a8
-- 
2.45.2

[bug#72452] [PATCH] add guile-swayer package

[Nicolas Graves via Guix-patches via]

Hi mrh,

A few remarks below.

On 2024-08-03 20:31, mrh wrote:

> guile-swayer provides guile bindings to manipulate windows via the sway wayland compositor
>
> Change-Id: If579694d8fb20bec5f3fd542430783a25a6c155b
> ---
>  gnu/packages/guile-xyz.scm | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
> index 3ce4f6a8d6..5693bbde0f 100644
> --- a/gnu/packages/guile-xyz.scm
> +++ b/gnu/packages/guile-xyz.scm
> @@ -1027,6 +1027,24 @@ (define-public guile2.2-filesystem
>      (name "guile2.2-filesystem")
>      (inputs (list guile-2.2))))
>  
> +(define-public guile-swayer
> +  (package
> +    (name "guile-swayer")
> +    (version "0.2.0")
> +    (home-page "https://github.com/ebeem/guile-swayer")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/ebeem/guile-swayer")
> +             (commit "9c962281f405453fb3770dd0546ef6951c9236dd")))
> +       (sha256 (base32 "09c0143q9sm75xp1qz7a7ihdqfwqg4w8nlq0mmnivhvamww775ss"))))

This line exceeds 79 characters, you should put base32 part on the next line.

> +    (native-inputs (list guile-3.0))
> +    (build-system guile-build-system)
> +    (synopsis "Extensible Guile bindings for SwayWM")
> +    (description "Extensible Guile bindings for SwayWM")

The description needs to be more informative. What about

"This package provides extensible Guile bindings for the Sway window
manager.  It can be used to query Sway, assign keybindings and listen to
events in Guile."

> +    (license license:expat)))
> +

Otherwise the package builds properly, I'll be happy to review that once
you send a v2.

Please also abstain from opening duplicate issues, thanks!

-- 
Best regards,
Nicolas Graves

[bug#72452] [PATCH] add guile-swayer package

[mrh57]

Hi Nicolas,

Thanks for the review! I have fixed the issues in the forthcoming v2 
patch.

Best,
Alec

On 2024-09-07 12:15 pm, Nicolas Graves wrote:
> Hi mrh,
> 
> A few remarks below.
> 
> On 2024-08-03 20:31, mrh wrote:
> 
>> guile-swayer provides guile bindings to manipulate windows via the 
>> sway wayland compositor
>> 
>> Change-Id: If579694d8fb20bec5f3fd542430783a25a6c155b
>> ---
>>  gnu/packages/guile-xyz.scm | 18 ++++++++++++++++++
>>  1 file changed, 18 insertions(+)
>> 
>> diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
>> index 3ce4f6a8d6..5693bbde0f 100644
>> --- a/gnu/packages/guile-xyz.scm
>> +++ b/gnu/packages/guile-xyz.scm
>> @@ -1027,6 +1027,24 @@ (define-public guile2.2-filesystem
>>      (name "guile2.2-filesystem")
>>      (inputs (list guile-2.2))))
>> 
>> +(define-public guile-swayer
>> +  (package
>> +    (name "guile-swayer")
>> +    (version "0.2.0")
>> +    (home-page "https://github.com/ebeem/guile-swayer")
>> +    (source
>> +     (origin
>> +       (method git-fetch)
>> +       (uri (git-reference
>> +             (url "https://github.com/ebeem/guile-swayer")
>> +             (commit "9c962281f405453fb3770dd0546ef6951c9236dd")))
>> +       (sha256 (base32 
>> "09c0143q9sm75xp1qz7a7ihdqfwqg4w8nlq0mmnivhvamww775ss"))))
> 
> This line exceeds 79 characters, you should put base32 part on the next 
> line.
> 
>> +    (native-inputs (list guile-3.0))
>> +    (build-system guile-build-system)
>> +    (synopsis "Extensible Guile bindings for SwayWM")
>> +    (description "Extensible Guile bindings for SwayWM")
> 
> The description needs to be more informative. What about
> 
> "This package provides extensible Guile bindings for the Sway window
> manager.  It can be used to query Sway, assign keybindings and listen 
> to
> events in Guile."
> 
>> +    (license license:expat)))
>> +
> 
> Otherwise the package builds properly, I'll be happy to review that 
> once
> you send a v2.
> 
> Please also abstain from opening duplicate issues, thanks!

[bug#72452] [PATCH v2] gnu: add guile-swayer

[mrh]

From: Alec Barreto <mrh57@posteo.net>

Change-Id: Ibd3817842e36fa35a3f1ecc09288549c10fd0d12
---
 gnu/packages/guile-xyz.scm | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 6204261cd5..3a40c4f29d 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2024 Ilya Chernyshov <ichernyshovvv@gmail.com>
 ;;; Copyright © 2024 Artyom Bologov <mail@aartaka.me>
 ;;; Copyright © 2024 Felix Lechner <felix.lechner@lease-up.com>
+;;; Copyright © 2024 Alec Barreto <mrh57@posteo.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -93,7 +94,7 @@ (define-module (gnu packages guile-xyz)
   #:use-module (gnu packages gstreamer)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages guile)
-  #:use-module (gnu packages haskell-xyz)         ;pandoc
+  #:use-module (gnu packages haskell-xyz) ;pandoc
   #:use-module (gnu packages image)
   #:use-module (gnu packages imagemagick)
   #:use-module (gnu packages libevent)
@@ -1027,6 +1028,28 @@ (define-public guile2.2-filesystem
     (name "guile2.2-filesystem")
     (inputs (list guile-2.2))))
 
+(define-public guile-swayer
+  (package
+    (name "guile-swayer")
+    (version "0.2.0")
+    (home-page "https://github.com/ebeem/guile-swayer")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ebeem/guile-swayer")
+             (commit "9c962281f405453fb3770dd0546ef6951c9236dd")))
+       (sha256
+        (base32 "09c0143q9sm75xp1qz7a7ihdqfwqg4w8nlq0mmnivhvamww775ss"))))
+    (native-inputs (list guile-3.0))
+    (build-system guile-build-system)
+    (synopsis "Extensible Guile bindings for SwayWM")
+    (description
+     "This package provides extensible Guile bindings for the Sway window
+manager.  It can be used to query Sway, assign keybindings and listen to
+events in Guile.")
+    (license license:expat)))
+
 (define-public guile-syntax-highlight
   (package
     (name "guile-syntax-highlight")

base-commit: ed95ddeb1e58c314f2e22b4cd35986042f3e2f21
-- 
2.45.2

[bug#72452] [PATCH] add guile-swayer package

[Nicolas Graves via Guix-patches via]

Some other nitpicks:

1) (commit field should rather refer to version such as
 (commit (string-append "v" version))

This makes it easier to update.

2) guix lint complains about
guile-swayer@0.2.0: the source file name should contain the package name

You're missing
       (file-name (git-file-name name version))
in the origin. This makes it easier to find things in the store.

-- 
Best regards,
Nicolas Graves

[bug#72452] [PATCH] add guile-swayer package

[mrh57]

Thanks again for the feedback.

> 1) (commit field should rather refer to version such as
>  (commit (string-append "v" version))

I made this change, but as =(commit version)= since there is no "v" in 
the release titles.

I think =guix lint= and =guix style= should now be happy :)

[bug#72452] [PATCH v3] gnu: add guile-swayer

[Alec Barreto]

Change-Id: Ibd3817842e36fa35a3f1ecc09288549c10fd0d12
---
 gnu/packages/guile-xyz.scm | 26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 3bcb0e82bb..4f560b7d73 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2024 Ilya Chernyshov <ichernyshovvv@gmail.com>
 ;;; Copyright © 2024 Artyom Bologov <mail@aartaka.me>
 ;;; Copyright © 2024 Felix Lechner <felix.lechner@lease-up.com>
+;;; Copyright © 2024 Alec Barreto <mrh57@posteo.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -93,7 +94,7 @@ (define-module (gnu packages guile-xyz)
   #:use-module (gnu packages gstreamer)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages guile)
-  #:use-module (gnu packages haskell-xyz)         ;pandoc
+  #:use-module (gnu packages haskell-xyz) ;pandoc
   #:use-module (gnu packages image)
   #:use-module (gnu packages imagemagick)
   #:use-module (gnu packages libevent)
@@ -1027,6 +1028,29 @@ (define-public guile2.2-filesystem
     (name "guile2.2-filesystem")
     (inputs (list guile-2.2))))
 
+(define-public guile-swayer
+  (package
+    (name "guile-swayer")
+    (version "0.2.0")
+    (home-page "https://github.com/ebeem/guile-swayer")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ebeem/guile-swayer")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "09c0143q9sm75xp1qz7a7ihdqfwqg4w8nlq0mmnivhvamww775ss"))))
+    (native-inputs (list guile-3.0))
+    (build-system guile-build-system)
+    (synopsis "Extensible Guile bindings for SwayWM")
+    (description
+     "This package provides extensible Guile bindings for the Sway window
+manager.  It can be used to query Sway, assign keybindings and listen to
+events in Guile.")
+    (license license:expat)))
+
 (define-public guile-syntax-highlight
   (package
     (name "guile-syntax-highlight")

base-commit: 056910ec864cb7cf3225a0c27679d94405db7dcd
-- 
2.46.0

[bug#72452] [PATCH] add guile-swayer package

[Nicolas Graves via Guix-patches via]

On 2024-09-09 16:21, mrh57@posteo.net wrote:

> Thanks again for the feedback.
>
>> 1) (commit field should rather refer to version such as
>>  (commit (string-append "v" version))
>
> I made this change, but as =(commit version)= since there is no "v" in 
> the release titles.

The commit here will correspond to a git tag, not a github release. I
think it should keep the "v" ;)

>
> I think =guix lint= and =guix style= should now be happy :)
>

Have you tried rebuilding it since?
>
>

-- 
Best regards,
Nicolas Graves

[bug#72452] [PATCH v4] gnu: add guile-swayer

[Alec Barreto]

Change-Id: Ibd3817842e36fa35a3f1ecc09288549c10fd0d12
---
 gnu/packages/guile-xyz.scm | 26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 3bcb0e82bb..fa941eb40c 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2024 Ilya Chernyshov <ichernyshovvv@gmail.com>
 ;;; Copyright © 2024 Artyom Bologov <mail@aartaka.me>
 ;;; Copyright © 2024 Felix Lechner <felix.lechner@lease-up.com>
+;;; Copyright © 2024 Alec Barreto <mrh57@posteo.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -93,7 +94,7 @@ (define-module (gnu packages guile-xyz)
   #:use-module (gnu packages gstreamer)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages guile)
-  #:use-module (gnu packages haskell-xyz)         ;pandoc
+  #:use-module (gnu packages haskell-xyz) ;pandoc
   #:use-module (gnu packages image)
   #:use-module (gnu packages imagemagick)
   #:use-module (gnu packages libevent)
@@ -1027,6 +1028,29 @@ (define-public guile2.2-filesystem
     (name "guile2.2-filesystem")
     (inputs (list guile-2.2))))
 
+(define-public guile-swayer
+  (package
+    (name "guile-swayer")
+    (version "0.2.0")
+    (home-page "https://github.com/ebeem/guile-swayer")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ebeem/guile-swayer")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "09c0143q9sm75xp1qz7a7ihdqfwqg4w8nlq0mmnivhvamww775ss"))))
+    (native-inputs (list guile-3.0))
+    (build-system guile-build-system)
+    (synopsis "Extensible Guile bindings for SwayWM")
+    (description
+     "This package provides extensible Guile bindings for the Sway window
+manager.  It can be used to query Sway, assign keybindings and listen to
+events in Guile.")
+    (license license:expat)))
+
 (define-public guile-syntax-highlight
   (package
     (name "guile-syntax-highlight")

base-commit: 056910ec864cb7cf3225a0c27679d94405db7dcd
-- 
2.46.0

[bug#72452] Fwd: Re: [bug#72452] [PATCH] add guile-swayer package

[mrh57]

-------- Original Message --------
Subject: Re: [bug#72452] [PATCH] add guile-swayer package
Date: 2024-09-10 8:08 am
 From: mrh57@posteo.net
To: Nicolas Graves <ngraves@ngraves.fr>

On 2024-09-10 4:14 am, Nicolas Graves wrote:
> On 2024-09-09 16:21, mrh57@posteo.net wrote:
> 
>> Thanks again for the feedback.
>> 
>>> 1) (commit field should rather refer to version such as
>>>  (commit (string-append "v" version))
>> 
>> I made this change, but as =(commit version)= since there is no "v" in
>> the release titles.
> 
> The commit here will correspond to a git tag, not a github release. I
> think it should keep the "v" ;)

Ah yes makes sense, whoops!
Change made.

>> I think =guix lint= and =guix style= should now be happy :)
>> 
> 
> Have you tried rebuilding it since?

Yes it successfully builds with these changes under multiple rounds.

[bug#72452] QA review for 72452

[Nicolas Graves via Guix-patches via]

user guix
usertag 72452 + reviewed-looks-good
thanks

Guix QA review form submission:


Items marked as checked: Lint warnings, Package builds, Commit messages, New package licenses, New package tests, New package synopsis and descriptions

-- 
Best regards,
Nicolas Graves

[bug#72452] Fwd: Re: [bug#72452] [PATCH] add guile-swayer package

[Nicolas Graves via Guix-patches via]

I've forgotten to properly check the commit message, it should be:

```
gnu: Add guile-swayer.

* gnu/packages/guile-xyz.scm (guile-swayer): New variable.
```

You can use tempel/yasnippets, guix has some preconfigured commit
messages in (guix source)/etc.

Last nitpick: you can also drop the following change:

  #:use-module (gnu packages haskell-xyz)         ;pandoc


-- 
Best regards,
Nicolas Graves

[bug#72452] Fwd: Re: [bug#72452] [PATCH] add guile-swayer package

[Alec Barreto]

Nicolas Graves <ngraves@ngraves.fr> writes:

> I've forgotten to properly check the commit message, it should be:
>
> ```
> gnu: Add guile-swayer.
>
> * gnu/packages/guile-xyz.scm (guile-swayer): New variable.
> ```
>
> You can use tempel/yasnippets, guix has some preconfigured commit
> messages in (guix source)/etc.
> Last nitpick: you can also drop the following change:
>
>   #:use-module (gnu packages haskell-xyz)         ;pandoc

Ah thanks, much learned for my next patch.
Changes made.

[bug#72452] [PATCH v5] gnu: Add guile-swayer.

[Alec Barreto]

* gnu/packages/guile-xyz.scm (guile-swayer): New variable.

Change-Id: Ibd3817842e36fa35a3f1ecc09288549c10fd0d12
---
 gnu/packages/guile-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 3bcb0e82bb..17e5a03d17 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2024 Ilya Chernyshov <ichernyshovvv@gmail.com>
 ;;; Copyright © 2024 Artyom Bologov <mail@aartaka.me>
 ;;; Copyright © 2024 Felix Lechner <felix.lechner@lease-up.com>
+;;; Copyright © 2024 Alec Barreto <mrh57@posteo.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1027,6 +1028,29 @@ (define-public guile2.2-filesystem
     (name "guile2.2-filesystem")
     (inputs (list guile-2.2))))
 
+(define-public guile-swayer
+  (package
+    (name "guile-swayer")
+    (version "0.2.0")
+    (home-page "https://github.com/ebeem/guile-swayer")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ebeem/guile-swayer")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "09c0143q9sm75xp1qz7a7ihdqfwqg4w8nlq0mmnivhvamww775ss"))))
+    (native-inputs (list guile-3.0))
+    (build-system guile-build-system)
+    (synopsis "Extensible Guile bindings for SwayWM")
+    (description
+     "This package provides extensible Guile bindings for the Sway window
+manager.  It can be used to query Sway, assign keybindings and listen to
+events in Guile.")
+    (license license:expat)))
+
 (define-public guile-syntax-highlight
   (package
     (name "guile-syntax-highlight")

base-commit: 056910ec864cb7cf3225a0c27679d94405db7dcd
-- 
2.46.0

[bug#72452] [PATCH v5] gnu: Add guile-swayer.

[Ludovic Courtès]

Hi,

Alec Barreto <mrh57@posteo.net> skribis:

> * gnu/packages/guile-xyz.scm (guile-swayer): New variable.
>
> Change-Id: Ibd3817842e36fa35a3f1ecc09288549c10fd0d12

I was about to push it but got this error:

--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix build guile-swayer

[...]

HEAD is now at 67e3522 revert example.scm
r:sha256 hash mismatch for /gnu/store/akv9bcr9kdilw6nkzsay34vxwyw381vm-guile-swayer-0.2.0-checkout:
  expected hash: 09c0143q9sm75xp1qz7a7ihdqfwqg4w8nlq0mmnivhvamww775ss
  actual hash:   1xid45npr5v379jziidjda8mg34gabbp7kaxil1h37z67sdwky4h
hash mismatch for store item '/gnu/store/akv9bcr9kdilw6nkzsay34vxwyw381vm-guile-swayer-0.2.0-checkout'
build of /gnu/store/bijs0qa7d7b8m80b0n0ivi177ws1f17d-guile-swayer-0.2.0-checkout.drv failed
View build log at '/var/log/guix/drvs/bi/js0qa7d7b8m80b0n0ivi177ws1f17d-guile-swayer-0.2.0-checkout.drv.gz'.
cannot build derivation `/gnu/store/xl9lmk79p14karjglkxgnlpmp3805pdg-guile-swayer-0.2.0.drv': 1 dependencies couldn't be built
guix build: error: build of `/gnu/store/xl9lmk79p14karjglkxgnlpmp3805pdg-guile-swayer-0.2.0.drv' failed
--8<---------------cut here---------------end--------------->8---

Could it be that the v0.2.0 tag was modified in place?

Could you send an updated patch with the updated hash once you’ve
confirmed it’s all right?

Thanks in advance!

Ludo’.

[bug#72452] [PATCH v5] gnu: Add guile-swayer.

[Alec Barreto]

Hello!

Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> Alec Barreto <mrh57@posteo.net> skribis:
>
>> * gnu/packages/guile-xyz.scm (guile-swayer): New variable.
>>
>> Change-Id: Ibd3817842e36fa35a3f1ecc09288549c10fd0d12
>
> I was about to push it but got this error:
>
> --8<---------------cut here---------------start------------->8---
> $ ./pre-inst-env guix build guile-swayer
>
> [...]
>
> HEAD is now at 67e3522 revert example.scm
> r:sha256 hash mismatch for /gnu/store/akv9bcr9kdilw6nkzsay34vxwyw381vm-guile-swayer-0.2.0-checkout:
>   expected hash: 09c0143q9sm75xp1qz7a7ihdqfwqg4w8nlq0mmnivhvamww775ss
>   actual hash:   1xid45npr5v379jziidjda8mg34gabbp7kaxil1h37z67sdwky4h
> hash mismatch for store item '/gnu/store/akv9bcr9kdilw6nkzsay34vxwyw381vm-guile-swayer-0.2.0-checkout'
> build of /gnu/store/bijs0qa7d7b8m80b0n0ivi177ws1f17d-guile-swayer-0.2.0-checkout.drv failed
> View build log at '/var/log/guix/drvs/bi/js0qa7d7b8m80b0n0ivi177ws1f17d-guile-swayer-0.2.0-checkout.drv.gz'.
> cannot build derivation `/gnu/store/xl9lmk79p14karjglkxgnlpmp3805pdg-guile-swayer-0.2.0.drv': 1 dependencies couldn't be built
> guix build: error: build of `/gnu/store/xl9lmk79p14karjglkxgnlpmp3805pdg-guile-swayer-0.2.0.drv' failed
> --8<---------------cut here---------------end--------------->8---
>
> Could it be that the v0.2.0 tag was modified in place?
>
> Could you send an updated patch with the updated hash once you’ve
> confirmed it’s all right?
>
> Thanks in advance!
>
> Ludo’.

Hm sorry I'm not sure what's going on here.
The package builds fine for me as is in the patch.
However if I switch the hash in the package definition anyways I get:

--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix build guile-swayer

[...]

HEAD is now at 67e3522 revert example.scm
r:sha256 hash mismatch for /gnu/store/3ckiq7q6faq0q5z1iyw34iyx2wdpy8iq-guile-swayer-0.2.0-checkout:
  expected hash: 1x1d45npr5v379jziidjda8mg34gabbp7kaxil1h37z67sdwky4h
  actual hash:   1xid45npr5v379jziidjda8mg34gabbp7kaxil1h37z67sdwky4h
hash mismatch for store item '/gnu/store/3ckiq7q6faq0q5z1iyw34iyx2wdpy8iq-guile-swayer-0.2.0-checkout'
build of /gnu/store/fkwqcknwkh78ryhrxwqb0fs4ncncpa76-guile-swayer-0.2.0-checkout.drv failed
Could not find build log for '/gnu/store/fkwqcknwkh78ryhrxwqb0fs4ncncpa76-guile-swayer-0.2.0-checkout.drv'.
cannot build derivation `/gnu/store/7fwvwc4z45g8ilk9dvrdm0pf86s8bjvq-guile-swayer-0.2.0.drv': 1 dependencies couldn't be built
guix build: error: build of `/gnu/store/7fwvwc4z45g8ilk9dvrdm0pf86s8bjvq-guile-swayer-0.2.0.drv' failed
--8<---------------cut here---------------end--------------->8---

My internet is a bit spotty today and tomorrow, so ending this
while I can, but I can investigate soon.

Best,
Alec

[bug#72452] [PATCH v5] gnu: Add guile-swayer.

[Alec Barreto]

Besides the typo in my last message, I found the mistake I made.
The original patch had (commit <commit-hash>), which contained a fix to
the guix package build process which is not in the latest release
v0.2.0.
The old 0.2.0 version won't build for bug-reasons in the code.

Should I switch the commit field back, or wait for the next version bump
which includes the fix?

Best,
Alec

[bug#72452] [PATCH v5] gnu: Add guile-swayer.

[Nicolas Graves via Guix-patches via]

On 2024-09-14 14:18, Alec Barreto wrote:

> Besides the typo in my last message, I found the mistake I made.
> The original patch had (commit <commit-hash>), which contained a fix to
> the guix package build process which is not in the latest release
> v0.2.0.
> The old 0.2.0 version won't build for bug-reasons in the code.
>
> Should I switch the commit field back, or wait for the next version bump
> which includes the fix?

If you want to pick a specific commit, you can do something like this

  (let ((commit [commit])
        (version "0.2.0")
        (revision "0"))
    (package
      (name [name])
      (version (git-version version revision commit))
      (source (origin
                (method git-fetch)
                (uri (git-reference
                       (url [url])
                       (commit commit)))
                (file-name (git-file-name name version))
                (sha256
                 (base32
                  ""))))


This makes it easier to upgrade to another given commit if necessary.

-- 
Best regards,
Nicolas Graves

[bug#72452] [PATCH v5] gnu: Add guile-swayer.

[Alec Barreto]

Nicolas Graves <ngraves@ngraves.fr> writes:

> If you want to pick a specific commit, you can do something like this
>
>   (let ((commit [commit])
>         (version "0.2.0")
>         (revision "0"))
>     (package
>       (name [name])
>       (version (git-version version revision commit))
>       (source (origin
>                 (method git-fetch)
>                 (uri (git-reference
>                        (url [url])
>                        (commit commit)))
>                 (file-name (git-file-name name version))
>                 (sha256
>                  (base32
>                   ""))))
>
>
> This makes it easier to upgrade to another given commit if necessary.

Thanks!
Funnily v0.3.0 was just released right after your message.
However it introduces a new (minor) issue.

There is a =manifest.scm= file in the project root which was for
building the program with guix since it wasn't (isn't) yet upstream. 
But now with the new 0.3.0 version the =guile-build-system= tries to
compile the =manifest.scm= as part of the program, causing build
failure.

The project itself could create a =make= file and the package definiton
could be switched to =gnu-build-system=.

Alternatively, since the manifest is arguably obsolete if this package
becomes upstreamed, the manifest can simply be removed.

We can wait for one of those situations, or just package it now in the
manner you suggested and pin the commit to where the package builds
(but still updating to  v0.3.0?)

Best,
Alec

[bug#72452] [PATCH v5] gnu: Add guile-swayer.

[Nicolas Graves via Guix-patches via]

On 2024-09-14 18:23, Alec Barreto wrote:

> Thanks!
> Funnily v0.3.0 was just released right after your message.

I've seen that indeed ;)

> Alternatively, since the manifest is arguably obsolete if this package
> becomes upstreamed, the manifest can simply be removed.
>
> We can wait for one of those situations, or just package it now in the
> manner you suggested and pin the commit to where the package builds
> (but still updating to  v0.3.0?)

You could add a snippet in the origin to remove the manifest.scm file,
something like that should be enough :

(snippet '(delete-file "manifest.scm"))

>
> Best,
> Alec
>
>
>

-- 
Best regards,
Nicolas Graves

[bug#72452] [PATCH v5] gnu: Add guile-swayer.

[Alec Barreto]

Nicolas Graves <ngraves@ngraves.fr> writes:

> You could add a snippet in the origin to remove the manifest.scm file,
> something like that should be enough :
>
> (snippet '(delete-file "manifest.scm"))
>
Good call!
Change made, linter happy and package building successfully.
Sending v6.

[bug#72452] [PATCH v6] gnu: Add guile-swayer.

[Alec Barreto]

* gnu/packages/guile-xyz.scm (guile-swayer): New variable.

Change-Id: Ibd3817842e36fa35a3f1ecc09288549c10fd0d12
---
 gnu/packages/guile-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 3bcb0e82bb..68a42098ef 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2024 Ilya Chernyshov <ichernyshovvv@gmail.com>
 ;;; Copyright © 2024 Artyom Bologov <mail@aartaka.me>
 ;;; Copyright © 2024 Felix Lechner <felix.lechner@lease-up.com>
+;;; Copyright © 2024 Alec Barreto <mrh57@posteo.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1027,6 +1028,30 @@ (define-public guile2.2-filesystem
     (name "guile2.2-filesystem")
     (inputs (list guile-2.2))))
 
+(define-public guile-swayer
+  (package
+    (name "guile-swayer")
+    (version "0.3.0")
+    (home-page "https://github.com/ebeem/guile-swayer")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ebeem/guile-swayer")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (snippet '(delete-file "manifest.scm"))
+       (sha256
+        (base32 "16npa337rp0s9rg4fc749b1nq6kfxj77pdd1qfh9xdrb1n0w7awi"))))
+    (native-inputs (list guile-3.0))
+    (build-system guile-build-system)
+    (synopsis "Extensible Guile bindings for SwayWM")
+    (description
+     "This package provides extensible Guile bindings for the Sway window
+manager.  It can be used to query Sway, assign keybindings and listen to
+events in Guile.")
+    (license license:expat)))
+
 (define-public guile-syntax-highlight
   (package
     (name "guile-syntax-highlight")

base-commit: 056910ec864cb7cf3225a0c27679d94405db7dcd
-- 
2.46.0

bug#72452: [PATCH v6] gnu: Add guile-swayer.

[Ludovic Courtès]

Alec Barreto <mrh57@posteo.net> skribis:

> * gnu/packages/guile-xyz.scm (guile-swayer): New variable.
>
> Change-Id: Ibd3817842e36fa35a3f1ecc09288549c10fd0d12

Applied, thanks!