From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id MF6aIrs26mbrVQEA62LTzQ:P1 (envelope-from ) for ; Wed, 18 Sep 2024 02:11:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id MF6aIrs26mbrVQEA62LTzQ (envelope-from ) for ; Wed, 18 Sep 2024 04:11:07 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=b3wD6yAb; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726625467; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=NsAkg+/+qakYLDq6nWdjknmS/nTLcL/57HD1XyRIpx0=; b=ZU6U3yCj+sx71ZiPNcD0uw2hNO5YWmo4yvscZYQYT9jOFqWWba4YNbz873v0IYdTIA+Hlr Md8VF3shVuaB3v5Qk8EvyaSW7ElDAtxaXAokTdfQC4WErASCqYNUQ1APp27EBqggG4YcoA rxKGpSxgfDwFg/aqQMZyE9y6njD+iuOOduSogDfvgAgIFTY6STD8x4/0wHfEKQnNo1PwgU TYE/ZxcYc3rwDFdkFaRWu3UYftYyMq8V9iELhSxaIjptysZYq/ZvpQQg13N+S3836fG4ei r05ZxQYC9cZu3DEIpHY8CvOSyIAo7h4QIOfFtb2o7yfV22iMNHF0fonv1z6lHA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=b3wD6yAb; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726625467; a=rsa-sha256; cv=none; b=Tzfhad5Tu1BgvQS0DIZKt8Bb7QW28Oc/3cCuCh+SBgXdjxWJpDMFmoZeFRBQQgSB4hrh6x KBWDmTLGicvHD9xFqritFvjb/fQ3uESIqX45WqPChc4dunEIMv8xPgwjQcVz8luEtVa2pQ TZgUkVrRdyS2bjZfpE/WF8IOSe+WxvPBNI8ENHOAzHd7CgBQ6om8CX9PpKM1vdvKnsGh3I hK0W+6sBWoE4fLMSkW7uC983XgUx9JLZmZ5KeDoFlDzTrlsIQxZUcDMaPZ50G/tgWf/Pcn Ez9WH7yce0L7Wl8oL3K9k2NoBTRW1j5R/NNtQ/rEJLjXdr9rfVOVGZPySdRxBA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5CAEF2078 for ; Wed, 18 Sep 2024 04:11:07 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqk9a-0002VL-Bl; Tue, 17 Sep 2024 22:10:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqk9X-0002Uh-Si for guix-patches@gnu.org; Tue, 17 Sep 2024 22:10:48 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqk9X-0002bY-I1 for guix-patches@gnu.org; Tue, 17 Sep 2024 22:10:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=NsAkg+/+qakYLDq6nWdjknmS/nTLcL/57HD1XyRIpx0=; b=b3wD6yAbafGjOPW31Krk3QCShR7WnpT1qNL72vZY/ijeW00Aoxl4Z1tF3zb6Ypdk7A0apdpb2J0QQEmWlopUPewgUDvdg7oDlxGVziObX+50anFxeQPUBE0i5zQP/k/cLE2AD1mGEysaosIVuOVYZbNkWntHdxX79pfBo9FJDDei15/bgvYSOvghH/Hfww+59N7Awqv75Bz4oh56fcDeHR3XD8B7tDh8V380lI6yMDMlKFHgDXxUKdweb5T/m6A8Xn9DkwtZ6rziEpt/hM7ZuNE2zJy9z7vTrDx1OISKwDTXn40oA0/+zbUK5U1icA8a+GwKtAIobiovLNp7K3R+sw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sqk9m-0005qY-Ts for guix-patches@gnu.org; Tue, 17 Sep 2024 22:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72835] [PATCH qt-team 32/38] gnu: Add qtconnectivity. Resent-From: Z572 Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 18 Sep 2024 02:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72835 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 72835@debbugs.gnu.org, =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Received: via spool by 72835-submit@debbugs.gnu.org id=B72835.172662545922458 (code B ref 72835); Wed, 18 Sep 2024 02:11:02 +0000 Received: (at 72835) by debbugs.gnu.org; 18 Sep 2024 02:10:59 +0000 Received: from localhost ([127.0.0.1]:56755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqk9j-0005q9-1M for submit@debbugs.gnu.org; Tue, 17 Sep 2024 22:10:59 -0400 Received: from smtp21.cstnet.cn ([159.226.251.21]:35950 helo=cstnet.cn) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqk9g-0005pu-8R for 72835@debbugs.gnu.org; Tue, 17 Sep 2024 22:10:57 -0400 Received: from m (unknown [107.174.64.25]) by APP-01 (Coremail) with SMTP id qwCowACHjh6VNupmujhXBA--.23072S2; Wed, 18 Sep 2024 10:10:32 +0800 (CST) From: Z572 In-Reply-To: <87ldzvvai1.fsf@gmail.com> (Maxim Cournoyer's message of "Sat, 14 Sep 2024 00:28:22 +0900") References: <87ldzvvai1.fsf@gmail.com> Date: Wed, 18 Sep 2024 10:10:27 +0800 Message-ID: <87y13pbtkc.fsf@iscas.ac.cn> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-CM-TRANSID: qwCowACHjh6VNupmujhXBA--.23072S2 X-Coremail-Antispam: 1UD129KBjvJXoW7tFWUJr45Cw1DGFWDGF4xCrg_yoW8ZrWkpr WUAFs0y3WrGF1xJ393W3WxWFn5u3yqkrW8Kw43Z34xKw45uFy8XFyIk345GwsF9r1jy3W2 9r18Za9xury5JFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9jb7Iv0xC_tr1lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjc xK6I8E87Iv6xkF7I0E14v26F4UJVW0owAa7VASzI0EjI02j7AqF2xKxVCjxxvEa2IrM2AI xVAIcxkEcVAq07x20xvEncxIr21le4C267I2x7xF54xIwI1l5I8CrVACY4xI64kE6c02F4 0Ex7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVW8JVWxJwAm72CE4IkC 6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7 v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF 1VAY17CE14v26r1Y6r17MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIx AIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI 42IY6I8E87Iv67AKxVWxJVW8Jr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvf C2KfnxnUUI43ZEXa7IUbAwIDUUUUU== X-Originating-IP: [107.174.64.25] X-CM-SenderInfo: x2kh0wxmxqyx3h6l2u1dvotugofq/ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 5CAEF2078 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -12.34 X-Migadu-Spam-Score: -12.34 X-TUID: VUaE0loRVoQh --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Maxim Cournoyer writes: > Hi Zheng, > > Zheng Junjie writes: > >> * gnu/packages/qt.scm (qtconnectivity): New variable. >> >> Change-Id: Ia2c1d9d260b47cd3a18c9ab5ac7e8f5ea83b7e11 >> --- >> gnu/packages/qt.scm | 23 +++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> >> diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm >> index 1956fec57a..df8759b832 100644 >> --- a/gnu/packages/qt.scm >> +++ b/gnu/packages/qt.scm >> @@ -1688,6 +1688,29 @@ (define-public qtconnectivity-5 >> (description "The Qt Connectivity modules provides modules for inte= racting >> with Bluetooth and NFC."))) >>=20=20 >> +(define-public qtconnectivity >> + (package >> + (inherit qtsvg) >> + (name "qtconnectivity") >> + (version "6.6.3") >> + (source (origin >> + (method url-fetch) >> + (uri (qt-url name version)) >> + (sha256 >> + (base32 >> + "066mf4d6a81ywviwr8bvm1mpm2ykjzysvcc0v2x82h5bl28vl6h9")= ))) >> + (native-inputs >> + (list perl pkg-config qtdeclarative)) >> + (inputs >> + (list bluez qtbase)) >> + (arguments (substitute-keyword-arguments (package-arguments qtsvg) >> + ((#:phases phases) >> + #~(modify-phases #$phases >> + (delete 'delete-installed-tests))))) >> + (synopsis "Qt Connectivity module") >> + (description "The Qt Connectivity modules provides modules for inte= racting >> +with Bluetooth and NFC."))) > > I'm not sure about using inheritance this way; the packages are > unrelated. You'd at least want to ensure propagated-inputs is forced to > '() in case qtsvg had some added in the future. > > I think I had refrained from using this style for Qt 6 thus far, as I > found it obfuscated the package definitions for Qt 5. > > Could you rewrite it to use the style as used for example by > qtshadertools? Only the home page and license fields need to be > specified. So it's one field difference, and better clarity. > > Could you please send a v2? done. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmbqNpQACgkQO1qpk+Gi 3/BG/A/+JTnxtOGTxWocNEhs0oR/xyL8ZAejod4sjiv5FtcoJ1+gN6th1ngWOJBw SPBq2EBg8nY9fNONrPxk12ApoD7i0tcNMxNQFfCvW4OalxoXCPKzAf7TIE7FqYWD 9S7urbB4M5M5u6o1d/mPap5OfAVjhMqb7U7IuVbvRaRUU1vaQXBcGg0zZBQki86w R9xmOJ3RRnjK+wmGp3HSNmHnJsDGYv6BrzQ2Xazd5Xit6Aa8n0L5eOqUs6VHMhOa 1L8GsUyPjkp2pPNHuNyBdT+DebNCgCDFiWy1g26RVHxE1vfcrw4X8tS5lJHo/zVT 32kh+iZKPXh81PhwQPxelmmroWUt0gJIMQYzBtZ8frF0TSEjyYN3plpgy3dP2fuJ WE3kblx+z7jAXw0vzjXM4198p8PSfw+hZtDXxSgePfWhPGDEHfm4voMCWtr9Co3J 7TMh4gkSRqKtN4wPOiMSoGkn6qf88B3uIJfAOAMO2zqSYmJ5W4w4FqnLoc9qaoue rzzthqfON3gdXN0ZdCBUqgZFaAJrt48ZW1wXWC+BRc9eTxZWmTDBPVz25pz6tMSy XrttmBSZzyhBNlpuonYSdo5h155LkuTsLXZYMZi16I/KhCC9owoS2Nx04SBY4F5e aQXI3thbIqES4TqHpfR8UO/s1235mcPy390RnNKjsiT3W/lWuJg= =L8od -----END PGP SIGNATURE----- --=-=-=--