From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id uNr2L3iABGe/YQEAqHPOHw:P1 (envelope-from ) for ; Tue, 08 Oct 2024 00:44:40 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id uNr2L3iABGe/YQEAqHPOHw (envelope-from ) for ; Tue, 08 Oct 2024 02:44:40 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=UL8MoIrG; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=VeB1K6Ud; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1728348280; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=pkiEA61EcFMYoZuqwsSoZu3wKXpyBEzuGXrm1ebzAYs=; b=S1PIm3MLJe2I7O6EwOU4AInlwaFMr0OxV0tSUBSOqakLd5wxW3tDfWYQN+uRLaiW66crZa bwvzZ+Ry88w275RZSjx45k+vOhiTqEUf8+HZaSGvO9bjtG5frKXw8Mf3WG7rdiMTuOHX/c XDNk4qSTJb4xkcxSa8DxiIcS+csACmPYRBsYfFdfgt+Z7ipq45xImA8jIZ/hUR5TVeFVe4 sWoBDD9iSmsDDZA2vw3QCejoemNHB+UO2ydk5tdBuYm9E7uFm/YG5DKPoeM+9F2CdouRyY kL2ToUE4lLhAtdGEjWrOsqlR/c9MHFgHoEdKrRZq067k7fBA1EiwKmtHVa9EBA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1728348280; a=rsa-sha256; cv=none; b=gmLYiDy4ulHsWwzDlbFey04SiGjHX3zKydq8cOrl+eaVIkojDNEImWDXfqI8+s416aHs2c P8ZNwGZozHXq8aWD4wX+AVYmwXRRkOkZExbjtdBhxhjeFZ4BofcKBzQbZ+lgLH3C4qRqRI LurIVIyuxD0iPEDR3RG4jTmtKwogwRX5uZXQI3a3ydSuF4cE54o5ADU+gcREmkkGOV3hfZ kwiUxbsLdcaG5G9qKNb64DFyZPFYbr0c6Ber7IeAdNtnmGYa9I5SblnQfSHxKDeh/ITBXw GN6vEZ2SvS4t8LkuZonyfQoTdzg9SDCcSUGU45+ri+EVDoNyrpJXebDIfPVuww== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=UL8MoIrG; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=VeB1K6Ud; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E73695BCBB for ; Tue, 08 Oct 2024 02:44:39 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sxxqX-00010j-VD; Mon, 07 Oct 2024 20:13:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sxxqT-00010a-Gb for guix-patches@gnu.org; Mon, 07 Oct 2024 20:12:57 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sxxqQ-00023q-NR for guix-patches@gnu.org; Mon, 07 Oct 2024 20:12:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=pkiEA61EcFMYoZuqwsSoZu3wKXpyBEzuGXrm1ebzAYs=; b=UL8MoIrGXygwOMMVcJrPE3yvgogElpzntl7lecx9ILsQy4m//MGtiJ9v9/sMUTtHpVmN9NmXDERpuVT7opFTnxr8W8CCQYup2g/IN+Mwuf83SXtkD3UMnCxE+OxhfjZYtbEGdFBfgNIwNqdQ0+WA9icR3fbz/Rejo6YVDW/m/A9rYCcU7a7fAT1Yulacw/pm5tP+JB184v/K3ztj5oe0K7EXcxuhLb1pQQjjJwReMgcgyKJ+WpAVuyVo8dxPF49l+nKyMtc4Kl0DkRTGKmpURQSk9QRCH5zYXsSZCT5qHli/yYXXCFvlRBOqyJQjFHFc/nfklovFJdnk3ePjSpc7/w==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sxxqY-00068z-13; Mon, 07 Oct 2024 20:13:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72925] [PATCH v10] gnu: Add jpm. Resent-From: Suhail Singh Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org, "Suhail Singh" Resent-Date: Tue, 08 Oct 2024 00:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72925 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Omar Bassam Cc: 72925@debbugs.gnu.org, Suhail Singh Received: via spool by 72925-submit@debbugs.gnu.org id=B72925.172834637823607 (code B ref 72925); Tue, 08 Oct 2024 00:13:01 +0000 Received: (at 72925) by debbugs.gnu.org; 8 Oct 2024 00:12:58 +0000 Received: from localhost ([127.0.0.1]:49511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxxqU-00068g-Fu for submit@debbugs.gnu.org; Mon, 07 Oct 2024 20:12:58 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:54450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxxqS-00068T-Vd for 72925@debbugs.gnu.org; Mon, 07 Oct 2024 20:12:57 -0400 Received: by mail-qt1-f193.google.com with SMTP id d75a77b69052e-4581e7f31eeso44066071cf.0 for <72925@debbugs.gnu.org>; Mon, 07 Oct 2024 17:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728346303; x=1728951103; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=pkiEA61EcFMYoZuqwsSoZu3wKXpyBEzuGXrm1ebzAYs=; b=VeB1K6Udy+Z+XUakJBqSElnHJakcuY9eRQNluOSyOIPlzbYMJwCfT0jfEi5Ujvro8k ScyQUJuecO1ytAWZoL5hXd7OzpGHQo7PosmZDsYhs1+JiNO8kMNCKjlo/s3iN5cIHRJR 0Z0WJV1OCpinC976HO+CF4fArFEKnmY1q+aiPAzUu9FlEHLk43GECdS1jmy7jENA9W/O ONX8YbXhZzJMkHarZFxwBv7px7sO3bGVG26a9ieEyxQDm6RhtwrrvHkE//7p0e4jATVe G+8zNi3Ni11y+6yEEYteAALHyqwzA/JvPpCJiHXXg4f6dIyLG2OputMM4F88BwBeem1Z OMvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728346303; x=1728951103; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pkiEA61EcFMYoZuqwsSoZu3wKXpyBEzuGXrm1ebzAYs=; b=FMXij8d8jGMDv2heXypELMzomi1lL+WczzZJrFwfFZSwwnYBG3hzxlFKeCWXSGZFNj 0dEpzLLOqIK6P8p8fOvI1o0CG7ThTo5oFAIEuhSHh9lwUqmRO/YsuacIFFcxY+ZBGx61 hiu9JXeOlCwdU4mchvzgT2+6RdDh9Ihl4CEGKZqJqY3cvk0Hy5xCQTLyQKR7XR4G3xUe tlxNppZKeln8vdXD3EKtXH92/wLgWOcLvyiYKY8J18CppjQADZTCWIxEk+3/7UduzsIK 1F3cnU8DQpjko031PrKW2gdorcqko7eoTfI4+8DvtOJeXyxDFb349MmFWbKfm9N4qLWs uyPw== X-Forwarded-Encrypted: i=1; AJvYcCVReZfeF2BLfrMlj4asZL6XQ394h7eGPMpdPs9csZocE6/Urh0hRZVQYxezn2zNBn5z1Xe1fw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yzc4kdEJjU8tOUJwim9CMZgewfsWPgLkzVIvbbi1HyjadAl8ggw p2EiXWU9Zy+blwjHI4ixLV6zwOR71xXgHE2qlZwfyZPr3MptncYSCrQTaRiT X-Google-Smtp-Source: AGHT+IGjp+8sO7+tMxIHUL+XKGsLqRDzsoOKmwxafGD3vhhpF4XXlbj+vV5HDn5oaxk8F55JgRJZnw== X-Received: by 2002:ac8:5a47:0:b0:458:4f11:3e15 with SMTP id d75a77b69052e-45d9ba427b9mr200309741cf.5.1728346302959; Mon, 07 Oct 2024 17:11:42 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45da74fac93sm31320261cf.36.2024.10.07.17.11.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 17:11:41 -0700 (PDT) From: Suhail Singh In-Reply-To: <87ed4rfwgw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> (Omar Bassam's message of "Tue, 08 Oct 2024 00:13:03 +0300") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <8734l86h4l.fsf@gmail.com> <871q0rhiu6.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <877cajiw5x.fsf@gmail.com> <87ttdng1u1.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <875xq3k6ue.fsf@gmail.com> <87ed4rfwgw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> Date: Mon, 07 Oct 2024 20:11:30 -0400 Message-ID: <87y12zh2rx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -0.28 X-Spam-Score: -0.28 X-Migadu-Queue-Id: E73695BCBB X-Migadu-Scanner: mx13.migadu.com X-TUID: 7AgzwvikldAv Omar Bassam writes: >>>>>>>> What we need is _some_ mechanism to ensure that when jpm invokes gcc (or >>>>>>>> g++), the compiler is able to locate the appropriate header files. >>>>>>>> >>>>>>>> This should be doable without propagating any other inputs. For example >>>>>>>> by ensuring that jpm sets appropriate environment variables (such as >>>>>>>> $CPATH , $C_INCLUDE_PATH , $CPLUS_INCLUDE_PATH etc.) or flags when >>>>>>>> invoking the compiler. If so, that would be the preferred approach. We >>>>>>>> only want to propagate those inputs that are strictly necessary. >>>>>>>> >>>>>>>> ... >>>>>>>> >>>>>>>> I look forward to seeing what you come up with in v11 :) >> >> I.e., it's not clear to me that propagating gcc and g++ is necessary. >> And if the same can be achieved by passing appropriate environment >> variables, why not? Could you please answer? >> >> Regardless, we are in agreement that the propagation of gcc-toolchain is >> not necessary and should be removed. >> > > I've now removed gcc from the propagated-inputs I've tested passing the > gcc to jpm using the --cc flag as follows "jpm build --cc=/path/to/gcc". Am I understanding correctly that, with v11 in order for the user to be able to install a Janet package such as "sh", they have to find the location of gcc being used by jpm and pass that to it? If so, why? This is not what I tried to explain above. The jpm package "knows" the specific version of gcc (and g++) that have been patched in, so why does it require the user to take additional action? I.e., the goal, IMHO, should be that in a pure container that contains nss-certs, one is simply able to run "jpm install -l sh" and it works. > I hope I understood your concern correctly this time. I don't believe so. > If not, please feel free to add to the patch whatever you think is > needed as I'm not a C compiling expert. Sorry, but I am no C compiling expert either. In addition, for the past few exchanges, it's not clear that I am able to bring value to the discussion. As evidenced by the recent exchanges, I seem to be struggling with expressing myself effectively. As such, I will step-away from actively reviewing this issue. I hope you are able to get jpm upstreamed with help from jgart and others more experienced than myself. -- Suhail