From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id GGgnNVSSSWdjhgAA62LTzQ:P1 (envelope-from ) for ; Fri, 29 Nov 2024 10:07:17 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id GGgnNVSSSWdjhgAA62LTzQ (envelope-from ) for ; Fri, 29 Nov 2024 11:07:16 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=FJa2CWvK; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="cNN/NWHt"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3188378103 for ; Fri, 29 Nov 2024 11:07:15 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tGxtw-0007K6-H7; Fri, 29 Nov 2024 05:07:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGxtv-0007Jk-EN for guix-patches@gnu.org; Fri, 29 Nov 2024 05:07:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tGxtu-0007FQ-QL for guix-patches@gnu.org; Fri, 29 Nov 2024 05:07:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=Z/CWGlh/7Lx6tEoysBq/e569H3pXHYqoJPlsWQmexV8=; b=FJa2CWvKeAgafG+wmJO8LyJGAN9AZrXMNhV6hn52EPh+fwwtNTCg/KJvoX9br3YTK/br6Xhsnu8Kv0Zcwz5T+Hjuso5RsMJ1CXFa5Q9ho4ISFS92HAHcm3CbLO6b7S4SZ0wvAyP6Nncer1Aj5qAhTl8GcG4Q5MQesoOIVIiNf1igDzEln0Nk2cinoBYDpbIiYrpR3r9LxnJ2rg0WPozQII0vbQqBLUUMe7ZtU9co7vnRfAYUO2OxkX+5I6FcqqCwR2rEllIIuPj7OIWCJKiX77JwQnr94TAyBW7oO0BFSvUlhhEi5i6Dh8aOkE+thpBnuUEhXFFIRPgiRNsuaOJPtw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tGxtu-0007Cj-B6 for guix-patches@gnu.org; Fri, 29 Nov 2024 05:07:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74394] [PATCH 0/2] Skip slow tests by default and run 'check' in Git pre-push hook. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 29 Nov 2024 10:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74394 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 74394@debbugs.gnu.org Received: via spool by 74394-submit@debbugs.gnu.org id=B74394.173287479427627 (code B ref 74394); Fri, 29 Nov 2024 10:07:02 +0000 Received: (at 74394) by debbugs.gnu.org; 29 Nov 2024 10:06:34 +0000 Received: from localhost ([127.0.0.1]:41189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxtR-0007BW-Tf for submit@debbugs.gnu.org; Fri, 29 Nov 2024 05:06:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tGxtQ-0007BI-6y for 74394@debbugs.gnu.org; Fri, 29 Nov 2024 05:06:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGxtK-0006vJ-Nh; Fri, 29 Nov 2024 05:06:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=Z/CWGlh/7Lx6tEoysBq/e569H3pXHYqoJPlsWQmexV8=; b=cNN/NWHtOORCMvJWtl1D vcuFHCIv6YB+unVCrVvIlrP86B3gJ/f5wFAc3E688NJ+u2leZ890gYbYiCMXKLSlMsfbPJ30Z6b9I lR05ZPs6nZnZYHt4sVYWC6MW6KzE+4Et3VWJSmbt/TA0KAHn29yOceNAF/FLSQyDs1V/xinlWy8WS CLJtDbTIxtX39yAA9zmYZzfYVu99ZJSOhDmi0WvD1TokF1sTLUsAauF3iAgZHPYXgLnesGRAi2EKb 0rU9QRbxWdrPJpcs57twN2zaCWxi2CjWCtZFtP4sebssteJ7s1DYakgbNeP1w5jixI/D8P+A2DRh2 itXvVOI6v70aGA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (Maxim Cournoyer's message of "Sun, 17 Nov 2024 21:03:30 +0900") References: Date: Fri, 29 Nov 2024 11:05:51 +0100 Message-ID: <87y1122w3k.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -7.31 X-Spam-Score: -7.31 X-Migadu-Queue-Id: 3188378103 X-Migadu-Scanner: mx10.migadu.com X-TUID: X77xkRMM4h5D Hi Maxim, Maxim Cournoyer skribis: > This is a simple change that should ensure test suite breakages are detec= ted > as early as possible and avoid tests breaking changes to be pushed. This= is > made possible by skipping a few expensive tests suite, bringing down the = total > test time to about 1 minute on a fast machine. > > We could call it a "distributed CI" approach ;-). I agree with the goal, of course, but not with the method: even without expensive tests, =E2=80=9Cmake check=E2=80=9D is going to take maybe 5=E2= =80=9310 minutes, and having that happen when you run =E2=80=9Cgit push=E2=80=9D can be a terribl= e development experience (especially since the developer most likely either already ran the test suite or part of it right before, or pushes package changes that have infinitely small probability of breaking =E2=80=9Cmake check=E2= =80=9D). Back to CI and not breaking things: I think that we should have a workflow where the forge triggers those checks and puts a green light if it passes, red light otherwise. (Basically what everybody else is doing. :-)) To me this should be one of the goals for the project in 2025. > To run the complete test suite including the slow tests (as is the case p= rior > this change): > > make check WITH_SLOW_TESTS=3D1 This variable itself may still be useful though (I=E2=80=99d call it =E2=80=98RUN_EXPENSIVE_TESTS=E2=80=99 or something like that=E2=80=94that= =E2=80=99s the name used in Coreutils=E2=80=94, =E2=80=9Cexpensive=E2=80=9D being the key word). I wou= ld also keep it on by default. Thanks, Ludo=E2=80=99.