all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Dariqq <dariqq@posteo.net>
Cc: 73859-done@debbugs.gnu.org
Subject: bug#73859: [PATCH 0/2] lightdm: Fix empty session list.
Date: Mon, 16 Dec 2024 11:35:57 +0900	[thread overview]
Message-ID: <87y10guzg2.fsf@gmail.com> (raw)
In-Reply-To: <cover.1730541249.git.dariqq@posteo.net> (dariqq@posteo.net's message of "Sat, 2 Nov 2024 10:18:31 +0000")

Hi Dariqq,

Dariqq <dariqq@posteo.net> writes:

[...]

> Dariqq (2):
>   gnu: lightdm: Use global sysconfdir.
>   gnu: lightdm-service-type: Add lightdm.conf to /etc/lightdm.

Finally pushed to master (see commits b9d7e15f9f and 3a8e19a61d), after
I had some time to properly review and test it.  I've adjusted the
commit messages a bit, and used this Scheme trick to reuse more of the
install phase arguments:

--8<---------------cut here---------------start------------->8---
               ;; matching tests.
-              (unsetenv "LC_ALL"))))))
+              (unsetenv "LC_ALL")))
+          (replace 'install
+            (lambda* (#:key make-flags #:allow-other-keys #:rest args)
+              ;; Override the sysconfdir flag only for the installation phase,
+              ;; as it attempts to write the sample config files to /etc and
+              ;; fail otherwise.
+              (define make-flags*
+                (append make-flags (list (string-append "sysconfdir="
+                                                        #$output "/etc"))))
+              (apply (assoc-ref %standard-phases 'install)
+                     (append args (list #:make-flags make-flags*))))))))
     (inputs
--8<---------------cut here---------------end--------------->8---

Closing.

-- 
Thanks,
Maxim




      parent reply	other threads:[~2024-12-16  2:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18  9:23 bug#73859: lightdm-service-type is almost unusable Dariqq
2024-10-23 14:48 ` Maxim Cournoyer
2024-10-23 18:15   ` Dariqq
2024-10-24  0:51 ` bug#73859: lightdm Feng Shu
2024-10-25  8:41 ` Feng Shu
2024-11-02 10:18 ` bug#73859: [PATCH 0/2] lightdm: Fix empty session list Dariqq
2024-11-02 10:18   ` bug#73859: [PATCH 1/2] gnu: lightdm: Use global sysconfdir Dariqq
2024-11-02 10:18   ` bug#73859: [PATCH 2/2] gnu: lightdm-service-type: Add lightdm.conf to /etc/lightdm Dariqq
2024-12-16  2:35   ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y10guzg2.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=73859-done@debbugs.gnu.org \
    --cc=dariqq@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.