From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id iIOTFfBKgGfSLgAAe85BDQ:P1 (envelope-from ) for ; Thu, 09 Jan 2025 22:17:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id iIOTFfBKgGfSLgAAe85BDQ (envelope-from ) for ; Thu, 09 Jan 2025 23:17:20 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="so3/b0Ia"; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=key2 header.b=j+MJ5HHr; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1736461040; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Vl1AVr/qLVl+SyKFX8mkCNvsHm+sQFCSkLArElwT/sY=; b=KDDrxtcGIxYxE0r8W9HndQ1XuPwZqsQULXFsxH15KS/PZcS2eYN1Xdqx8jCM+tuNCmS2JQ 689yqvy9kRaNuThwGKOVkQcGp/uD1o7ZTNovcaaYXAy/0GS5Wb2Fr4zIQ7mdV41JZTKomM l0kpb1//nVbLVQKsRMtQ0Pzm+E2XewjWMMgdTwSZa8TR7Sj735b4aEZzplJ0ca/zXTgIjU AhYjJlhpA2mfb9WnI4HPqWSmT8fxVKW8rt2hnuwY7k1myh6OBMNeRZLcXQjOekg5OjPwxk NWNoPbGY1ZhEXJYuUX3FYY8LT3bJF5Aoj3QinDVjiZ+ZChdGJyaKl5ns4Dh4sQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="so3/b0Ia"; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=key2 header.b=j+MJ5HHr; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1736461040; a=rsa-sha256; cv=none; b=RabfkhBuJdyeVORZq9quCjqMeueXWaTvsUkxM9n9nmzIrDYqzetO+zWLdDB5Z1DsO63NnW 8hpKSoRaVu8gubslD6ecUDqLVg2/tm8IPM1ZyBqR/ru0Fz5DYWHf60dhIlLUhZhrsO5z4L HCfdDLM4Ia6RrLCTXGulXGIJOnFg2rL+Q+NH5ZBLVlmLsSawdsZQJrb0x5wWJwGuJ7P92o tDEYgjrICr2bkZVAsJEA2FOujL59x4lUikFsQQdUcee3DMVEeLh5cirkOjWyxTQBAtZfpP BZ2ssIWnQ2RbhbH1Q1FA1tWQyIaBsUDMdRIz4LcLczXoAh2tTt2wf2U9e5kA5w== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DF74C97C77 for ; Thu, 09 Jan 2025 23:17:19 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tW0px-0005DZ-JY; Thu, 09 Jan 2025 17:17:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tW0pr-0005CO-Tv for guix-patches@gnu.org; Thu, 09 Jan 2025 17:17:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tW0pq-0002rH-BI for guix-patches@gnu.org; Thu, 09 Jan 2025 17:17:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=Vl1AVr/qLVl+SyKFX8mkCNvsHm+sQFCSkLArElwT/sY=; b=so3/b0IaLtusOYP7qUkETnAqe83zbkuW8mXAje3nziLQUGIj1Xr4UAGKWhOS+BPpR/KyKUqVD0EJiESnBlShom2Edik0RUiuNZA+V60v88AD8DjZzPOb835WWYMhc07WwfTVZJJ8tL6NcBXj0aSuEc51RDxCHy+mmg7XIPzp0gTk0yrUZytEJU/UHzhwu4NhfscJswrekNVIBeGMx5Cb6mwZdyPzf1MTqOPJVAhGDR3LZckaUulhBtJVKs0zBZZbtWt288Hhsr63OZpzCHtR9TJQdB0Ho8jvrtImVER2zPG9fLYJPLJNJa78igsKdQWDGG8v8HoZdhWa9oN64IIHow==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tW0pp-0000kd-Vz for guix-patches@gnu.org; Thu, 09 Jan 2025 17:17:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#75270] [PATCH v3 1/3] services: greetd: Improve greeter configurations. Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 09 Jan 2025 22:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75270 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: muradm Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 75270@debbugs.gnu.org, Maxim Cournoyer Received: via spool by 75270-submit@debbugs.gnu.org id=B75270.17364610142863 (code B ref 75270); Thu, 09 Jan 2025 22:17:01 +0000 Received: (at 75270) by debbugs.gnu.org; 9 Jan 2025 22:16:54 +0000 Received: from localhost ([127.0.0.1]:54803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tW0ph-0000k6-Uc for submit@debbugs.gnu.org; Thu, 09 Jan 2025 17:16:54 -0500 Received: from relay.yourmailgateway.de ([188.68.63.162]:40175) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tW0pf-0000js-1a for 75270@debbugs.gnu.org; Thu, 09 Jan 2025 17:16:52 -0500 Received: from mors-relay-8201.netcup.net (localhost [127.0.0.1]) by mors-relay-8201.netcup.net (Postfix) with ESMTPS id 4YTfJx1CxHz41Rf; Thu, 9 Jan 2025 23:16:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pelzflorian.de; s=key2; t=1736461009; bh=CeJX9Syocwu08Vo32RHr5DQvTkSXl/X+MbDcg66QwOk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=j+MJ5HHr9tlg96AEp16pWDg0N3zdAv4kUm2zXiwjGcHVgfoAOUmIY1H5qG4bxtir+ sJ2kLqLXBLEmbMw3uegS0/U/5HwITBL+tsP2uEwLcm1a6R6yF+V/KWqnbOvkqtcodD dqJem7fOpVqpoNx67bYDJw5tzpgvnnNM+sfoQ7+G9Ca0uRq6tnB++SOFhTsvVtclm3 ks6qZCV5jwQuYntcRWz9Eix6ZT2I4a1x46r7q6httLxB50SJebpm7I6/MyR1Xl86Ts COLLHQD3mOHgOow2PyWUvRJ+RIF54sQIKdIN0s9BF7OUvgAE+ooQFkjDyN4goA7lw/ TgbzsovhyblGQ== Received: from policy02-mors.netcup.net (unknown [46.38.225.35]) by mors-relay-8201.netcup.net (Postfix) with ESMTPS id 4YTfJx0Vyqz41R9; Thu, 9 Jan 2025 23:16:49 +0100 (CET) Received: from mxe217.netcup.net (unknown [10.243.12.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by policy02-mors.netcup.net (Postfix) with ESMTPS id 4YTfJv3lryz8sbH; Thu, 9 Jan 2025 23:16:47 +0100 (CET) Received: from florianhp (ipb21a5dbf.dynamic.kabel-deutschland.de [178.26.93.191]) by mxe217.netcup.net (Postfix) with ESMTPSA id C0BA7843E9; Thu, 9 Jan 2025 23:16:38 +0100 (CET) From: "pelzflorian (Florian Pelz)" In-Reply-To: (muradm's message of "Wed, 8 Jan 2025 20:47:41 +0300") References: Date: Thu, 09 Jan 2025 23:17:27 +0100 Message-ID: <87y0zjmy2w.fsf@pelzflorian.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: C0BA7843E9 X-Rspamd-Server: rspamd-worker-8404 X-NC-CID: GrYHuKCBaId8wdn3SM3ueyymICG5aa/NXjsz0FIQuwDVktQoOW7WXbFT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -6.39 X-Spam-Score: -6.39 X-Migadu-Queue-Id: DF74C97C77 X-Migadu-Scanner: mx10.migadu.com X-TUID: CCx0S7t6IfC8 Thank you muradm for simplifying greetd greeters. muradm writes: > -@item @code{sway-configuration} (default: #f) > -File-like object providing an additional Sway configuration file to be > -prepended to the mandatory part of the configuration. > +@item @code{sway-config} (default: @code{(plain-file "greetd-wlgreet-sway-config" "")}) > +Extra configuration for sway to be included before executing greeter. Could you retain the name of the existing field sway-configuration? Using abbreviations is uncommon in Guix, I think, but more importantly changes would need to go through a deprecation period with a news item and such, because the Guix API is stable and we have a deprecation policy. Also sway-configuration is used in many examples in the Guix manual. > + > +@item @code{wlgreet} (default: @code{wlgreet}) > +The package with the @command{/bin/wlgreet} command. > + > +@item @code{wlgreet-config} (default: @code{(greetd-wlgreet-configuration)}) > +Configuration of @code{wlgreet} represented by @code{greetd-wlgreet-configuration}. For analogy, I would name this wlgreet-configuration. I have not yet done a full review of your patch; it will take time; I hope somebody else does. Regards, Florian