From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add psutils.
Date: Mon, 21 Jan 2013 21:15:20 +0100
Message-ID: <87wqv68f8n.fsf@gnu.org>
References: <201301202333.31367.andreas@enge.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:58368)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1TxNmA-000246-U1
	for bug-guix@gnu.org; Mon, 21 Jan 2013 15:15:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1TxNm8-0003IK-7j
	for bug-guix@gnu.org; Mon, 21 Jan 2013 15:15:26 -0500
Received: from mail4-relais-sop.national.inria.fr ([192.134.164.105]:36082)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1TxNm8-0003I3-0Z
	for bug-guix@gnu.org; Mon, 21 Jan 2013 15:15:24 -0500
In-Reply-To: <201301202333.31367.andreas@enge.fr> (Andreas Enge's message of
	"Sun, 20 Jan 2013 23:33:31 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Andreas Enge <andreas@enge.fr>
Cc: bug-guix@gnu.org

Hi!

Andreas Enge <andreas@enge.fr> skribis:

> The attached patch adds psutils. Its license is homebrewed:
>    http://packages.debian.org/changelogs/pool/main/p/psutils/current/copy=
right
> Does it qualify as "bsd-like"?

It looks like BSD-3 to me, or at least =E2=80=9CBSD-like=E2=80=9D.

> If not, would it make sense to add a license "other" to licenses.scm,
> which takes the same parameters as "bsd-like"?

I think (guix licenses) should export the constructor, but under the
name =E2=80=98make-license=E2=80=99 to avoid clashes with the =E2=80=98lice=
nse=E2=80=99 field in
=E2=80=98package=E2=80=99 records.

> +         (substitute* "Makefile"
> +             (("/usr/local/bin/perl") (string-append perl "/bin/perl")))

Please align the opening paren under the =E2=80=98u=E2=80=99.  (Perhaps you=
r editor can
be tought to always do that?)

> +         (substitute* "Makefile"
> +             ((" install.include") ""))
> +              ;; drop installation of non-free files
> +         ))

Please put the comment above the line it refers to, and move closing
parentheses to the end of the line.

Nitpickingly yours,  ;-)
Ludo=E2=80=99.