From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add libpetsc
Date: Wed, 30 Apr 2014 23:29:33 +0200
Message-ID: <87wqe64ibm.fsf@gnu.org>
References: <87eh0emy00.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57914)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Wfc4W-0008Cn-Uz
	for guix-devel@gnu.org; Wed, 30 Apr 2014 17:29:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Wfc4P-0007bH-1g
	for guix-devel@gnu.org; Wed, 30 Apr 2014 17:29:44 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:53164)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Wfc4O-0007bB-QC
	for guix-devel@gnu.org; Wed, 30 Apr 2014 17:29:36 -0400
In-Reply-To: <87eh0emy00.fsf@gmail.com> (Eric Bavier's message of "Wed, 30 Apr
	2014 14:13:35 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <ericbavier@gmail.com>
Cc: guix-devel@gnu.org

Eric Bavier <ericbavier@gmail.com> skribis:

> From 73b22ecbc690a2acde4a5cd8a7f6f9b1f220bfe1 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Wed, 30 Apr 2014 14:01:43 -0500
> Subject: [PATCH] gnu: Add libpetsc
>
> * gnu/packages/maths.scm (libpetsc): New variable.
>   (libpetsc-complex): New variable.
> * gnu/packages/patches/petsc-fix-threadcomm.patch: New patch.
> * gnu-system.am (dist_patch_DATA): Add it.

[...]

> +(define-public libpetsc
> +  (package
> +    (name "libpetsc")

I think this should be =E2=80=9Cpetsc=E2=80=9D, as it=E2=80=99s the upstrea=
m name and commonly
used AFAIK.  WDYT?

[...]

> +         ;; Try to keep installed files from leaking build directory pat=
hs.
> +         ;; Fortran modules will have references to the build directory
> +         ;; because cmake passes absolute path names to the compiler.

Rather =E2=80=9Cdirectory names=E2=80=9D and =E2=80=9Cabsolute file names=
=E2=80=9D (info "(standards)
GNU Manuals").

(This CMake story is terrible, BTW.)

> +(define-public libpetsc-complex
> +  (package (inherit libpetsc)
> +    (name "libpetsc-complex")

Likewise, =E2=80=9Cpetsc-complex=E2=80=9D?

> +++ b/gnu/packages/patches/petsc-fix-threadcomm.patch

Please add a comment at the beginning of the patch saying what it does
and whether it=E2=80=99s available upstream.

Thanks,
Ludo=E2=80=99.