all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Eric Bavier <ericbavier@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add libpetsc
Date: Wed, 30 Apr 2014 23:29:33 +0200	[thread overview]
Message-ID: <87wqe64ibm.fsf@gnu.org> (raw)
In-Reply-To: <87eh0emy00.fsf@gmail.com> (Eric Bavier's message of "Wed, 30 Apr 2014 14:13:35 -0500")

Eric Bavier <ericbavier@gmail.com> skribis:

> From 73b22ecbc690a2acde4a5cd8a7f6f9b1f220bfe1 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Wed, 30 Apr 2014 14:01:43 -0500
> Subject: [PATCH] gnu: Add libpetsc
>
> * gnu/packages/maths.scm (libpetsc): New variable.
>   (libpetsc-complex): New variable.
> * gnu/packages/patches/petsc-fix-threadcomm.patch: New patch.
> * gnu-system.am (dist_patch_DATA): Add it.

[...]

> +(define-public libpetsc
> +  (package
> +    (name "libpetsc")

I think this should be “petsc”, as it’s the upstream name and commonly
used AFAIK.  WDYT?

[...]

> +         ;; Try to keep installed files from leaking build directory paths.
> +         ;; Fortran modules will have references to the build directory
> +         ;; because cmake passes absolute path names to the compiler.

Rather “directory names” and “absolute file names” (info "(standards)
GNU Manuals").

(This CMake story is terrible, BTW.)

> +(define-public libpetsc-complex
> +  (package (inherit libpetsc)
> +    (name "libpetsc-complex")

Likewise, “petsc-complex”?

> +++ b/gnu/packages/patches/petsc-fix-threadcomm.patch

Please add a comment at the beginning of the patch saying what it does
and whether it’s available upstream.

Thanks,
Ludo’.

  reply	other threads:[~2014-04-30 21:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30 19:13 [PATCH] gnu: Add libpetsc Eric Bavier
2014-04-30 21:29 ` Ludovic Courtès [this message]
2014-05-01 16:26   ` Eric Bavier
2014-05-01 18:20     ` Andreas Enge
2014-05-01 20:52   ` Eric Bavier
2014-05-02  6:53     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wqe64ibm.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=ericbavier@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.